The .MPC decompression methods are added to readMPC(). The position and
length of each data file in held in the struct DataFile, which are stored in the
Array gameData. To extract a file, you need to access its entry in
gameData and read the file from the given position.
The ADGameDescription object corresponding to hyperdemo.mpc is added to
gameDescriptions[]. Also, updated the getName() and
getOriginalCopyright() functions.
These were several undeclared fallthrough warnings i.e. after error
handler cases which will not return and another case of usage of
memset on a non-trivial structure which was fixed by using structure
constructor methods instead.
These were for possible unintended fallthrough, though inspection
shows that these were occurring after fatal error handler calls so
adding breaks would not be an issue.
However, since these call error() and thus the breaks will not be
executed and are thus "dead" code, this might provoke warnings in
future.
Another solution would have been to comment that these fallthroughs
are intended, but breaks are better in case the error handler is
changed in future.
CP850 is used by the mortevielle engine (and apparently by other
engines too). Anytime an engine using CP850 encoding wants to use
the TTS, the encoding has to be converted, so this is pretty
important encoding conversion to support. Unfortunately SDL
(when compiled without iconv) doesn't support this encoding
(which means, there might not be a way to convert this encoding
on some platforms), so I added a conversion table for this.
Similarly as on linux, there isn't enough control of the speech
queue to properly implement INTERRUPT_NO_REPEAT. So since this
commit we use our own queuing and use SAPI to speak each speech.
This is done outside the main thread.
Before I used SPD to queue messages and I had a copy of the queue,
so I could requeue everything when resume is called(). But more
control of the queue is needed, so I don't use the SPD's queue
and instead start speeches from my queue one by one from another
thread.
INTERRUPT_NO_REPEAT now behaves as described in the documentation
The NSSpeechSynthesizer is asynchronous and does not immediately start, pause,
or stop the speech. As a result querrying the state of the NSSpeechSynthesizer
does not alwats return the expected result (for example isSpeaking may not
yet been true just after we requested starting to speak). So instead the
TextToSpeechManager on macOS keeps track of the state itself.
Same implementations of TextToSpeechManager may require system events
to be processed for the state synchronisation to work properly.
This commit also fixes a few typos or inconsistencies in some texts.
It seems like, that at least some versions of speech-dispatcher
aren't able to successfuly pause and resume. For me, when trying
to pause, it still finishes the speech just being said instead
of pausing it and then it puts it at the end of the speech queue
with some speech-dispatcher internal commands added to it, which
are also hearable.
There is no way to find out where the speech ended when calling
pause, so it is just stopped and when resume is called it is
read from it's start again.
Nipun Garg
Thanasis Antoniou
D G Turner
sluicebox
Thierry Crozat
dafioram
SupSuper
Paul Gilbert
Jaromir Wysoglad