Arguably it's better to use a hard code constant anyway, as the result
of sqrt(2) can vary between platforms (not that it is likely to matter
in practice ;-) ).
This also makes the code independent of the user's locale (being
dependent on that by accident can lead to difficult to track down bugs)
The list of whitespace used now is what the C standard guarantees as
minimal set of characters accepted by `isspace` as whitespace.
The default source neutral volume for the Miles MIDI driver is set at 256.
However, the default source volume was the same as that of the regular MT-32/GM
driver: 255. This would cause a small volume decrease if a game did not set
source volume.
This commit fixes this issue by setting the default source volume for the Miles
MIDI driver at 256.
The ScummVM Miles AdLib driver would write some different initialization values
to the OPL registers than the original Miles drivers did. The most significant
difference was the amplitude and vibrato depth.
This commit changes the Miles AdLib driver to set the same values as the
original drivers. It also adds support for initializing a dual OPL2
configuration.
Miles 2 uses the default MT-32 pitch bend range of 12 semitones for its AdLib
driver. Miles 3 switched to the default GM pitch bend range of 2 semitones for
AdLib. ScummVM would always use the Miles 2 pitch bend range, which caused
pitch bend for Miles 3 games to sound wrong on AdLib.
To fix this, a property was added to the Miles AdLib driver to specify which
Miles version to emulate. Depending on the value of this option, the correct
default pitch bend range is set.
a52_init() unconditionally calls a52_imdct_init(), which prints "No
accelerated IMDCT transform found". This interferes with the normals
configure output, which looks like this:
Checking for liba52... No accelerated IMDCT transform found
yes
Max Horn
ScummVM-Translations
djsrv
a/
Eugene Sandulenko
athrxx
Coen Rampen
Orgad Shaneh
sluicebox
ysj1173886760