Commit Graph
73 Commits
Author SHA1 Message Date
BLooperZ 1e51c121bd SCUMM: reuse majmin codec for smap 2022-11-18 13:53:12 +01:00
Donovan Watteau 5d5ba3470f SCUMM: Fix AkosCostumeLoader on big-endian hosts
Commit befd3b3511 introduced a regression
on big-endian systems, causing Guybrush to moonwalk and Wally to lose
his body in the first scene of COMI, for example.

`costumeFlags` must be read as a little-endian value, now that it it's
been confirmed to be an uint16 and not a byte, in the disasms.

Found after diff'ing the -fverbose-asm output of akos.cpp during a Git
bisect on a big-endian system.
2022-10-08 20:43:18 +02:00
AndywinXp befd3b3511 JANITORIAL: SCUMM: Costume renderer and AKOS labeling
This commit:
- Continues my AKOS relabeling task and adds some documentation and missing information;
- Renames the codec functions from codec1, codec5 and codec16 to something more expressive;
- Add '_' in front of private class members, when missing;
- Changes "v1" names (unnamed variables supposedly coming from Ghidra or similar tools...) to something more expressive;
- Renames related variables from foo_bar (or foobar) to fooBar (on costume.cpp, base-costume.cpp and akos.cpp).
2022-09-28 00:12:52 +02:00
D G Turner 527da1a3a9 SCUMM: Fix Minor Code Breakage in AKOS Refactoring
This generated a number of GCC compiler warnings regarding the comparison
to the enumerated type (which are mostly equivalent to uint, not byte).
2022-09-26 23:38:47 +01:00
AndywinXp 8f744954c3 JANITORIAL: SCUMM: Improve readability of AKOS code
This is part of an on-going effort on my end to document the AKOS code, and fix strange stuff
such as integers being used as booleans, and variable_names instead of variableNames
2022-09-27 00:14:26 +02:00
AndywinXp 7fb79ea697 SCUMM: AKOS: Document opcodes
It was getting painful to go through the AKOS system without proper opcodes documentation, so here it is.
This was checked against COMI and SCUMM HE code, for names consistency.
2022-09-26 19:07:07 +02:00
BLooperZ 3776b4c384 SCUMM: HE: dump costume script 2022-08-29 21:51:37 +02:00
BLooperZ d0a0070d85 SCUMM: FREDDI4: fix lipsync issues 2022-08-23 21:44:05 +03:00
BLooperZ 6884be9b7f Revert "SCUMM: FREDDI4: workaround lipsync issues in final scene"
This reverts commit 16955a15f1.
2022-08-23 21:44:05 +03:00
BLooperZ 16955a15f1 SCUMM: FREDDI4: workaround lipsync issues in final scene 2022-08-02 22:17:49 +02:00
Donovan Watteau 452afa29ed SCUMM: Remove the smallCostumeScaleTableAKOS workaround
This was an old workaround for GCC 3.4, but we don't support this
compiler anymore since we now require C++11.  This removes a hack and
saves some bytes.

This undoes commit a7a17969c3.
2022-05-25 19:07:30 +03:00
Eugene Sandulenko abea37c9bb ALL: Update ScummVM project license to GPLv3+ 2021-12-26 18:48:43 +01:00
Andrea Boscarino f731cfd648 SCUMM: DiMUSE: New Digital iMUSE Engine (#3368)
SCUMM: DiMUSE: Add new implementation of the engine
2021-11-16 00:05:18 +01:00
Orgad Shaneh ed5489929c SCUMM: Use nullptr
Using clang-tidy modernize-use-nullptr
2021-11-14 15:51:59 +02:00
athrxx 82c0b91975 SCUMM: whitespace 2021-08-03 21:14:32 +02:00
athrxx 4fe69dbf2e SCUMM: fix bug no. 12499 ("Curse of Monkey Island Sprite Vertical Colour Artifacts")
(regression from b542fad7)

The introduction of the skip_column variable caused skipping of columns that are actually meant to be drawn. The original interpreter has a similiar mechanism, but it only applies to colors that are translated via the shadow palette. This avoids recursive shading (pixels that already got translated via the shadow palette could get passed through the table again in case of horizontal scaling). I guess that is what b542fad7 actually meant to fix.
2021-08-03 20:26:59 +02:00
Cameron Cawley d02daaeb2b SCUMM: Remove direct use of Graphics::Surface from ARM code (#2931) 2021-05-04 00:17:52 +03:00
D G Turner 59b639ed4d SCUMM: Fix Missing Default Switch Cases
These are flagged by GCC if -Wswitch-default is enabled.
2019-12-23 11:56:16 +00:00
Sven Meier 64c54591c3 SCUMM: Workaround erroneous AKC_JUMP in German SPY Fox 3
Fixes Trac#3813 and makes this version of the game completable.
2018-06-23 13:50:57 +02:00
Johannes Schickel 3847465163 SCUMM: Make GPL headers consistent in themselves. 2014-02-18 02:39:38 +01:00
Johannes Schickel c05cb7f3bb SCUMM: Prefer getBasePtr over direct Surface::pixels access. 2013-08-03 02:52:31 +02:00
Max Horn b37463fe59 SCUMM: Move class ResourceManager to its own header 2011-05-13 11:47:08 +02:00
strangerke 69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
Max Horn 0ce2ca4e00 COMMON: Replace MKID_BE by MKTAG
MKID_BE relied on unspecified behavior of the C++ compiler,
and as such was always a bit unsafe. The new MKTAG macro
is slightly less elegant, but does no longer depend on the
behavior of the compiler.
Inspired by FFmpeg, which has an almost identical macro.
2011-04-12 16:53:15 +02:00
Max Horn 3534cff8ef ALL: Fix indention (whitespaces -> tabs)
svn-id: r53738
2010-10-23 15:46:50 +00:00
Johannes Schickel 0ace80fed4 Fix for bug #2995282 "FT: Cavefish Hideout Chase (Failure Cutscene) Crash".
The bug itself is actually a regression from r43577, the merge
of the gsoc2009-16bit branch.

svn-id: r48987
2010-05-09 20:17:30 +00:00
Max Horn adaf3ec8b4 SCUMM: Rename _bitDepth to _bytesPerPixel
svn-id: r44336
2009-09-25 09:13:33 +00:00
Travis Howell 09845556e0 Revert revision 43410, and add alternative fix.
svn-id: r43416
2009-08-16 00:20:23 +00:00
Matthew Hoops 8e417b0884 Fix compile when compiling with --disable-he
svn-id: r43410
2009-08-15 14:50:21 +00:00
Travis Howell 9911c1bf59 Fix endian issue, the palette must be in little endian.
svn-id: r41184
2009-06-05 00:33:25 +00:00
Travis Howell fdbc49ab5f Fix the color of Poodles Galore's finger nails in Spy Fox 3.
svn-id: r41162
2009-06-04 11:03:45 +00:00
Travis Howell a45b902716 Ooops, re-enable codec32 code.
svn-id: r41161
2009-06-04 09:49:06 +00:00
Travis Howell 3a64d35dfd Add 16bit color support for later HE games.
svn-id: r41153
2009-06-04 01:05:47 +00:00
Travis Howell 2bf567d988 Fix possible regression in HE games re-releases.
svn-id: r39830
2009-04-04 06:03:09 +00:00
Max Horn 6f4b567124 SCUMM: Split intern.h into multiple headers
svn-id: r39567
2009-03-20 16:33:58 +00:00
Max Horn ac59693be2 A ton of code formatting fixes; also fixed warnings about single line loops like 'while(cond);' by inserting newlines
svn-id: r36127
2009-01-29 05:26:12 +00:00
Travis Howell 5bf899709c Switch assert to an error message, stating the exact unknown code.
svn-id: r35796
2009-01-09 12:08:06 +00:00
Travis Howell 7ec0a13949 Fix assert triggered when sorting out meals in Blue's 123 Time Activies.
svn-id: r35715
2009-01-04 05:19:52 +00:00
Travis Howell 4670e37a78 Use slow palette color match, for 16bit color HE games for now.
svn-id: r35713
2009-01-04 00:58:45 +00:00
Max Horn 1537e162f6 SCUMM: Moved more stuf from class Actor to ActorHE
svn-id: r34648
2008-09-25 10:11:06 +00:00
Max Horn 8d16a42c93 SCUMM: Added a new ActorHE class, as well as a virtual Actor::prepareDrawActorCostume() method
svn-id: r34646
2008-09-25 08:06:18 +00:00
Jordi Vilalta Prat 38a8aa516e Allow static and dynamic plugins to be used at the same time
svn-id: r31888
2008-05-06 03:00:26 +00:00
Nicola Mettifogo 258901bab9 Merged common/stdafx.h into common/scummsys.h. All referencing files have been updated.
svn-id: r28966
2007-09-19 08:40:12 +00:00
Max Horn 0cccbb29d6 Some cleanup (yay for whomever had the brilliant idea to let SVN work over HTTPS and hence through proxies&firewalls :)
svn-id: r28877
2007-09-08 11:15:27 +00:00
Chris Apers 500481c4ec Cleanup: remove obsolete code (PalmOS 68K version not supported anymore)
svn-id: r28803
2007-09-01 19:13:04 +00:00
Max Horn e1bcd70436 Re-added __attribute__(packed)
svn-id: r27830
2007-07-01 18:18:43 +00:00
Max Horn 218e132e37 Updated legal headers in source files, based on what Pidgin (the IM client formerly knowns as Gaim) does; added new (incomplete) COPYRIGHT file; updated copyright dates in a few spots
svn-id: r27024
2007-05-30 21:56:52 +00:00
Max Horn bb91c3a3ad SCUMM: some more AKOS cleanup & added comments
svn-id: r26054
2007-03-10 13:26:39 +00:00
Max Horn fc9af6a307 SCUMM: Must reset useBompPalette in the AKOS renderer
svn-id: r26052
2007-03-10 13:05:26 +00:00
Max Horn aba0cd04d6 SCUMM: got rid of the _bompActorPalettePtr member var (which was only used as a hidden param to drawBomp); turned drawBomp into a regular function (used to be a ScummEngine member method)
svn-id: r26045
2007-03-10 00:34:20 +00:00