Commit Graph
4589 Commits
Author SHA1 Message Date
Donovan Watteau 4939404410 SCUMM: Make Sam & Max WORKAROUND for Trac#269 an enhancement
I've checked with DREAMM that the original has the same behavior, and so
this script fix probably qualifies as an enhancement.
2023-01-17 19:53:41 +01:00
Donovan Watteau c131f1241c SCUMM: Make German Sam & Max WORKAROUND for Trac#12249 an enhancement
This comes from an original script error in this release, and so its fix
qualifies as an enhancement.
2023-01-17 19:37:17 +01:00
Donovan Watteau 91a37f88bf SCUMM: Make Sam & Max WORKAROUND for Trac#2068 an enhancement
The full context is documented in the original ticket, but we still need
this workaround if one plays with subtitles and voices and a slow text
speed, and this is indeed an original script issue since the small glitch
with the fishing line also happens with the original interpreters.

Since we're fixing an original, non-game-breaking bug, this qualifies as
an enhancement that one can disable if they want to be as close as
possible to the original experience.
2023-01-17 19:15:09 +01:00
eientei e2c447ad81 SCUMM: Fix regression in Actor::animateActor from 546fd42749
This would cause the meteor explosion in the Maniac Mansion (V2) intro
to not play. Bug reported in Discord by Vanfanel
2023-01-17 11:51:21 +01:00
Torbjörn Andersson 0e4169fdd3 SCUMM: Clarify Dig spider lair sound workaround
And since I have finally verified that it also happens with the original
interpreter, it is now an optional enhancement.
2023-01-17 07:41:20 +01:00
AndywinXp 58185c5654 SCUMM: SMUSH: Extend dynamic video framerate changes to all games
This has been verified from disasm, and also removes the need for
another old workaround.
2023-01-15 22:20:01 +01:00
AndywinXp f942b25fe4 SCUMM: FT (demo): Fix bike sprite Y position on lost fight 2023-01-15 22:18:23 +01:00
AndywinXp 9e7e6a08b2 SCUMM: INSANE/SMUSH: Implement video file dependent frame rate
In FT and DIG demo, video files have the correct frame rate encoded in the FLU header.
This fixes bug #14029.
2023-01-15 14:39:33 +01:00
AndywinXp d4a0ac0e78 SCUMM: DIMUSE: Fix uninit memory read for low latency mode 2023-01-15 12:12:06 +01:00
AndywinXp 1fcad262a3 SCUMM: INSANE: Fix missing voice file call 2023-01-15 01:28:44 +01:00
BLooperZ 4f5a71aae1 SCUMM: FT: Fix unitialized stream in low latency mode 2023-01-14 21:27:29 +01:00
AndywinXp a0a647c290 SCUMM: Properly sync voice mode flags between ScummVM and original GUI at startup
Fixes #14027.
2023-01-14 12:55:53 +01:00
AndywinXp 546fd42749 SCUMM: Properly fix bug #813
Verified for the disasms of v3-v6 and HE
2023-01-14 11:53:50 +01:00
AndywinXp 845c739801 SCUMM: DIMUSE: Avoid using a nullptr stream 2023-01-12 22:11:12 +01:00
AndywinXp 8d6737e16f SCUMM: DIMUSE: Increase buffer size for low latency mode 2023-01-10 21:17:23 +01:00
AndywinXp a41b1174ed SCUMM: v7-8: Add GUI option for toggling low latency audio mode 2023-01-10 21:17:23 +01:00
AndywinXp 8d0e97af70 SCUMM: DIMUSE: Implement low latency mode
This fixes bug #13462
2023-01-10 21:17:23 +01:00
AndywinXp 8dd19ae10f SCUMM: DIG (demo): Fix voice mode behavior 2023-01-08 23:26:47 +01:00
AndywinXp 7c158b1005 SCUMM: GUI: Fix voice mode string id for foreign versions of FT 2023-01-08 23:26:27 +01:00
AndywinXp 61fa4b6253 SCUMM: v7-8: Fix FT camera bug and properly fix #1195 and #1579
There was a nasty bug in the fuel tower room, when the cops arrive at the
tower and the player regains control, in which the camera would be brought up
and then down again.

While I was there, since this is the same domain, I rechecked the v7-8 camera
code from the disasm, made some corrections, and properly fixed #1195 and
#1579. Another workaround bites the dust :)
2023-01-08 17:42:50 +01:00
AndywinXp 468dd3ab4d JANITORIAL: SCUMM: Reword SMUSH codec comment 2023-01-04 22:09:52 +01:00
AndywinXp a6500c009d JANITORIAL: SCUMM: Clean-up and relabel SMUSH codecs 37 and 47 2023-01-04 21:56:50 +01:00
AndywinXp 833703b0b1 JANITORIAL: SCUMM: Remove magic numbers and document VOC format blocks 2023-01-04 19:59:42 +01:00
AndywinXp 4d556f0db6 JANITORIAL: SCUMM: Change order of class members declarations
The _output* vars are semantically separate from the _internal* ones
2023-01-03 09:51:15 +01:00
AndywinXp 5b18d1aa6b SCUMM: DIMUSE: Implement support for higher internal sample rates
This lays the ground for:
* Supporting fan dubbings and self-made high quality music replacement;
* Reintroduction of support for compressed audio.
2023-01-02 23:30:57 +01:00
AndywinXp 92efa503fb SCUMM: DIMUSE: Fix theoretical possibility of division by zero 2023-01-02 23:05:50 +01:00
AndywinXp c3256a614a SCUMM: DIMUSE: Make engine sample rate and feed size parametric 2023-01-02 22:55:26 +01:00
AndywinXp 655a9774c0 SCUMM: LOOM (CD/Steam): Implement CD Audio music/speech reloading
We were already saving the relevant info for doing that, we simply never used it :-)
2023-01-02 20:21:46 +01:00
AndywinXp b4c52cac22 SCUMM: DIMUSE: Implement adaptive buffer underrun correction
Thanks to lephilousophe for the help on this one :-)
2023-01-02 17:50:00 +01:00
AndywinXp c93d460ee2 SCUMM: FT: Fix mouth sync fetching and improve readability 2023-01-01 10:50:46 +01:00
D G Turner c05a8a71c6 SCUMM: Fix Signed vs. Unsigned Comparison GCC Compiler Warning 2022-12-30 20:40:41 +00:00
AndywinXp 5c9b0a8aa2 SCUMM: GUI: Implement Atari ST cursors 2022-12-29 14:55:58 +01:00
AndywinXp efb8cfbe33 SCUMM: Update Maniac NES detection entry for GUI support 2022-12-29 11:26:00 +01:00
AndywinXp b376f0010f SCUMM: GUI: Add support for Maniac NES 2022-12-29 11:19:45 +01:00
AndywinXp 995b83c546 SCUMM: GUI: Allow quitting with ALT-X and ALT-Q combinations 2022-12-28 19:15:39 +01:00
AndywinXp bc531b3738 SCUMM: GUI: Allow SHIFT-B to be also used for the buffer shortcut 2022-12-27 15:37:30 +01:00
AndywinXp e49e3c27f6 SCUMM: ZAK: Fix cursor colors for v1 C64 version 2022-12-27 15:14:14 +01:00
AndywinXp 6f4acceede SCUMM: GUI: Insert workaround for german LOOM FM-Towns
Fixes a part of bug #13980
2022-12-27 15:00:56 +01:00
BLooperZ 1273df2426 SCUMM: Optimize BOMP raw copy when transparency is not needed 2022-12-26 20:28:54 +01:00
BLooperZ 8cfec8a3c9 SCUMM: Reuse bomp decoder for SMUSH RLE codec 2022-12-26 20:28:54 +01:00
Donovan Watteau 30a1b4867e SCUMM: Fix a couple of sound issues in Indy3 Macintosh (Trac#13887)
If you ring the boxing bell right at the start of the game, you'll see
Indy hit it 3 times, but the actual bell sound will only be heard twice.
This doesn't happen in the original interpreter or in the other releases
where it can be heard 3 times as expected.  Another example is the sound
effect for thunder when Indy is outside the windows of Castle Brunwald;
although it sounds a bit weird this way, the sound is really meant to
have some quick "false starts".

The byte at offset 26 might be responsible for this, in that if it's
unset, the current (identical?) sound is maybe meant to be interrupted.
This is just based on the Indy3 Amiga fixes brought by PR#3598, and
from some naive guesswork. But this change is only applied to Indy3 Mac
and appears to cause no regression (I've done a full gameplay).

Thus, until someone checks this against the original Indy3 Macintosh
interpreter (we have no disasm for it yet), doing this change probably
makes sense for now...

And Andy says I should be more confident about this change :p
2022-12-25 21:17:36 +01:00
elasota e280186a8c ALL: VS warning cleanup 2022-12-25 16:31:57 +01:00
AndywinXp e0dc1aed5f SCUMM: DIG: Fix #13973 (buffer overflow error)
This fix has been verified from disasm, merry xmas :-)
2022-12-24 22:32:10 +01:00
Donovan Watteau 818194e8cf SCUMM: Fix build on older systems lacking strnlen 2022-12-24 09:32:45 +01:00
AndywinXp 92454c2c0c SCUMM: SMUSH: Relabel codecs 1, 3 and 20 2022-12-21 19:58:17 +01:00
AndywinXp 4d6d76b60b SCUMM: GUI: Implement missing banners for v6 games 2022-12-20 22:38:26 +01:00
eientei 9bbbf55c8a SCUMM: Add more sizes to detection entries 2022-12-20 18:44:07 +02:00
D G Turner 9d1d5ba338 SCUMM: GUI: Fix GCC Compiler Parantheses Needed Warning 2022-12-14 09:18:26 +00:00
AndywinXp c356df9095 CREDITS: Update SCUMM section 2022-12-13 21:25:26 +01:00
AndywinXp 76f4371f45 SCUMM: GUI: Handle numbers strings with const chars instead of String objects 2022-12-13 18:40:11 +01:00