Commit Graph
40 Commits
Author SHA1 Message Date
sluicebox ae5db52c2e SCI: Remove speed test detector
This heuristic was originally how all SCI16 speed tests were handled.
It has been gradually replaced with script patches, until all games
were patched in: ea48986006

At the time, I left this in because it had the benefit of speeding up
the SCI11 test variants so that they didn't produce a startup delay.
Now we know that this heuristic has been identifying regular rooms as
speed tests and unthrottling them too, causing unintended effects.
Some of this behavior was masked by fast-cast throttling occurring
everywhere, until: e09010f7d8

For example, the QFG1VGA Sierra logo animation changes speed and runs
very fast as soon as the sparkle is finished. The Longbow map rooms
were also detected as speed test rooms and animated too fast. Cast-less
rooms like LB2's title screen run unthrottled and consume CPU.

There are only a few SCI11 speed test rooms, so now they're explicitly
unthrottled in kGameIsRestarting with the other throttling exceptions.
2022-12-21 12:26:51 -08:00
Eugene Sandulenko abea37c9bb ALL: Update ScummVM project license to GPLv3+ 2021-12-26 18:48:43 +01:00
Martin Kiewitz 82165bb6f6 SCI: Improve kAnimate fastcast detection, Remove EQ1 hack
- Add "kAnimate fast cast state" to "version" debug command
- Make it possible for script patcher signatures to get fully
used outside of the regular script patcher
- Remove previous fastcast detections and replace them with
a signature heuristic
- Remove object name checking, when fastcast global is set
- Heuristic detects "fast cast" support incorrectly for multilingual
KQ5, but it seems the game never sets the global, so it won't
matter. KQ5 CD (also SCI1 late) has fastcast support.
- Remove hack in GfxView::draw
- Add lots of comments to ScriptPatcher class

This fixes EcoQuest 1 Floppy showing the anemone on top of the
message box (see bug #5170)
2016-02-23 20:17:18 +01:00
Johannes Schickel 8fc7d60feb SCI: Make GPL headers consistent in themselves. 2014-02-18 02:39:37 +01:00
Filippos Karapetis 31aec8c581 SCI: Some more work on scaling in SCI32 2013-01-13 17:28:09 +02:00
strangerke 69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
md5 1e68000def SCI: Added a new console command, "animate_list" or "al"
This shows the current animation list, along with object properties,
positions and the scripts they belong to
2011-03-20 04:10:29 +02:00
md5 a01395bb45 SCI: Cleaned up and segmented the animate code in order to make it a bit more readable 2011-02-23 13:28:17 +02:00
Filippos Karapetis d3340b0d0c SCI: Commented out unused signal flags
svn-id: r54974
2010-12-20 12:19:28 +00:00
Martin Kiewitz d078a4d235 SCI: fix gfx issues when giving out cards hoyle4
bit 2 actually triggers special drawing of cels in sierra sci

svn-id: r53855
2010-10-26 20:19:17 +00:00
Martin Kiewitz 9af803f575 SCI: kAnimate bit 2 is hoyle 4 exclusive
adjusted comments about that and also renamed the bit, also added additional TODO, because hoyle 4 has special code that gets into action, when bit 0 is not set, but bit 2 is

svn-id: r53853
2010-10-26 16:21:00 +00:00
Martin Kiewitz a877ba0026 SCI: little cleanup kAnimate
svn-id: r53852
2010-10-26 15:29:04 +00:00
Martin Kiewitz 6798b01569 SCI: add global scaling again to kAddToPic
fixes regression of r52887 - lb2 actors not scaled correctly bug #3083577

needs to get backported

svn-id: r53068
2010-10-08 10:35:25 +00:00
Martin Kiewitz 18cd3333c0 SCI: changes to kAddToPic
kAddToPic doesnt do loop/cel fixups, it also doesnt support global scaling and will only set nsRect on scaled Cels, not reusing fill() of kAnimate anymore, but doing those things separately

fixes kq6 - 2nd window shown instead of peppermint bush (bug #3070465)

should be save to backport

svn-id: r52887
2010-09-25 19:28:56 +00:00
Lars Skovlund bd9f9bb06e SCI: Handle bit 2 of scaleSignal by not updating nsRect values when
it's set. Currently game-specific for Hoyle4; fixes bug #3038424. But
other SCI1.1 games should be tested with a general version of this to
see whether it fixes relevant bugs.

svn-id: r52818
2010-09-20 18:31:59 +00:00
Martin Kiewitz 7e3b2bedb6 SCI: revert r51969
broke laura bow 1, need to figure out whats exactly wrong

svn-id: r52004
2010-08-11 21:16:45 +00:00
Martin Kiewitz ab35ae03c3 SCI: kAddToPic only wrote nsRect in sci1.1
fixes regression of r51952 and bug #3042957

svn-id: r51971
2010-08-11 12:01:56 +00:00
Martin Kiewitz 42c3cc4c08 SCI: kAnimate invalid loop/cels now correctly fixed
fixes kq5 trunk getting closed again during intro - is actually a script bug that sets cel to some really high number - bug #3037578, may also fix other similar issues

svn-id: r51969
2010-08-11 05:20:29 +00:00
Martin Kiewitz a201b2e506 SCI: kAddToPic(list) set fixed priority flag
svn-id: r51954
2010-08-10 17:16:38 +00:00
Max Horn 32b69ccd9d SCI: Simplify GfxAnimate code, get rid of _listData
svn-id: r50496
2010-06-29 14:54:15 +00:00
Martin Kiewitz 3bc011357b SCI: some initial work on global scaling
svn-id: r50179
2010-06-23 12:58:14 +00:00
Filippos Karapetis 5d71ae952f The EngineState is no longer recreated when a game is restored, thus we don't need to refresh pointers to it
svn-id: r49549
2010-06-09 20:12:25 +00:00
Martin Kiewitz e9db62b272 SCI: sort according to original order in kAnimate, when y and z are the same - fixes iceman half-open compartment in room 35
svn-id: r49189
2010-05-24 15:39:30 +00:00
Martin Kiewitz 194bdd9b83 SCI: reverting r48787 port updates were actually introduced (heard that before) in SCI1. I used the outdated wiki before and that one lists qfg2 and xmas90ega being SCI01. They are actually SCI1
svn-id: r48789
2010-04-24 21:45:17 +00:00
Martin Kiewitz cbd8faa82e SCI: r48786 port updates were actually introduced during SCI01, qfg2 and xmas90ega only. We enable port updates only for non-multilingual SCI01 games now - fixes percentage bar for qfg1 japanese as well
svn-id: r48787
2010-04-24 20:41:26 +00:00
Max Horn 92c896d883 Patch #2973290: Semicolon cleanup
svn-id: r48359
2010-03-22 20:28:08 +00:00
Martin Kiewitz ab2941bb52 SCI: adding some minor documentation for the various graphic classes
svn-id: r47904
2010-02-05 15:48:45 +00:00
Martin Kiewitz 6c204cc890 SCI: renamed class Cursor to GfxCursor
svn-id: r47902
2010-02-05 13:05:26 +00:00
Martin Kiewitz c336204a3f SCI: renaming Transitions to GfxTransitions
svn-id: r47890
2010-02-04 21:04:47 +00:00
Martin Kiewitz b0208e7306 SCI: moving structs/enums from helpers to animate/controls
svn-id: r47813
2010-02-02 14:41:17 +00:00
Johannes Schickel 594d82e287 Fix possible memory leaks.
svn-id: r47755
2010-01-31 16:32:11 +00:00
Martin Kiewitz 72c2d360f7 SCI: renamed SciPalette to GfxPalette, Screen to GfxScreen, GfxPalette is now called directly w/o SciGui
svn-id: r47752
2010-01-31 16:21:11 +00:00
Martin Kiewitz c991a5bceb SCI: renamed SciGuiAnimate to GfxAnimate, moved code from SciGui into this class, now getting called directly
svn-id: r47751
2010-01-31 15:07:36 +00:00
Martin Kiewitz 7929255cd9 SCI: cleaned up graphics classes, removed gfx&windowmgr, added gfxports, gfxcompare, gfxpaint16, gfxcache. kernel uses gfxports directly w/o going through SciGui
svn-id: r47745
2010-01-31 12:35:15 +00:00
Martin Kiewitz 3e44180e47 SCI: speed throttler changed, now gets triggered by kAnimate, removed initial no-delay, i'm still getting animation now in iceman and sq3, slow palette animation in longbow fixed
svn-id: r47343
2010-01-17 18:41:28 +00:00
Martin Kiewitz 7c8ae63101 SCI: more detail info about scaleSignal bit 1
svn-id: r47314
2010-01-15 21:40:58 +00:00
Martin Kiewitz 8689f1d8cc SCI: added enum for ScaleSignal
svn-id: r47313
2010-01-15 21:32:18 +00:00
Filippos Karapetis 254850aa23 - Some work on kLocalToGlobal and kGlobalToLocal for SCI2+
- Removed the custom types MemoryHandle, LoopNo, CelNo (cause we ended up having code like LoopNo loopNo = ...)
- Improved the sanity checks in frameOut()

svn-id: r47087
2010-01-06 17:25:54 +00:00
Filippos Karapetis 45bf6fc0d7 Removed a leftover unused hack from the old graphics code
svn-id: r47026
2010-01-05 14:17:47 +00:00
Filippos Karapetis d99aa0f126 More renaming
svn-id: r47009
2010-01-05 01:37:57 +00:00