Commit Graph
177 Commits
Author SHA1 Message Date
Le Philousophe 700a965361 LURE: Don't use unsafe strcat and strcpy 2022-10-23 22:46:19 +02:00
Eugene Sandulenko abea37c9bb ALL: Update ScummVM project license to GPLv3+ 2021-12-26 18:48:43 +01:00
Orgad Shaneh 04eacfa7d3 LURE: Use nullptr
Using clang-tidy modernize-use-nullptr
2021-11-14 15:51:59 +02:00
Paul Gilbert 8f3819ccfe LURE: Added support for Konami English VGA version 2021-04-27 20:30:01 -07:00
Orgad Shaneh b2122f4eeb LURE: Fix misleading indentation
Detected by Clang.
2021-03-15 13:21:15 +02:00
NMIError 3b41b6a16b LURE: Fix water sound when opening or closing door
Some room exit data have the door opening or door closing sound defined as 0
(f.e. the cave doors). This means no sound should be played. ScummVM would play
sound 0 instead, which is the running water sound. This change fixes this by
checking for value 0 and not playing a sound in that case.
2020-12-08 21:27:57 +01:00
NMIError 7642698fd7 LURE: Fix door sounds
ScummVM did not seem to trigger door opening and closing sounds, f.e. the cell
door at the start of the game. The checks in the roomExitAnimHandler compared
hotspot IDs to room numbers, which are different sets of IDs AFAICT. Also, the
door opening part would decrease the frame counter first, then compare to the
set destination frame. The opening sound should often be triggered at the start
of the animation, but because the frame counter is decreased first, it does not
trigger at the first frame. I moved the frame counter decrease after the check
to fix this.
2020-12-08 21:27:56 +01:00
Paul Gilbert 33fb0f235d LURE: Properly reset straw fire animation
Fix provided by whizse
2020-09-29 21:55:29 -07:00
D G Turner 4af25ccfdd LURE: Fix Missing Default Switch Cases
These are flagged by GCC if -Wswitch-default is enabled.
2019-11-15 02:51:50 +00:00
Paul Gilbert 11e33ba3fc JANITORIAL: Removing trailing spaces after int casts 2018-08-17 20:30:20 -07:00
Paul Gilbert 898b79f8dc LURE: Adjust switch fall through comments 2017-08-06 22:20:16 -04:00
Torbjörn Andersson 70a2ca8b7d JANITORIAL: Silence more GCC 7 warnings
All these fall through were marked as deliberate, so again I've only
changed the comment to silence GCC.
2017-08-06 13:30:51 +02:00
Eugene Sandulenko dd1838a3cb LURE: Fix potential buffer overrun introduced in 8577606 2016-05-16 16:56:57 +02:00
Eugene Sandulenko 8577606b04 LURE: Safer string manipulation 2016-05-13 09:23:20 +02:00
Johannes Schickel b03ca0e80a LURE: Make GPL headers consistent in themselves. 2014-02-18 02:39:36 +01:00
Torbjörn Andersson 0d14f9d009 LURE: Fix some formatting. 2013-08-08 17:57:58 +02:00
Paul Gilbert a979ec6c97 LURE: Added explicit comment to switch block fall-through 2013-07-19 23:10:25 -04:00
Willem Jan Palenstijn 2d1fd3b554 ALL: Fix typo (existant->existent) 2013-02-23 22:07:32 +01:00
Christoph Mallon e40ba4c135 JANITORIAL: Simply use *x instead of *x.get() on smart pointers. 2012-03-13 15:43:59 +01:00
Christoph Mallon 337d5da913 JANITORIAL: Make getters const. 2012-03-13 15:43:30 +01:00
Torbjörn Andersson 6530da3feb LURE: Move readByte() call out of assert() 2012-01-14 23:58:59 +01:00
D G Turner 1cb4af9c4c LURE: Reduce usage of 'goto'.
Have refrained from changing the usage of 'goto' in the PictureDecoder
class (decode.cpp) for the time being, as this class is using these in
pseudo-x86 code which is complex and should be replaced anyway.
2011-12-08 23:21:40 +00:00
Eugene Sandulenko b3cad04450 LURE: Fix warnings 2011-11-03 00:20:10 +00:00
Paul Gilbert 197409da40 LURE: Fix crash caused by trying to talk to a character when an ask action is in progress 2011-09-09 22:10:03 +10:00
eriktorbjorn 5dd8f2575b JANITORIAL: Silence a couple of "variable set but not used" warnings. 2011-06-30 23:47:10 +02:00
strangerke 69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
Max Horn 84184aabc0 ALL: colour -> color 2011-04-14 14:12:35 +02:00
Max Horn 90b6cdfbdf LURE: Remove all uses of (f)printf; cleanup
svn-id: r54106
2010-11-07 01:03:03 +00:00
Paul Gilbert 655e4a961a LURE: Bugfix for characters getting stuck in Abbey doorway
svn-id: r53402
2010-10-13 10:12:35 +00:00
Paul Gilbert b15f51ad7b LURE: Fix for #3062794 - Diermot cannot leave room 7
svn-id: r53039
2010-10-06 09:55:41 +00:00
Paul Gilbert 61afea6cbe LURE: Bugfix for #3060480 - Ratpouch alternating between rooms
svn-id: r53026
2010-10-05 09:14:18 +00:00
Paul Gilbert 5a4df6fc95 Minor bugfix for the shop-keeper sequence when you're viewing through the window - it was supposed to check whether Gwyn, rather than Goewin, is not in the room before sticking his fingers in his ears
svn-id: r48812
2010-04-27 10:59:28 +00:00
Torbjörn Andersson 2e89d9607d Fixed GCC warning about 'hotspotId' shadowing a member of 'this'. Let's call
the variable 'charId' instead, like in the debug messages where it's used.

svn-id: r48759
2010-04-21 05:30:38 +00:00
Paul Gilbert dead0db8d8 Corrected a debug statement that could use an object field after the object was destroyed
svn-id: r48741
2010-04-20 10:13:27 +00:00
Paul Gilbert f1979f936f Bugfix for correctly returning follower to player when they're blocked from acting
svn-id: r48709
2010-04-19 09:40:20 +00:00
Paul Gilbert cbee83a536 Added a default case for characters that don't have a message set, but try to display one
svn-id: r48656
2010-04-14 09:33:27 +00:00
Paul Gilbert 4aacbc5351 Corrected check to ensure return isn't issued if it's already in progress
svn-id: r48535
2010-04-05 07:27:16 +00:00
Paul Gilbert 29a8cb651a Bugfix for correctly getting a follower to return to player when blocked from exiting a room 5 times
svn-id: r48533
2010-04-05 06:07:14 +00:00
Paul Gilbert 8dfd670b22 Added explicit initialisation of NPC directions in the hotspot constructors
svn-id: r48406
2010-03-26 22:16:45 +00:00
Max Horn bce959e046 LURE: Remove evil 'using namespace' from header files
svn-id: r47396
2010-01-19 23:48:55 +00:00
Paul Gilbert e27ef211f8 Fix for a rare case where the NPC handler for Ewan the shopkeeper can cause an assert when you rejoin Goewin in the Weregate caves.
svn-id: r47197
2010-01-09 09:27:40 +00:00
Torbjörn Andersson 72eb9ec9ea Fixed a bunch of cppcheck warnings. Mostly about checking if a pointer is null
before freeing it, which isn't necessary.

svn-id: r46941
2010-01-03 19:37:43 +00:00
Max Horn 2df38ec61e LURE: Turn HotspotTickHandlers into a proper class; convert static vars in various of its methods to member vars
svn-id: r45285
2009-10-20 19:51:57 +00:00
Max Horn f242266f6d Change a couple places from 'end of namespace' to 'End of namespace', for consistency
svn-id: r44634
2009-10-04 21:26:33 +00:00
Johannes Schickel ac5a6552ca Switched LURE to use a single central RandomSource instance, instead of (sometimes) creating a new RandomSource every function call.
svn-id: r43715
2009-08-24 23:04:25 +00:00
Johannes Schickel 7e71865e91 Move the event recorder to its own class (EventRecoder inside common/EventRecorder.[h/cpp]).
svn-id: r42751
2009-07-25 12:59:46 +00:00
Paul Gilbert 53783575d8 Bugfix for player blocking room entrance causing NPCs trying to enter getting an excessive number of action entries
svn-id: r42676
2009-07-23 10:49:30 +00:00
Paul Gilbert 26210ad976 Bugfix to stop characters changing rooms if the entrance in the other room is blocked by another NPC
svn-id: r36144
2009-01-30 12:22:30 +00:00
Paul Gilbert 8315753dda Bugfix to allow characters to start moving when some other object (such as a door) has marked part of the area the character is standing on as occupied
svn-id: r36120
2009-01-28 10:27:14 +00:00
Eugene Sandulenko 696897b058 Whoa! Removing trailing spaces.
svn-id: r35648
2009-01-01 15:06:43 +00:00