ScummVM/scummvm
1
0
Fork 0
mirror of https://github.com/scummvm/scummvm.git synced 2026-06-20 05:45:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
137,148 Commits 45 Branches 139 Tags
de151ea3fddd6a2d36a41400a55366bd2a6a94de
Commit Graph
126 Commits
Author SHA1 Message Date
Eugene Sandulenko abea37c9bb ALL: Update ScummVM project license to GPLv3+ 2021-12-26 18:48:43 +01:00
Orgad Shaneh 13bcd9a0f7 HOPKINS: Use nullptr 
Using clang-tidy modernize-use-nullptr
 2021-11-14 15:51:59 +02:00
D G Turner 0386fd0eea HOPKINS: Fix Missing Default Switch Cases 
These are flagged by GCC if -Wswitch-default is enabled.
 2019-10-23 23:42:38 +01:00
Adrian Frühwirth a20f90cbb7 JANITORIAL: Fix formatting 2018-04-22 00:56:21 +02:00
Adrian Frühwirth 00e59a3122 ALL: Load savegame thumbnail only when necessary 
This commit introduces the following changes:

1. Graphics::loadThumbnail()

   Now returns a boolean and takes a new argument skipThumbnail which
   defaults to false. In case of true, loadThumbnail() reads past the
   thumbnail data in the input stream instead of actually loading the
   thumbnail. This simplifies savegame handling where, up until now,
   many engines always read the whole savegame metadata (including
   the thumbnail) and then threw away the thumbnail when not needed
   (which is in almost all cases, the most common exception being
   MetaEngine::querySaveMetaInfos() which is responsible for loading
   savegame metadata for displaying it in the GUI launcher.

2. readSavegameHeader()

   Engines which already implement such a method (name varies) now take
   a new argument skipThumbnail (default: true) which is passed
   through to loadThumbnail(). This means that the default case for
   readSavegameHeader() is now _not_ loading the thumbnail from a
   savegame and just reading past it. In those cases, e.g.
   querySaveMetaInfos(), where we actually are interested in loading
   the thumbnail readSavegameHeader() needs to explicitely be called
   with skipThumbnail == false.

   Engines whose readSavegameHeader() (name varies) already takes an
   argument loadThumbnail have been adapted to have a similar
   prototype and semantics.
   I.e. readSaveHeader(in, loadThumbnail, header) now is
   readSaveHeader(in, header, skipThumbnail).

3. Error handling

   Engines which previously did not check the return value of
   readSavegameHeader() (name varies) now do so ensuring that possibly
   broken savegames (be it a broken thumbnail or something else) don't
   make it into the GUI launcher list in the first place.
 2018-04-07 09:26:20 +02:00
Johannes Schickel d5b21c4036 HOPKINS: Make GPL headers consistent in themselves. 2014-02-18 02:39:35 +01:00
Strangerke 582a681c67 HOPKINS: Replace cascades of if by switches for language checks 2013-11-09 20:06:42 +01:00
Johannes Schickel cad9148f85 HOPKINS: Take advantage of Surface::getPixels. 2013-08-03 04:02:51 +02:00
Johannes Schickel 8b763977a3 HOPKINS: Prefer getBasePtr over direct Surface::pixels access. 2013-08-03 02:52:32 +02:00
Sven Hesse 989ea7cb56 JANITORIAL: Remove trailing whitespace 2013-07-14 19:01:47 +02:00
Strangerke 6285509d64 HOPKINS: Fix bug #3612036 - partially broken thumbnail - Courtesy of SylvainTV 2013-05-07 07:49:30 +02:00
Strangerke 4b7f352768 HOPKINS: Fix bug #3611566 2013-04-26 00:41:04 +02:00
Eugene Sandulenko 8b315aeb49 HOPKINS: Fix warning 2013-04-11 14:58:07 +03:00
Strangerke 5ae15d1e10 HOPKINS: Make the use of _mouseCursorId less verbose 2013-04-10 11:57:48 +02:00
Strangerke 55938b3975 HOPKINS: Make engine less verbose by reducing some object names 2013-04-10 10:27:06 +02:00
Strangerke ef12ba27e5 HOPKINS: Janitorial: Remove useless code 2013-04-10 09:02:37 +02:00
Strangerke f7771844f1 HOPKINS: Remove useless object reference in DialogsManager 2013-04-10 09:01:35 +02:00
Strangerke 9f4a35b011 HOPKINS: Move _oldInventoryPosX to DialogsManager, remove a useless variable 2013-04-10 09:00:08 +02:00
Strangerke 9e956d888e HOPKINS: Improve readability in DialogsManager 2013-04-10 00:24:27 +02:00
Paul Gilbert bfe63b71e9 HOPKINS: Renaming some of the remaining graphics methods 2013-04-09 09:17:11 -04:00
Strangerke 89bf72ff5d HOPKINS: JANITORIAL: Remove trailing spaces and tabs 2013-04-05 08:17:26 +02:00
Strangerke e79a51c208 HOPKINS: Remove g_PTRNUL 2013-04-05 07:54:54 +02:00
Strangerke dac4cb9e67 HOPKINS: More renaming in ObjectsManager 2013-04-02 00:20:54 +02:00
Strangerke e848ed7bac HOPKINS: Rename display buffers 2013-03-30 14:20:18 +01:00
Strangerke 8b5fc0e2e5 HOPKINS: More renaming in ObjectsManager 2013-03-30 11:54:07 +01:00
Strangerke b0f0a6cd92 HOPKINS: Move two more variables to ObjectsManager, make them private 2013-03-24 22:12:48 +01:00
Strangerke 4ff6e13e02 HOPKINS: Set private more variables in DialogsManager 2013-03-24 13:55:11 +01:00
Strangerke f782ca1c10 HOPKINS: Move inventory dialog display to DialogsManager, set _inventWin1 as private 2013-03-24 12:31:28 +01:00
Strangerke 73b01f20af HOPKINS: Remove setParent() from TalkManager 2013-03-20 08:10:28 +01:00
Strangerke 848841772f HOPKINS: Remove setParent() from SaveLoadManager and ScriptManager 2013-03-20 08:06:10 +01:00
Strangerke c5c7ced5ee HOPKINS: Remove setParent() from MenuManager and ObjectsManager 2013-03-20 07:56:16 +01:00
Strangerke 56ae004475 HOPKINS: Remove setParent() from LinesManager 2013-03-20 07:47:39 +01:00
Strangerke 6a446ff9d1 HOPKINS: Remove setParent() from GraphicsManager 2013-03-20 07:36:06 +01:00
Strangerke 852e65bd02 HOPKINS: Remove setParent() from Globals 2013-03-20 07:27:42 +01:00
Strangerke d9b596ad18 HOPKINS: Remove setParent() from FontManager 2013-03-20 01:00:12 +01:00
Strangerke f2d4151dd7 HOPKINS: Remove setParent() from FileManager 2013-03-19 21:57:28 +01:00
Strangerke db6d7e256b HOPKINS: Remove setParent() from EventsManager and Debugger 2013-03-19 20:41:39 +01:00
Strangerke fd5f8c7ef3 HOPKINS: Remove setParent() from DialogsManager 2013-03-19 08:26:36 +01:00
Paul Gilbert 4372bd8306 Merge branch 'hopkins_dirtyRects' 
Conflicts:
	engines/hopkins/anim.cpp
	engines/hopkins/computer.cpp
	engines/hopkins/dialogs.cpp
	engines/hopkins/graphics.cpp
	engines/hopkins/hopkins.cpp
 2013-03-17 11:29:00 -04:00
Strangerke 23badc9735 HOPKINS: Some renaming 2013-03-04 07:46:52 +01:00
Strangerke d7ea7ca378 HOPKINS: Rename some more savegame indexes 2013-03-01 07:57:11 +01:00
Strangerke cfcf0e40a5 HOPKINS: Forgotten file in previous commit 2013-02-28 08:23:49 +01:00
Strangerke c74361b0b6 HOPKINS: Get rid of a magic value in save/load dialogs 2013-02-26 23:54:50 +01:00
Strangerke 79062f426e HOPKINS: Some renaming in GraphicsManager 2013-02-26 07:37:09 +01:00
Paul Gilbert 54924de6cb HOPKINS: Home-screen now displaying correctly with dirty rects 2013-02-25 22:00:36 -05:00
Strangerke 577f904055 HOPKINS: More renaming in Globals and ObjectsManager 2013-02-22 10:36:54 +01:00
Strangerke 8457c00457 HOPKINS: More misc renaming 2013-02-20 08:30:16 +01:00
Strangerke f9f6133851 HOPKINS: Misc renaming 2013-02-20 01:23:39 +01:00
Strangerke a208f51db7 HOPKINS: More renaming in SoundManager 2013-02-19 15:08:12 +01:00
Strangerke 5bbdbc0fad HOPKINS: Misc renaming, some sound refactoring 2013-02-19 14:34:43 +01:00