Commit Graph
53 Commits
Author SHA1 Message Date
Le Philousophe 14e3d1f343 CGE: Don't use unsafe sprintf and vsprintf 2022-10-23 22:46:19 +02:00
Le Philousophe 035f425e9c CGE: Don't pass the engine object to EncryptedStream
It doesn't need it and when linked with detection and with UBSan enabled
build fails because CGEEngine isn't linked in
2022-01-03 14:44:03 +02:00
Eugene Sandulenko abea37c9bb ALL: Update ScummVM project license to GPLv3+ 2021-12-26 18:48:43 +01:00
Orgad Shaneh 69f45d9258 CGE: Use nullptr
Using clang-tidy modernize-use-nullptr
2021-11-14 15:51:59 +02:00
SupSuper 054aee03d5 CGE: Make sure to stop playing sounds before freeing resources 2021-04-01 23:25:43 +03:00
Tomasz Długosz eaab877d66 JANITORIAL: fix the name of original author of cge and cge2
The first name is Janusz, not Janus.
The correct name was used in AUTHORS and credits.
In case of doubts, see his personal webpage: https://www.jbw.pl/ - name is in the page footer
2020-04-18 20:59:57 +02:00
Ori Avtalion 3564032330 JANITORIAL: Reduce audio header dependencies 2016-04-14 16:10:21 +03:00
Strangerke 2be4c69939 CGE: Fix some uninitialized variables 2014-03-02 20:44:25 +01:00
Johannes Schickel ed40653105 CGE: Make GPL headers consistent in themselves. 2014-02-18 02:39:33 +01:00
D G Turner ac4087856f ALL: Remove optimization unstable code on checking for null after new.
These issues were identified by the STACK tool.

By default, the C++ new operator will throw an exception on allocation
failure, rather than returning a null pointer.

The result is that testing the returned pointer for null is redundant
and _may_ be removed by the compiler. This is thus optimization
unstable and may result in incorrect behaviour at runtime.

However, we do not use exceptions as they are not supported by all
compilers and may be disabled.

To make this stable without removing the null check, you could qualify
the new operator call with std::nothrow to indicate that this should
return a null, rather than throwing an exception.

However, using (std::nothrow) was not desirable due to the Symbian
toolchain lacking a <new> header.
A global solution to this was also not easy by redefining "new" as "new
(std::nothrow)" due to custom constructors in NDS toolchain and various
common classes.

Also, this would then need explicit checks for OOM adding to all new
usages as per C malloc which is untidy.

For now to remove this optimisation unstable code is best as it is
likely to not be present anyway, and OOM will cause a system library
exception instead, even without exceptions enabled in the application
code.
2014-01-15 02:36:19 +00:00
Strangerke 150011b843 CGE: Fix FX stereo 2012-06-24 23:49:03 +02:00
D G Turner 6523a32334 CGE: Close memory leak in sound Fx caching.. 2012-03-28 01:11:41 +01:00
Strangerke c67e272451 CGE: Music now always loop, like in the original game 2011-09-30 08:28:09 +02:00
Strangerke 4778ff720c CGE: Move some more globals to CGEEngine 2011-09-17 10:54:50 +02:00
Strangerke 938c08ae58 CGE: Get rid of some more global functions and static members 2011-09-16 20:31:39 +02:00
Strangerke c993108207 CGE: Transform some static and globals into class members 2011-09-15 08:00:54 +02:00
Strangerke 82e0b6fc4b CGE: Rewrite fileIO 2011-09-14 00:10:59 +02:00
Strangerke e073fab211 CGE: Fix formatting of operator overloading 2011-09-11 22:24:40 +02:00
Strangerke 918d79f104 CGE: Remove some more uses of VFile. Fix a shadowed variable 2011-09-11 22:07:22 +02:00
Strangerke 4848683e56 CGE: Remove some static variables from fileIO 2011-09-09 18:24:11 +02:00
Strangerke b23bee8571 CGE: Remove XFile, rename some members 2011-09-09 16:51:47 +02:00
Strangerke 4b9d2c2516 CGE: Rename Han structures to Handler
Thanks to Fingolfin for pointing this out (as previous commit)
2011-09-07 23:00:32 +02:00
Strangerke 3e574cfbf8 CGE: Remove wtom() 2011-09-07 01:02:05 +02:00
Strangerke 85d10fe6c7 CGE: Handle properly looping samples 2011-09-06 21:58:41 +02:00
Strangerke e46c613e9a CGE: Remove 'count' static variable from snail
Thanks LordHoto for pointing it out
2011-09-06 19:56:47 +02:00
Strangerke 5bad1a7c7f CGE: Take into account some of LordHoto's comments 2011-09-06 00:43:40 +02:00
Strangerke 7144076030 CGE: Move IO classes to a separated source file 2011-08-27 09:05:32 +02:00
Alyssa Milburn e4a37322a6 CGE: More misc cleanup. 2011-08-20 00:23:45 +02:00
Strangerke 40ea6d788b CGE: Suppress some dead code 2011-08-19 07:25:58 +02:00
Alyssa Milburn a9f002897e CGE: Preserve const in cast. 2011-08-17 10:50:26 +02:00
Strangerke 58229750cc CGE: silent valgrind warnings 2011-08-13 09:16:15 +02:00
Paul Gilbert 91fdecbf68 CGE: Properly implemented MIDI music playback 2011-08-12 23:10:30 +10:00
Paul Gilbert b76c0af2f4 CGE: Work on implementing MIDI music playback.
Music playback is now sort of working, but it seems like only a beat track of the MIDI is getting played
2011-08-12 21:33:45 +10:00
Paul Gilbert f1f1d8bde0 CGE: Implemented sound effects 2011-08-12 19:48:51 +10:00
Strangerke 316b73ee00 CGE: Remove Startup class, set _fx and _sound as dynamic 2011-07-29 10:02:32 +02:00
Strangerke 2e5a041046 CGE: Remove EMM and EMS classes 2011-07-25 17:50:58 +02:00
Strangerke fae1d7efd8 CGE: This ends the first renaming pass. Also move some functions to CGEEngine 2011-07-04 08:15:56 +02:00
Strangerke 4116189395 CGE: Some more renaming (WIP) 2011-07-03 11:28:22 +02:00
Strangerke bdc213846e CGE: Some more renaming (WIP) 2011-07-02 18:20:41 +02:00
Strangerke 8e531d0da3 CGE: Some more renaming (WIP) 2011-07-02 01:02:14 +02:00
Strangerke 0000a3139a CGE: Some more renaming (wip) 2011-07-01 08:37:40 +02:00
Strangerke f59c910b8f CGE: Some more renaming (wip) 2011-06-30 08:30:23 +02:00
Strangerke a06a75b9a4 CGE: Implement ForceExt and RCrypt. Little style cleanup. 2011-06-26 12:07:42 +02:00
Strangerke 64f2ccca9b CGE: Cleanup: remove trailing spaces 2011-06-13 13:07:45 +02:00
Strangerke ffc2aa4e4f CGE: Format code 2011-06-13 11:57:24 +02:00
Strangerke 92076d4641 CGE: Remove DROP() macro 2011-06-11 23:27:27 +02:00
Strangerke 11264a60a7 CGE: Stubbing and cleanup made by SylvainTV 2011-06-11 22:35:21 +02:00
Strangerke 29065d302a CGE: Add namespaces 2011-06-10 22:57:09 +02:00
Strangerke 7d88b9e4cd CGE: Suppress typedef for byte, word and dword. 2011-06-10 19:02:13 +02:00
Strangerke 68f7ff1115 CGE: Replace Boolean, TRUE and FALSE by bool, true, false 2011-06-10 13:06:03 +02:00