Commit Graph
4144 Commits
Author SHA1 Message Date
Martin Gerhardy 6772dabd9a COMMON: replaced NULL with nullptr in wrapCompressedReadStream 2021-06-07 01:36:30 +03:00
Martin Gerhardy b259e168a4 COMMON: fixed invalid read in zlib read stream
==1313424== Conditional jump or move depends on uninitialised value(s)
==1313424==    at 0x682225: Common::wrapCompressedReadStream(Common::SeekableReadStream*, unsigned int) (zlib.cpp:498)
==1313424==    by 0x46CDB9: DefaultSaveFileManager::openForLoading(Common::String const&) (default-saves.cpp:134)
==1313424==    by 0x68334D: Common::PlaybackFile::openRead(Common::String const&) (recorderfile.cpp:74)
==1313424==    by 0x444558: GUI::RecorderDialog::updateList() (recorderdialog.cpp:206)
==1313424==    by 0x4446BD: GUI::RecorderDialog::runModal(Common::String&) (recorderdialog.cpp:218)
==1313424==    by 0x3DF0E5: GUI::LauncherDialog::recordGame(int) (launcher.cpp:461)
==1313424==    by 0x3E0397: GUI::LauncherDialog::handleCommand(GUI::CommandSender*, unsigned int, unsigned int) (launcher.cpp:671)
==1313424==    by 0x400BF8: GUI::CommandSender::sendCommand(unsigned int, unsigned int) (object.h:55)
==1313424==    by 0x42DAB8: GUI::DropdownButtonWidget::handleMouseUp(int, int, int, int) (widget.cpp:497)
==1313424==    by 0x3D3A37: GUI::Dialog::handleMouseUp(int, int, int, int) (dialog.cpp:228)
==1313424==    by 0x3DB72C: GUI::GuiManager::processEvent(Common::Event const&, GUI::Dialog*) (gui-manager.cpp:668)
==1313424==    by 0x3DA9EA: GUI::GuiManager::runLoop() (gui-manager.cpp:429)

Happens when you start with the event recorder compiled into scummvm and open the dialog to start
a new record.
2021-06-07 01:36:30 +03:00
SupSuper fa5149e3ac COMMON: Fix old GCC compilation 2021-06-03 03:50:51 +01:00
SupSuper e3d082df65 MSVC: Add compiler printf validation 2021-06-02 08:35:31 +03:00
lb_ii b9f4e1a6bd ACHIEVEMENTS: Mark const methods as const 2021-06-02 01:21:37 +03:00
lb_ii 9c699358ea ACHIEVEMENTS: Make getStatRaw() const 2021-06-01 02:20:53 +03:00
lb_ii e11ef2f21e ACHIEVEMENTS: Add more traces 2021-06-01 02:20:53 +03:00
lb_ii 2cfbc9bd43 ACHIEVEMENTS: Add API for getting raw string value for stats 2021-06-01 02:20:53 +03:00
lb_ii ea18561650 ACHIEVEMENTS: Extend AchievementsInfo, set stats initial value 2021-06-01 02:20:53 +03:00
SupSuper 721b7376bb COMMON: Clean up ReadStream::readString 2021-05-31 23:04:06 +01:00
SupSuper 48b9f54bfc COMMON: Add support for fixed-size strings in ReadStream::readString 2021-05-31 06:40:05 +01:00
SupSuper 5daeab2e76 COMMON: Add floating-point functions to ReadStreamEndian 2021-05-31 06:40:03 +01:00
lb_ii 6513bab7af ACHIEVEMENTS: Add an API to store platform-specific special strings like ClientSecret 2021-05-30 20:15:55 +03:00
Filippos Karapetis 6c47cb0ec5 COMMON: Add serializers for float and double types 2021-05-29 21:23:20 +01:00
SupSuper 8bc861cb1a VIDEO: Added dirty rects to SmackerDecoder
This emulates the "slow" render mode of the Smacker lib,
which returns the blocks changed each frame instead of full frames.
Nightlong relies on this to correctly refresh its screen buffer.
2021-05-29 21:22:58 +01:00
lb_ii 65a8943624 ACHIEVEMENTS: add average rate statistics API 2021-05-29 22:40:05 +03:00
lb_ii 3fe4d8fc0f ACHIEVEMENTS: Remove old API methods 2021-05-28 21:07:08 +03:00
lb_ii a4aa95b2b3 ACHIEVEMENTS: Minor refactoring 2021-05-28 21:07:08 +03:00
lb_ii 6ed025dd89 ACHIEVEMENTS: Add API methods that are easy to use 2021-05-28 21:07:08 +03:00
ysj1173886760 361c723e8a ENGINE: introduce kDebugGlobalDetection which is used for print debug messages of advancedDetector 2021-05-22 01:34:57 +02:00
ysj1173886760 6d1aece1a8 COMMON: remove kDebugGlobalTest flag 2021-05-22 01:34:57 +02:00
ysj1173886760 7a0d9546ce GUI: move kDebugLevelEventRec flag to global flag 2021-05-22 01:34:57 +02:00
ysj1173886760 44e2285003 BASE: add duplicate debug channel check for addDebugChannel 2021-05-22 01:34:57 +02:00
ysj1173886760 d2ea7cea88 COMMON: fix the bug when using default implementation of getDebugChannel 2021-05-22 01:34:57 +02:00
ysj1173886760 96aa98ed14 ENGINE: change the name of the delimiter of DebugChannelDef 2021-05-22 01:34:57 +02:00
ysj1173886760 9ca5ce1390 COMMON: fix the include file of debug.h and debug-channels.h 2021-05-22 01:34:57 +02:00
ysj1173886760 a64a097ca3 COMMON: change passing pointer instead of passing the array when passing the debug channels 2021-05-22 01:34:57 +02:00
ysj1173886760 9609406205 COMMON: introduce debugFlagsClear and debugFlagsRegister to debug manager 2021-05-22 01:34:57 +02:00
ysj1173886760 f07ceca9cb BASE: add global debug flag 2021-05-22 01:34:57 +02:00
Kaloyan Chehlarski cba24194e2 COMMON: Fix InstallShield cabinet version detection
The file version of InstallShield cabinets is now detected correctly.
2021-05-15 23:03:19 +03:00
Kaloyan Chehlarski 3f5ea7bbb7 COMMON: Add another file version to InstallShield cabinet code
Added a previously unknown version id to the InstallShield code.
2021-05-15 23:03:19 +03:00
a8103e2eb5 COMMON: Add support for multi-file InstallShield cabinets
Added support for InstallShield v6 cabinets, which can be made up of
multiple files. The interface for creating an Archive instance now takes
the base filename (e.g. the "data" in "data1.cab") for all cabinets,
including single-file ones.

Co-Authored-By: clone2727 <236052+clone2727@users.noreply.github.com>
Co-Authored-By: Walter van Niftrik <615114+waltervn@users.noreply.github.com>
2021-05-15 23:03:19 +03:00
Orgad Shaneh a05e54f00c JANITORIAL: Remove trailing whitespaces 2021-05-04 11:46:30 +03:00
Martin Gerhardy 9d82fa51df COMMON: removed USE_TTS check from engines
OSystem now just returns a nullptr if there is no text to speech manager instance
(because none is compiled into the binary, or the system doesn't provide support
for it). This removed the need for the engine authors to add scummvm osystem compile
time options checks into their engine code
2021-05-03 14:13:41 +03:00
Cameron Cawley d67b16a55d COMMON: Improve debugging of forbidden symbol issues 2021-04-27 04:05:11 +01:00
Eugene Sandulenko c1e18cbb90 COMMON: Added more debug output to installshield 2021-04-26 14:50:20 +02:00
trembyle 2dbe4e9067 COMMON: Fall back to engine icon in taskbar
When an icon for game ID is not found, use the engine icon instead.
This provides a fallback so that every game doesn't need an icon.
2021-04-24 23:54:17 +01:00
Thierry Crozat 982ccb12eb COMMON: Add GUIO_NOLANG GUI option to hide the lang selector 2021-04-19 23:10:12 +01:00
Eugene Sandulenko 0cb63ae556 COMMON: Fix ConfMan.getBool() to correctly process missing values 2021-04-19 23:09:00 +02:00
Orgad Shaneh b49e6eb96f JANITORIAL: Fix some excess tabs 2021-04-15 23:18:08 +03:00
Eugene Sandulenko 5e7fe2dc57 JANITORIAL: Replace spaces in indentation with tabs 2021-04-15 21:20:36 +02:00
Eugene Sandulenko c06d47e397 COMMON: Added kFeatureHiDPI and return it from the backend 2021-04-11 21:21:44 +02:00
Le Philousophe 5cdb300534 COMMON: Fix CJK encode/decode and make valgrind quiet
CJK offsets were wrong compared to encodings.dat file and buffers were
read past their end.
Rewrote indexing to make it match the Python script and optimize
slightly
2021-04-10 23:36:55 +02:00
Thierry Crozat b5804e1257 COMMON: Do not return an error for unknown hashmap key in release builds
We have a lot of legacy code that was written with the old behaviour
where it returned the default value in such a case. Until we are
confident all this code has been updated, we continue to use the
old behaviour in release builds to avoid creating instabilities.

This still error our in non-release builds, which will help detect
the code that still needs to be updated.
2021-04-03 02:09:53 +01:00
Thierry Crozat 5757a406d9 GUI: Display correct ini path when using custom config file
This should avoid confusion for users when a custom config
file is used (for example for GOG games bundled with ScummVM).
2021-04-01 20:17:43 +01:00
Thierry Crozat 7988c1a23c COMMON: Fix compilation of devtools 2021-03-31 23:28:11 +01:00
Thierry Crozat 93e8e2a8c5 COMMON: Fix regression on String thread safety
The string memory pool mutex lock/unlock were lost during the
merge of String and U32String. This caused the cloud feature
to randomly crash for example when synchronizing savegames or
downloading game data.
2021-03-31 22:50:11 +01:00
Orgad Shaneh 1f6f82361f COMMON: Use __gnu_printf__ instead of __printf__ for gcc on MinGW
With __printf__, MinGW prefers the portable old ms-style printf, and
warns if formats like %lld and %hhd are used.

In practice, if __USE_MINGW_ANSI_STDIO is not defined, it defaults to 1
on C++11, and these formats are supported. Using __gnu_printf__
suppresses bad format warnings.
2021-03-31 02:09:45 +03:00
Orgad Shaneh 3dac89a267 BACKENDS: Sprinkle some overrides 2021-03-31 02:04:47 +03:00
Eugene Sandulenko 5dfb0c592c COMMON: Remove duplicate include 2021-03-22 00:07:45 +01:00