This fixes an OpenGL renderer issue for builds with MSYS2/Mingw64 or MSYS2/Mingw32
The issue pertains to MSYS2 adding a default manifest file (default-manifest.o) to the executable
The bug is for PC systems with GPU drivers that were not properly supported for Windows 10
systems, like Intel HD Graphics series 1st and 2nd generations. In those systems, launching a
game in ScummVM (built with MSYS2/Mingw) with the OpenGL renderer would cause the game
screen to be a white blank image, and various warnings would be output to the console, eg.
"WARNING: GL ERROR: GL_INVALID_ENUM on glTexSubImage2D(0x0DE1, 0, 0, area.top, src.w, area.height(), _glFormat, _glType, src.gere.cpp:167)!"
This was due to MSYS2/Mingw builds trying to load the (poorly supported) GPU driver while advertising support for Windows 10 in their
embedded default Manifest file. Hence, the GPU driver DLL (eg ig4icd64.dll) would be unloaded, causing the bug.
More information is available in the following links:
https://github.com/pal1000/save-legacy-intel-graphicshttps://github.com/LWJGL/lwjgl/issues/119https://github.com/msys2/MSYS2-packages/issues/454https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69880
Credits to sluicebox for the VS GenerateManifest flag
This also disables cloud support
Also, several corrections and additions in how_to_build instructions
Tested in a clean installation of lubuntu 16.04.6 LTS
This fixes the "%s can not use this item" string. AFAIK this message never appears. It would require to place an item into a character's hand which he/she can't use and right-click use it. However, when you place such an unusable item in a character's hand the slot will be greyed out/disabled immediately and can no longer be clicked.
Cameron Cawley
Thanasis Antoniou
sluicebox
SupSuper
Alexander Tkachev
Jaromir Wysoglad
Le Philousophe
Paul Gilbert
Lothar Serra Mari
Hubert Maier
Thierry Crozat
Jennifer McMurray
rsn8887
Cpasjuste
Stefan
Bastien Bouclet
athrxx
Matan Bareket