e2f68e2403
COMMON: Fix seek return values, memory stream use in create_titanic
2019-05-12 11:44:15 +03:00
955e18c648
COMMON: Use nullptr instead of NULL or 0 where appropriate
2018-05-10 08:35:46 +02:00
3747d852ee
JANITORIAL: Fix whitespace
2018-04-15 16:31:31 +02:00
0b95b734b8
COMMON: Add ReadStream::readPascalString()
2017-01-14 12:45:58 +01:00
3071bb40d8
COMMON: Added debug method for printing out stream contents
2016-10-26 19:00:13 +02:00
7a89caac84
COMMON: Add WriteStream::pos()
...
It returns int32, because some complex streams are derived from both
WriteStream and ReadStream, and in ReadStream pos() returns int32,
because -1 means an error.
I had to change MemoryStream's uint32 to int32, which is probably not so
good.
2016-08-04 14:36:21 +06:00
854e22b38b
COMMON: Make GPL headers consistent in themselves.
2014-02-18 02:39:33 +01:00
2f73d64e80
Merge pull request #305 from giucam/bufferedseekable
...
Make BufferedSeekableReadStream use the buffer with SEEK_SET and SEEK_END
2013-01-28 08:43:52 -08:00
5bfd2f6756
COMMON: Fix successive seeks in BufferedSeekableReadStream.
...
This fixes the failing test case added in
da8eeb9dbe
2013-01-28 17:34:37 +01:00
354aa0f5f3
JANITORIAL: Use "End of anonymous namespace" as comment for anonymous namespaces.
2013-01-26 19:38:02 +01:00
b4d0a8ba66
JANITORIAL: Enforce "} // End of namespace" with a single space after }.
2013-01-26 19:38:02 +01:00
edfcd768ba
COMMON: Make BufferedSeekableReadStream use the buffer with SEEK_SET and SEEK_END
2013-01-26 19:12:26 +01:00
48efab4e5a
COMMON: Rename SafeSubReadStream to SafeSeekableSubReadStream.
...
It actually inherits from SeekableSubReadStream, so it should be named
accordingly.
2012-03-11 00:51:20 +01:00
a5a8833c05
COMMON: Add DisposablePtr<T>, which replaces many repeated implementations of a dispose flag.
2011-08-07 15:19:08 +02:00
69b1485a22
GIT: Clean up: Suppress SVN tags, now useless
2011-05-12 01:16:22 +02:00
88d562a361
COMMON: Add a class SafeSubReadStream
...
SafeSubReadStream is basically a SeekableSubReadStream that
re-seek()s the parent stream before each read(). That way, more than
one SafeSubReadStream of the same parent stream can be used safely
at the same time, at the cost of increasing IO.
2011-05-06 16:47:48 +02:00
9414d7a6e2
JANITORIAL: Reduce header dependencies in shared code
...
Some backends may break as I only compiled SDL
2011-04-28 15:08:58 +03:00
c6112f7383
COMMON: Do not call ReadStream::eos in SubReadStream::read.
...
Instead I moved the call to ReadStream::eos into SubReadStream::eos.
fuzzie pointed out that in certain cases this resulted in a lot of eos calls
before. Those were rather needlessly, since checking the eos bit of the
decorated stream in read does not give any advantage over checking it when
the client code really wants to test the eos flag.
2011-04-19 18:08:47 +02:00
ae919f3ebd
COMMON: Remove XOR decoding capability from MemoryReadStream
...
svn-id: r54436
2010-11-23 22:25:53 +00:00
2180b2d6b5
COMMON: Split common/stream.h into several headers
...
svn-id: r54385
2010-11-19 17:03:07 +00:00
9fb1e2b17e
COMMON: Change wrapBufferedWriteStream() to always disposes wrapped stream
...
This is the only we need right now, and it saves a few bytes per
instance. The template approach I used before has the drawback that it
increases the binary size, which negates the benefit. Thanks to LordHoto
for pointing this out.
svn-id: r54344
2010-11-18 20:27:15 +00:00
a9dcb11c54
COMMON: Turn BufferedWriteStream into a template class, with disposeParentStream as param
...
svn-id: r54336
2010-11-18 17:56:21 +00:00
152e52d015
COMMON: Make implementation of Buffered*Stream classes internal
...
svn-id: r54326
2010-11-18 17:02:51 +00:00
4707b610fc
COMMON: Fix incorrect use of assert() macro
...
The assert() macro may be compiled to be empty. In that case, its
arguments are *NOT* evaluated. Hence, things like
assert(doSomething())
must not be used whenever doSomething() has important side effects.
Also document BufferedWriteStream::flushBuffer() and explain why it
exists parallel to BufferedWriteStream::flush().
svn-id: r54322
2010-11-18 16:08:56 +00:00
8388e0dfea
JANITORAL: Clean trailing whitespaces.
...
svn-id: r53160
2010-10-12 02:18:11 +00:00
94b41f5d2e
COMMON: remove virtual functions from BufferedStreams
...
As Max pointed out to me, they don't work as expected when called from constructors/destructors.
svn-id: r52724
2010-09-14 14:57:30 +00:00
05c2cc4d1d
COMMON: Fix eos handling in BufferedReadStream
...
This makes it pass the test added in r52382.
svn-id: r52389
2010-08-25 14:43:42 +00:00
4368d3c574
COMMON: fixed EOS handling in BufferedReadStream and BufferedSeekableReadStream
...
EOS problem was causing Discworld to crash and zip files not to load on the PSP.
svn-id: r52377
2010-08-25 09:14:41 +00:00
efdbb076a2
COMMON: implemented BufferedWriteStream and fixed bug in BufferedReadStream
...
I need the write buffering for the new version of the PSP streams and thought the simplest way to implement it would be along the lines of BufferedReadStream. Sadly, I found a nasty little bug in BRS but that's taken care of.
Also, I adapted these streams for target-specific memory allocation by using virtual functions for allocation/deallocation.
svn-id: r52325
2010-08-24 11:18:48 +00:00
651e2760a3
Fix spelling, cleanup
...
svn-id: r49843
2010-06-15 12:33:20 +00:00
024f492137
Added seek() method to MemoryWriteStreamDynamic.
...
If it deserves a separate class, shout.
svn-id: r49750
2010-06-15 10:34:14 +00:00
d083e02215
Rename Common::Stream::readLine_NEW to readLine
...
svn-id: r46779
2009-12-30 23:00:55 +00:00
2bbf708dea
Introduced new type Common::DisposeAfterUse::Flag
...
svn-id: r45233
2009-10-18 19:41:59 +00:00
8ba75fc522
Fix code formatting (esp. 'if(' -> 'if (' etc., but also indention and other things)
...
svn-id: r44495
2009-09-30 16:16:53 +00:00
6a8a9740a1
Fix valgrind warning
...
svn-id: r40309
2009-05-04 16:35:47 +00:00
05b4370c21
Fix for bug #2664460 : Various SeekableReadStream::seek() implementations (as well as our unit tests, ouch) handled SEEK_END incorrectly (using -offset instead of offset), contrary to what the docs said and what fseek does. Hopefully I found and fixed all affected parts, but still watch out for regressions
...
svn-id: r39135
2009-03-05 20:37:53 +00:00
b1999a2a16
Fixed indentation and removed whitespaces at the end of line
...
svn-id: r35481
2008-12-22 11:22:15 +00:00
abae99d645
Get rid of readLine_OLD for good
...
svn-id: r35229
2008-12-03 22:55:30 +00:00
c8eeae8d4d
Big patch changing semantics of ReadStream::eos():
...
eos() now only returns true _after_ trying to read past the end of the stream.
This has a large potential for regressions. Please test!
svn-id: r34549
2008-09-14 22:28:53 +00:00
655ce26b3f
Big patch changing the signature of various Stream methods (some ports may need to be slightly tweaked to fix overloading errors/warnings)
...
svn-id: r34514
2008-09-13 16:51:46 +00:00
6cb09e311a
Added some unit tests for Stream::readLine_NEW, and clarified that readLine_NEW is essentially fgets in disguise
...
svn-id: r34384
2008-09-06 16:46:28 +00:00
c7a0b52c17
Fixed Stream::readLine implementation to match its doxygen comment
...
svn-id: r34316
2008-09-03 18:07:31 +00:00
57e724bfc3
Renamed SeekableReadStream::readLine to SeekableReadStream::readLine_OLD; added a new alternate SeekableReadStream::readLine() instead
...
svn-id: r34315
2008-09-03 17:53:25 +00:00
1e2988b7f7
Changed BufferedReadStream to not permanently decrease its buffer size at the end of a stream (this would fail when using BufferedSeekableReadStream and then seeking back from the end); this also fixes a bug which let you seek back beyond the start of a stream (not that we currently support that in other streams)
...
svn-id: r33436
2008-07-30 07:39:41 +00:00
aaa4d104f7
Added two new classes, BufferedReadStream & BufferedSeekableReadStream, as proposed on scummvm-devel
...
svn-id: r33419
2008-07-29 17:42:19 +00:00
e09eb75ef7
Silence a warning which complains about using an uninitialized variable.
...
svn-id: r33169
2008-07-21 11:33:30 +00:00
f7ec115f08
New SeekableReadStream::readLine_NEW() method, closely modelled after fgets, w/o the line length limitations of the old eekableReadStream::readLine() (which it will replace, after the feature freeze has been lifted)
...
svn-id: r33139
2008-07-20 16:47:52 +00:00
258901bab9
Merged common/stdafx.h into common/scummsys.h. All referencing files have been updated.
...
svn-id: r28966
2007-09-19 08:40:12 +00:00
218e132e37
Updated legal headers in source files, based on what Pidgin (the IM client formerly knowns as Gaim) does; added new (incomplete) COPYRIGHT file; updated copyright dates in a few spots
...
svn-id: r27024
2007-05-30 21:56:52 +00:00
42f11e9e49
Added new ReadStream::readStream method which can be used to read a portion of an arbitrary ReadStream into a memory buffer wrapped by a MemoryReadStream
...
svn-id: r25754
2007-02-20 21:41:01 +00:00
Paul Gilbert
Bastien Bouclet
Adrian Frühwirth
Eugene Sandulenko
Alexander Tkachev
Johannes Schickel
Johannes Schickel
Giulio Camuffo
Christoph Mallon
strangerke
Sven Hesse
Ori Avtalion
Max Horn
Jordi Vilalta Prat
Yotam Barnoy
Willem Jan Palenstijn
Kari Salminen
Nicola Mettifogo