The exposes the --copy-protection command line option to the engine
settings dialog. This affects the following games:
* Maniac Mansion v1 (DOS) and v2, but not NES or the demos
* Zak McKracken v1 and v2
* Loom EGA (DOS)
* Monkey Island 1, VGA floppy and Macintosh
* Monkey Island 2, but not demos, FM Towns, or the Ultimate Talkie
* Fate of Atlantis, Amiga and other floppy versions
I don't have all of these versions myself, so I can't verify that it
works. And in some cases, the checkbox will appear for games that don't
have the copy protection in the scripts, e.g. the Mac CD Game Pack
version of Fate of Atlantis. (Anyone want to re-insert that script like
we do for that release of Monkey Island 2?)
The layout is not good and needs more work. I haven't
yet understood how the theme layout code has to be used.
I commit this nonetheless, since it is the only way to access
the music quality settings for MI1.
There was discussion a while back about how people may want to enable
some of the SCUMM enhancements, but not all since some of them affect
gameplay beyond simple bugfixing. This is an initial attempt at the GUI
part of it. The details are very much still up for discussion.
We currently have two widget types for sliders: "Slider" and
"WideSlider". This eliminates the latter, making all sliders use the
available space. This arguably makes them look better, and should make
them easier to manipulate on touch devices like phones.
Did I say "all"? Not quite. In the high resolution layout, the volume
sliders share space with the "Mute all" checkbox. The layout engine does
not cope well with two side-by-side layouts of indeterminate width,
apparently, so there we set a width, cross our fingers and hope that the
checkbox will still have enough space in all translations.
Before the original SCUMM GUI and menus were implemented in ScummVM,
opening the F5 menu when playing DOTT would give localized strings to
(almost) any player.
Now that we can display the original F5 menu, a language accessibility
regression shows up, in that the original CD release of DOTT just
harcoded some of the menu strings in English (such as "Display Text",
"SFX", and so on).
This was fixed in Sam & Max CD (which uses the same menu but with
different colors) and all later games, so it appears to be fair to
bring the official Sam & Max menu translations to DOTT, as an
enhancement.
The seven-year-old me playing DOTT would have been happy to understand
what those settings meant, back then :)
Trac#13947.
Add the "use original gui" checkbox to the custom Loom EGA/VGA
and Monkey 1 CD version game options window.
Also slightly change to layout for consistency with
the other games.
This replaces every single strcpy call in the engine with
Common::strlcpy.
Some of these might cases seem a bit pointless, but it is
supposed to discourage future use of strcpy. If people don't
see a single occasion of it they might think twice before they
use it...
Eugene Sandulenko
AndywinXp
Hubert Maier
Torbjörn Andersson
Cameron Cawley
Little Cat
athrxx
Donovan Watteau
Walter Agazzi