Commit Graph
53 Commits
Author SHA1 Message Date
Bastien Bouclet 9a4c0ae281 ENGINES: Normalize the getName() result of metaengines
Also-By: Matthew Hoops <clone2727@gmail.com>
2018-12-10 06:47:27 +01:00
Bastien Bouclet 1dcb8076db ENGINES: Remove usage of C++11 extended initializer lists 2018-05-10 09:26:26 +02:00
Bastien Bouclet 90b78c5446 ENGINES: Merge GameDescriptor and DetectedGame 2018-05-10 09:04:23 +02:00
Bastien Bouclet 1de5aca585 ENGINES: Set the GameDescriptor decription in the constructor 2018-05-10 09:04:23 +02:00
Bastien Bouclet 643c24db75 ENGINES: Change MetaEngine::listSupportedGames to return plain game descriptors 2018-05-10 09:04:23 +02:00
Bastien Bouclet 8fb149e3c7 ENGINES: Change MetaEngine::findGame to return a plain game descriptor 2018-05-10 09:04:23 +02:00
Bastien Bouclet cf1ebf2951 ENGINES: Add unknown game variants to the game detector results 2018-05-10 09:04:23 +02:00
Lothar Serra Mari 451cf2304f ENGINES: Show the unknown Game dialog only when the detector is launched by the Add Game feature 2018-04-29 21:47:10 +01:00
Adrian Frühwirth 00e59a3122 ALL: Load savegame thumbnail only when necessary
This commit introduces the following changes:

1. Graphics::loadThumbnail()

   Now returns a boolean and takes a new argument skipThumbnail which
   defaults to false. In case of true, loadThumbnail() reads past the
   thumbnail data in the input stream instead of actually loading the
   thumbnail. This simplifies savegame handling where, up until now,
   many engines always read the whole savegame metadata (including
   the thumbnail) and then threw away the thumbnail when not needed
   (which is in almost all cases, the most common exception being
   MetaEngine::querySaveMetaInfos() which is responsible for loading
   savegame metadata for displaying it in the GUI launcher.

2. readSavegameHeader()

   Engines which already implement such a method (name varies) now take
   a new argument skipThumbnail (default: true) which is passed
   through to loadThumbnail(). This means that the default case for
   readSavegameHeader() is now _not_ loading the thumbnail from a
   savegame and just reading past it. In those cases, e.g.
   querySaveMetaInfos(), where we actually are interested in loading
   the thumbnail readSavegameHeader() needs to explicitely be called
   with skipThumbnail == false.

   Engines whose readSavegameHeader() (name varies) already takes an
   argument loadThumbnail have been adapted to have a similar
   prototype and semantics.
   I.e. readSaveHeader(in, loadThumbnail, header) now is
   readSaveHeader(in, header, skipThumbnail).

3. Error handling

   Engines which previously did not check the return value of
   readSavegameHeader() (name varies) now do so ensuring that possibly
   broken savegames (be it a broken thumbnail or something else) don't
   make it into the GUI launcher list in the first place.
2018-04-07 09:26:20 +02:00
Colin Snover 925c9416db SWORD1: Fix use of deallocated stack memory
FSNode::getName returns a String object, not a reference, so the
pointer from c_str is valid only until the end of the statement.
2017-11-10 23:22:26 -06:00
Thierry Crozat 34969d50b8 SWORD1: Specify list of available languages in detection code
This way only those languages are listed in the language selector
for the game settings.
2017-07-12 21:44:10 +01:00
Johannes Schickel e515fc18db ENGINES: Make variable names of PlainGameDescriptor conform to our guidelines.
gameid -> gameId
2016-03-08 19:01:42 +01:00
Johannes Schickel d740bc4f2e SWORD1: Let listSaves return list sorted on slot numbers. 2016-02-25 21:39:45 +01:00
Johannes Schickel fda7ce1e14 SWORD1: Only request actual save slots in listSaves. 2016-01-26 16:35:30 +01:00
Johannes Schickel f4724e7a46 SWORD1: Make GPL headers consistent in themselves. 2014-02-18 02:39:38 +01:00
Filippos Karapetis f915daad6d SWORD1: Fix bug #3049346 - "BS1: Detects games in wrong places"
We no longer detect the sword1 files inside the "clusters" folder
2012-11-07 21:56:26 +02:00
Johannes Schickel 89b8f6bb56 SWORD1: Slight cleanup in querySaveMetaInfos. 2012-07-03 18:39:50 +02:00
Max Horn 215b41b244 COMMON: Move RenderMode and GUIOptions functionality into separate files 2012-02-26 15:19:31 +01:00
Strangerke 7350ddf640 SWORD1: Re-add GUIO_NOASPECT to Sword1, as it was erroneously removed.
Sorry for the noise...
2011-10-24 12:55:30 +02:00
Strangerke 9b112fb56a SWORD1: After discussion with clone2727 and eriktorbjorn, remove GUIO_NOASPECT from Sword1 2011-10-24 06:57:41 +02:00
Strangerke 829df06599 SWORD1: Add GUIO_NOASPECT to Sword1 2011-10-24 04:31:39 +02:00
Eugene Sandulenko 32972a5ffb AD: Switched rest of the engines to new GUIO 2011-10-23 17:53:13 +01:00
Johannes Schickel 3a15c10241 SWORD1: Made some static data const. 2011-09-08 00:05:09 +02:00
Johannes Schickel 928cb5ab11 SWORD1: Made code conform a bit better to our formatting guidelines.
Most is automatically converted via astyle + some manual fixes, hopefully I
did not miss anything astyle messed up...
2011-09-07 23:54:34 +02:00
Christoph Mallon e35b4f20c1 GRAPHICS: Simplify the interface of Graphics::loadThumbnail().
Now it returns the Surface, so the caller does not need to create one and pass it.
2011-08-07 15:19:09 +02:00
Max Horn 6412d09126 DETECTOR: Remove PlainGameDescriptorGUIOpts 2011-06-14 18:17:02 +02:00
Max Horn 477d6233c3 ENGINES: Change 2nd param of Engine::saveGameState to Common::String 2011-06-02 18:31:59 +02:00
D G Turner 24ac81ead8 SWORD1: Replace snprintf() usage with Common::String::format()
Safer and less portability issues.
2011-06-02 04:21:48 +01:00
Thierry Crozat d2a55b42c9 ENGINES: Further unify engine names 2011-05-22 12:47:35 +01:00
strangerke 69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
Ori Avtalion 9414d7a6e2 JANITORIAL: Reduce header dependencies in shared code
Some backends may break as I only compiled SDL
2011-04-28 15:08:58 +03:00
Max Horn a0df86955f ALL: Push down deps on stream.h from .h to .cpp files
svn-id: r54358
2010-11-19 01:37:04 +00:00
Johannes Schickel a5c28de26b SWORD1: Switch to the new play time counting of the Engine class.
svn-id: r53924
2010-10-29 16:53:46 +00:00
Max Horn cac0ac66e2 COMMON: Get rid of Common::StringList
svn-id: r48287
2010-03-18 15:54:40 +00:00
Johannes Schickel aed02365ec Strip trailing spaces/tabs.
svn-id: r47541
2010-01-25 01:39:44 +00:00
Max Horn df81b68967 Change BS 1 & 2 to I & II (see discussion on -devel)
svn-id: r46951
2010-01-03 21:20:05 +00:00
Fabio Battaglia 14c85028b1 sword1: add Broken Sword PSX demo support
svn-id: r41369
2009-06-08 12:37:24 +00:00
Eugene Sandulenko eb909702af Add GUI options support to Sky, Queen and Sword1&2 engines (which do not use AD)
svn-id: r41274
2009-06-06 17:57:39 +00:00
Max Horn fb79b18571 Changed SaveFileManager methods to take Common::String params (instead of char pointers)
svn-id: r41000
2009-05-29 14:38:22 +00:00
Johannes Schickel b3c6751b9b Strip trailing whitespaces in the whole code base.
svn-id: r40867
2009-05-24 15:17:42 +00:00
Filippos Karapetis 3b507db4f0 Silenced some warnings about potentially uninitialized variables
svn-id: r39535
2009-03-19 20:38:29 +00:00
Jordi Vilalta Prat 047f116515 Renamed MetaEngine::getCopyright() to getOriginalCopyright() to better match the meaning of the returned string, as discussed some time ago in scummvm-devel
svn-id: r39132
2009-03-05 12:04:58 +00:00
Fabio Battaglia cdc9f46bd9 sword1: removed custom checks for thumbnails, using graphics/thumbnail.h functions instead
svn-id: r39130
2009-03-04 12:44:55 +00:00
Fabio Battaglia f6028bc822 sword1: disable saving/loading through GMM when in game menu
svn-id: r39122
2009-03-04 10:39:12 +00:00
Fabio Battaglia 7fc8bb81a7 Enabled and hopefully fixed GMM saving/loading for sword1
svn-id: r39095
2009-03-03 20:05:00 +00:00
Fabio Battaglia 0077889eeb Add playtime feature support to sword1
svn-id: r39083
2009-03-02 22:37:09 +00:00
Eugene Sandulenko 5aa50ec889 Patch #2638336: Broken Sword PSX Support
svn-id: r38956
2009-02-28 10:46:33 +00:00
Eugene Sandulenko 696897b058 Whoa! Removing trailing spaces.
svn-id: r35648
2009-01-01 15:06:43 +00:00
Max Horn df20d264fd Pushing down some header deps (on common/system.h, mostly)
svn-id: r35542
2008-12-25 20:40:00 +00:00
Johannes Schickel d99ab163cc Fixed meta engine related save functions (some where relying on "target.???" instead of "sword1.???").
svn-id: r35113
2008-11-18 17:03:55 +00:00