ScummVM/scummvm
1
0
Fork 0
mirror of https://github.com/scummvm/scummvm.git synced 2026-06-20 05:45:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
89,422 Commits 45 Branches 139 Tags
c593159dd84aef234cda170fbe5dedec0a8f9d63
Commit Graph
52 Commits
Author SHA1 Message Date
Adrian Frühwirth 00e59a3122 ALL: Load savegame thumbnail only when necessary 
This commit introduces the following changes:

1. Graphics::loadThumbnail()

   Now returns a boolean and takes a new argument skipThumbnail which
   defaults to false. In case of true, loadThumbnail() reads past the
   thumbnail data in the input stream instead of actually loading the
   thumbnail. This simplifies savegame handling where, up until now,
   many engines always read the whole savegame metadata (including
   the thumbnail) and then threw away the thumbnail when not needed
   (which is in almost all cases, the most common exception being
   MetaEngine::querySaveMetaInfos() which is responsible for loading
   savegame metadata for displaying it in the GUI launcher.

2. readSavegameHeader()

   Engines which already implement such a method (name varies) now take
   a new argument skipThumbnail (default: true) which is passed
   through to loadThumbnail(). This means that the default case for
   readSavegameHeader() is now _not_ loading the thumbnail from a
   savegame and just reading past it. In those cases, e.g.
   querySaveMetaInfos(), where we actually are interested in loading
   the thumbnail readSavegameHeader() needs to explicitely be called
   with skipThumbnail == false.

   Engines whose readSavegameHeader() (name varies) already takes an
   argument loadThumbnail have been adapted to have a similar
   prototype and semantics.
   I.e. readSaveHeader(in, loadThumbnail, header) now is
   readSaveHeader(in, header, skipThumbnail).

3. Error handling

   Engines which previously did not check the return value of
   readSavegameHeader() (name varies) now do so ensuring that possibly
   broken savegames (be it a broken thumbnail or something else) don't
   make it into the GUI launcher list in the first place.
 2018-04-07 09:26:20 +02:00
Johannes Schickel d5b21c4036 HOPKINS: Make GPL headers consistent in themselves. 2014-02-18 02:39:35 +01:00
Johannes Schickel cad9148f85 HOPKINS: Take advantage of Surface::getPixels. 2013-08-03 04:02:51 +02:00
Johannes Schickel 8b763977a3 HOPKINS: Prefer getBasePtr over direct Surface::pixels access. 2013-08-03 02:52:32 +02:00
Paul Gilbert ac70aa2e5c HOPKINS: Bumped up savegame version, and added load handling the brief version 3 format 2013-07-31 21:21:29 -04:00
Paul Gilbert 07d8e5643b HOPKINS: Reverted to saving Breakout high scores in a separate file 2013-07-31 21:01:04 -04:00
Paul Gilbert dee719390c HOPKINS: Move breakout highscore table to savegames, and fixes to display 2013-07-26 21:57:02 -04:00
Torbjörn Andersson 6716fa39a6 HOPKINS: Change some variable names for consistency 
This silences a GCC warning about a 'saveFile' variable shadowing
a saveFile() method.
 2013-06-26 21:33:30 +02:00
Strangerke 63c462efce HOPKINS: Remove erroneous static keyword, get rid of g_vm 2013-06-26 20:11:00 +02:00
Strangerke 823844f396 HOPKINS: Fix bug #3612115 - Courtesy of SylvainTV: Fix palette in thumbnails 2013-05-08 00:24:33 +02:00
Alyssa Milburn e5509488ed HOPKINS: fix ingame save thumbnails on BE 2013-04-17 12:30:38 +02:00
Strangerke 55938b3975 HOPKINS: Make engine less verbose by reducing some object names 2013-04-10 10:27:06 +02:00
Paul Gilbert bfe63b71e9 HOPKINS: Renaming some of the remaining graphics methods 2013-04-09 09:17:11 -04:00
Strangerke e848ed7bac HOPKINS: Rename display buffers 2013-03-30 14:20:18 +01:00
Strangerke 848841772f HOPKINS: Remove setParent() from SaveLoadManager and ScriptManager 2013-03-20 08:06:10 +01:00
Strangerke c5c7ced5ee HOPKINS: Remove setParent() from MenuManager and ObjectsManager 2013-03-20 07:56:16 +01:00
Strangerke 6a446ff9d1 HOPKINS: Remove setParent() from GraphicsManager 2013-03-20 07:36:06 +01:00
Strangerke 852e65bd02 HOPKINS: Remove setParent() from Globals 2013-03-20 07:27:42 +01:00
Strangerke db6d7e256b HOPKINS: Remove setParent() from EventsManager and Debugger 2013-03-19 20:41:39 +01:00
Strangerke d7ea7ca378 HOPKINS: Rename some more savegame indexes 2013-03-01 07:57:11 +01:00
Strangerke 7c30a64121 HOPKINS: Rename some members of savegame offset enum, remove some unused ones 2013-02-28 08:16:38 +01:00
Strangerke 79062f426e HOPKINS: Some renaming in GraphicsManager 2013-02-26 07:37:09 +01:00
Willem Jan Palenstijn 5d36b5fb6e HOPKINS: Pre-convert palette 2013-02-21 18:37:15 +01:00
Strangerke 84e290eade HOPKINS: Reorder includes 2013-02-15 22:20:24 +01:00
Strangerke a836676312 HOPKINS:Move some variables from globals to ObjectManager 2013-02-07 22:30:40 +01:00
Strangerke 704a36d1fb HOPKINS: More renaming in ObjectsManager and globals 2013-01-21 22:25:12 +01:00
Strangerke 2cd0d1f4a1 Hopkins: More renaming 2013-01-21 19:15:37 +01:00
Strangerke 33636f0d63 HOPKINS: More renaming in ObjectsManager 2013-01-21 18:59:17 +01:00
Strangerke 75ba8bfb88 HOPKINS: Rename car related fields, remove map car sprite index 2013-01-14 07:58:06 +01:00
Strangerke 65c61ab6d7 HOPKINS: Add synchronization of car position on the city map 2013-01-14 07:52:24 +01:00
Strangerke 7c88b9c54e HOPKINS: Silence some GCC warning (thanks to eriktorbjorn) 2013-01-02 16:04:15 +01:00
Strangerke 4ab60c43c0 HOPKINS: Refactor handleGoto and handleIf, some renaming 2012-12-24 13:32:39 +01:00
Strangerke d80790a8d8 HOPKINS: Remove remaining hexa values 2012-12-21 08:12:02 +01:00
Strangerke 687b7f97df HOPKINS: Remane functions and variables from Globals 2012-12-20 00:30:01 +01:00
Strangerke c1aafc9b47 HOPKINS: Rename methods in ObjectsManager, Globals and GraphicsManager 2012-12-19 02:15:32 +01:00
Strangerke e99d5b320a HOPKINS: Renaming of members of Globals and ObjectsManager 2012-12-17 00:16:49 +01:00
Strangerke 385d097167 HOPKINS: Some more renaming 2012-12-16 14:22:24 +01:00
Strangerke 38437c4efe HOPKINS: Some more renaming 2012-12-16 02:11:36 +01:00
Strangerke d7d8c19dae HOPKINS: Merge two zoom in and out functions 2012-12-15 22:46:09 +01:00
Strangerke 95025312a7 HOPKINS: Janitorial - Remove trailing space and double semi columns 2012-12-14 01:49:22 +01:00
Strangerke 299fbfc7c7 HOPKINS: Start renaming EventsManager functions 2012-12-11 01:53:50 +01:00
Paul Gilbert a8c7f70251 HOPKINS: Apply second memory leak patch 2012-12-08 22:45:11 +11:00
Paul Gilbert b230dff1e9 HOPKINS: Fix savegame thumbnails 2012-11-30 23:15:47 +11:00
Paul Gilbert 9f9bf34ffd HOPKINS: Renamed CharcaterInfo fields of SAUVEGARDE 2012-11-25 20:56:47 +11:00
Paul Gilbert d52ae2f47b HOPKINS: Clean-up of CHANGE_TETE to fix switching characters 2012-11-24 22:26:06 +11:00
Paul Gilbert 367f0aac7e HOPKINS: Remove duplicate GOACTION variable. 
This fixes arriving at destinations from the map view.
 2012-10-28 15:46:52 +11:00
Paul Gilbert 0930151e21 HOPKINS: Implemented save restore functionality 2012-10-28 11:01:30 +11:00
Paul Gilbert d7277c3a30 HOPKINS: Disable greyscaling of savegame thumbnails 2012-10-28 10:45:54 +11:00
Paul Gilbert ec0a33b949 HOPKINS: Beginnings of save/load implementation 2012-10-27 22:16:54 +11:00
Paul Gilbert 1651bb07d9 HOPKINS: Move Save/Load dialog code from menu.cpp to dialogs.cpp 2012-10-27 20:19:21 +11:00