While ESEG_SIZE in resources.cpp is 35810 (0x8be2), create_teenagent
tool actually generates data with ESEG_SIZE of 35809, because of the
changes made in b7921fa and 495bfc6. This in turn makes the game
crash in Segment::read() when reading from eseg. By changing "Noone" to "No
one" we effectively add +1 to the size and fix both the spelling and the
crash.
Commit 59905ee that added support for the Russian fan translation
introduced a regression for other languages. The character mapping
for cyrillic characters colide with some acccented characters used
by other languages. And as it was inserted before the accented
characters in the mapping table, it took precedence.
This commit changes slightly the format of the drascula.dat file
so that the engine can identify different parts of the character
map and skip part of it depending on the game language.
If the engines directory contains plugins_table.h or detection_table.h
from an in-source build, when building out-of-source, these files from
the source directory were prioritized over build directory versions.
This caused issues when different plugins were enabled across builds.
The revised include order now matches the implementation in Makefile.
Regarding the `configure` script, we now have:
* default: add `-Werror=flag-name` for selected warnings where it's
important to fail early (just `-Werror=return-type` for now)
* --enable-Werror: use `-Werror` for all warnings
* --disable-Werror: don't any `-Werror` flag
For Xcode, `-Werror=return-type` is added to default flags.
For MSVC, equivalent flags have been added to the existing
`globalErrors` list.
Suggested by sluicebox.
That one was a bit heavy-handed: enums really shouldn't be passed as
const references.
Revert changes of:
- Common::CodePage
- Common::EventType
- Common::Keycode
- Common::Language
- Common::Platform
Additionally change ProjectDescription::setLanguage and
ProjectDescription::getLanguage in engines/mtropolis/runtime.{cpp,h} as
those used a Common::Language reference, too.
For consistency reasons; all other relevant `g_obsoleteLanguages`
changes were already applied to `langMap` in md5table.cpp, except for
this one.
It also better matches the resulting gameid of the detected games.
(Nice discovery along the way: there were two French floppy releases
of DOTT, the v1.1 one having some text changes/fixes, and possibly
some bug fixes as well.)
Alikhan Balpykov
Eugene Sandulenko
eientei95
neuromancer
SupSuper
Cameron Cawley
Filippos Karapetis
Orgad Shaneh
Le Philousophe
Paweł Kołodziejski
antoniou79
Thierry Crozat
Walter Agazzi
Michal Breškovec
Donovan Watteau
Miro Kropacek
sluicebox
Michael Ball
athrxx
Daniel Nylander