ScummVM/scummvm
1
0 Fork 0
mirror of https://github.com/scummvm/scummvm.git synced 2026-06-20 05:45:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
149,651 Commits 45 Branches 139 Tags
8a4d11eb64dff866ecf798df8755154cdca7c1f9
Commit Graph
127 Commits
Author SHA1 Message Date
AndywinXp 74d5d2c81b SCUMM: COMI: Fix erratic quit confirmation behavior 2023-11-25 12:25:08 +01:00
AndywinXp f57f2b3af5 SCUMM: MACGUI: Add MacListBox and add test code for Open Dialog 
MacListBox code, courtesy by eriktorbjorn!
 2023-11-18 18:47:39 +01:00
AndywinXp fb86877ec1 SCUMM: MACGUI: Wire up some more callbacks 
I wired up almost every Indy3 option (except for audio, which
might need some special handling), and I implemented the
scrollable text list in the save menu.
 2023-11-18 18:47:39 +01:00
AndywinXp 8ddd8da773 SCUMM: GUI: Fix confirmation on exit behavior on script quit commands 
We now quit without confirmation when the scripts tell the
interpreter to quit. Except in COMI main menu, when pressing
on the "Quit" option. In that case we must ALWAYS show the
confirmation dialog box.
 2023-11-13 22:33:18 +01:00
AndywinXp cdabda2477 SCUMM: GFX: Set correct fadeout transition when restarting game 2023-11-13 20:37:13 +01:00
AndywinXp e4232b95b1 SCUMM: GUI: Implement accurate menus for Jap Indy4 (DOS/Mac) 2023-11-12 18:59:18 +01:00
AndywinXp 003be954ea SCUMM: INDY4 (DOS/Mac Jap): Fix verb text height, kerning and banner text positioning 2023-11-12 14:39:46 +01:00
AndywinXp 8461f25218 SCUMM: Rename enhancementClassActive to enhancementEnabled 2023-11-08 11:46:06 +01:00
AndywinXp d5fa7aeb90 SCUMM: Mark all enhancements with their respective classes 2023-11-08 11:46:06 +01:00
sluicebox bc7dcc0366 SCUMM: Fix out of bounds array access 
ScummEngine::runScript expects an array of size NUM_SCRIPT_LOCAL.

Coverity CID 1501555
 2023-11-02 09:28:19 -07:00
sluicebox 58bb4f81e4 SCUMM: Remove unused dummyArgs. PVS-Studio V597 
The intent was to pass zero arguments using dummyArgs, but that would
have caused out of bounds reads because runScript expects an array of
size NUM_SCRIPT_LOCAL (25). Passing `args` worked because it was
already zeroed out, but runScript also accepts null for this purpose.

See: 19b45e2a50
 2023-10-31 14:20:25 -07:00
Eugene Sandulenko 727caebc85 SCUMM: Marked Russian a long language in drafts inventory, restored cropped draft names 2023-10-29 21:08:28 +01:00
Eugene Sandulenko 71abdfce08 SCUMM: Added Russian draft names to Lomm drafts inventory 2023-10-29 20:58:13 +01:00
AndywinXp ff3c922b8d SCUMM: LOOM/GUI: Mask currently unknown drafts titles 2023-10-29 20:22:52 +01:00
AndywinXp d97fe2034d SCUMM: LOOM/GUI: Fix text colors inversion for Hebrew 2023-10-29 20:22:52 +01:00
AndywinXp 3a590f203e SCUMM: LOOM/GUI: Fix FM-Towns widget not disappearing 2023-10-29 20:22:52 +01:00
AndywinXp dce87d8bda SCUMM: LOOM/GUI: Fix occasional wrong text height being fetched 
Also, clean-up.
 2023-10-29 20:22:52 +01:00
AndywinXp 353e5102c5 SCUMM: LOOM/GUI: Fix Hebrew layout and add more comments 2023-10-29 20:22:52 +01:00
AndywinXp 8d469f430f SCUMM: LOOM/GUI: Clean up and fix drafts menu for French strings 
French strings are a little bit too long for this menu :)
 2023-10-29 20:22:52 +01:00
AndywinXp a3f7899ca2 SCUMM: LOOM/GUI: Remove stray ":" in Jap Drafts title 2023-10-29 20:22:52 +01:00
AndywinXp 0777b3b013 SCUMM: LOOM: Insert French and Spanish translations for Draft menu 2023-10-29 20:22:52 +01:00
AndywinXp c62e4c5829 SCUMM: LOOM: Begin work on Drafts Inventory enhancement 2023-10-29 20:22:52 +01:00
AndywinXp e949b1ed47 SCUMM: GUI: Restore previous _saveSound at the end of menu 
Fixes the main part of ticket #14618.
Fix suggested by eriktorbjorn.
 2023-09-14 15:17:54 +02:00
athrxx 0201155544 SCUMM: (MI2) - fix assert triggering when pressing F5 
This happens on screeens with an xstart offset (= a screen
that is wider than 320 pixels, after some scrolling) but only
when there is dialogue text on screen when pressing F5.
Can be tested right at the start on the bridge. Just right-
click the sign, then press F5...
 2023-08-19 22:19:41 +02:00
AndywinXp f484ad6545 SCUMM: SAMNMAX: Fix bug #14467 
This was caused by the fact that the pre and post save screen scripts
were not being called, and this messed up the cursor state with savegames
created as quicksaves.

Also, renamed the variables containing said scripts numbers, so that
they are a little bit more meaningful now.
 2023-05-21 21:17:36 +02:00
AndywinXp 9926908983 SCUMM: SAMNMAX: Fix bug #14468 
I really have no idea why I wrote the code in such a way that
it attempted to load stuff that was never saved in the first place,
and I guess we'll never know. Findings by athrxx!
 2023-05-21 20:16:14 +02:00
AndywinXp e28b3f09b1 SCUMM: GUI: Use correct heap message for some v6 games 2023-03-19 19:26:15 +01:00
AndywinXp e494b2527b SCUMM: DOTT: Fix quit prompt appearing when using the PC in Ed's room 
This only affects the original GUI mode, and leaves the other mode as it has always been; also,
the issue only appeared when the global configuration parameter "confirm_exit" was set to true.
 2023-01-28 10:14:42 +01:00
AndywinXp d9777bf512 SCUMM: GUI: Correctly save the shake screen flag 2023-01-23 16:14:45 +01:00
AndywinXp cc2b4de6ec SCUMM: DOTT/GUI: Fix cursor not reappearing when loading a savegame 2023-01-22 23:11:25 +01:00
AndywinXp e8dfcb42f6 SCUMM: GUI: Implement ScummVM quit confirmation override 
Now, the original GUI will ask you for confirmation only if the "confirm_exit" config
flag is active.
 2023-01-20 10:03:37 +01:00
AndywinXp 7c158b1005 SCUMM: GUI: Fix voice mode string id for foreign versions of FT 2023-01-08 23:26:27 +01:00
AndywinXp 6f4acceede SCUMM: GUI: Insert workaround for german LOOM FM-Towns 
Fixes a part of bug #13980
 2022-12-27 15:00:56 +01:00
Donovan Watteau 818194e8cf SCUMM: Fix build on older systems lacking strnlen 2022-12-24 09:32:45 +01:00
AndywinXp 4d6d76b60b SCUMM: GUI: Implement missing banners for v6 games 2022-12-20 22:38:26 +01:00
AndywinXp 76f4371f45 SCUMM: GUI: Handle numbers strings with const chars instead of String objects 2022-12-13 18:40:11 +01:00
AndywinXp 87625eb23e SCUMM: GUI: Use strnlen to measure current passcode length 2022-12-13 18:40:11 +01:00
AndywinXp f463d032d8 SCUMM: GUI: Improve readability 2022-12-13 18:40:11 +01:00
AndywinXp beb65bc902 SCUMM: GUI: Fix warnings 2022-12-13 18:40:11 +01:00
AndywinXp 19b45e2a50 SCUMM: GUI: Fix passcode not being updated on MI1 SegaCD 
Big thanks to eientei (einstein95) for the research for this commit!
 2022-12-13 18:40:11 +01:00
AndywinXp b1eaf2ea0f SCUMM: GUI: Implement MI1 SegaCD menu 2022-12-13 18:40:11 +01:00
AndywinXp 0f93142ac9 SCUMM: MI1 (Sega CD): Fix message banner colors 2022-11-28 23:21:45 +01:00
AndywinXp 918b7f95f1 SCUMM: v3: Fix minor graphical glitch on game quit 2022-11-28 23:21:45 +01:00
AndywinXp ab5010e04b SCUMM: GUI: Remove menu inner box on v5 FM-Towns games 2022-11-28 23:21:45 +01:00
AndywinXp e93f6d2b83 SCUMM: GUI: Fix v5 FM-Towns menu box title 2022-11-28 23:21:45 +01:00
AndywinXp 2c36f10932 SCUMM: GUI: Cleanup 2022-11-28 23:21:45 +01:00
AndywinXp a0613993d3 SCUMM: GUI: Substitute 0 with nullptr for pointer values 2022-11-28 23:21:45 +01:00
AndywinXp 9900bbd616 SCUMM: GUI: Implement original save/load menus for v5 FM-Towns games 2022-11-28 23:21:45 +01:00
AndywinXp f1a18f26e2 SCUMM: GUI: Fix regression on v4 games restart prompts 2022-11-28 23:21:45 +01:00
AndywinXp 3bc9064278 SCUMM: GUI: Make the restart prompt more consistent 
Also make it work for v3 Towns games, which have their own mapping for the F keys
 2022-11-28 23:21:45 +01:00