Commit Graph
86814 Commits
Author SHA1 Message Date
Paul Gilbert 47f6c2e9b9 Merge pull request #1010 from dreammaster/debugger_params
GUI: Support double quoted debugger parameters
2017-09-24 12:18:15 -04:00
Paul Gilbert 3333432b4d TITANIC: Fix leak of movie event structures 2017-09-24 12:15:58 -04:00
Colin Snover d73ada9088 SCI: Fix generation of save games 2017-09-24 11:12:45 -05:00
Paul Gilbert 5424f70002 IMAGE: Fix memory leak in BitmapRawDecoder 2017-09-24 12:02:48 -04:00
Paul Gilbert 36ce79edb4 TITANIC: Fix access after free in shutdown 2017-09-24 10:55:50 -04:00
Paul Gilbert 947894ce1f TITANIC: Free any active wave files on exit 2017-09-24 10:48:04 -04:00
Paul Gilbert b724ea6530 TITANIC: Fix compiler warnings in DeskbotScript 2017-09-24 10:34:13 -04:00
Paul Gilbert 2bc23ba6c3 TITANIC: Fix looking at broken pellerator after the first time 2017-09-24 09:46:27 -04:00
Bastien Bouclet 4890dd4466 NETWORKING: Fix mismatched curl callback declaration and definition 2017-09-24 08:24:40 +02:00
Bastien Bouclet 25d66b2a08 Merge pull request #1027 from bgK/memstream-default-arg
COMMON: Remove the DisposeAfterUse default value from dynamic write memory streams constructors
2017-09-24 06:21:54 +02:00
Thierry Crozat 75026dba8c I18N: Update translations templates 2017-09-24 04:40:21 +02:00
Colin Snover fcf707e20a SCI32: Flush stub RAMA save game to disk
If this is not done and the file is buffered, it will not show up
in the list of save games, and the new save will fail.
2017-09-23 21:39:58 -05:00
Thierry Crozat 7401e859fa I18N: Update translations templates 2017-09-24 04:02:20 +02:00
Colin Snover d2364cb9bb SCI32: Fix bad data cube text priority calculation in RAMA 2017-09-23 20:57:04 -05:00
Colin Snover f83c61fcb6 SCI32: Fix relocation of locals in SCI3
Somehow, up until trying to view an encrypted data cube in RAMA,
the missing relocation of locals did not seem to cause any trouble
in any of the other SCI3 games.
2017-09-23 20:57:03 -05:00
Colin Snover 643a572610 Revert "SCI: Fix Warnings about Copy Constructor Failing to Call Base Class."
This reverts commit d2dd942ad7.

The Serializable class is an interface class and has only the
empty default copy constructor. There is no reason to call this
explicitly. Whatever is warning about this should be fixed to stop
warning about it, rather than adding such unnecessary calls to the
engine code.
2017-09-23 20:57:03 -05:00
Colin Snover dced2fb9f5 SCI32: Fix handling of array copies
kArrayCopy would perform an unnecessary memory copy of the source
array, the treatment of the count value as unsigned was clearly
not correct since it was being sign-extended and checked against
-1.
2017-09-23 20:57:03 -05:00
Colin Snover 6972c9ae46 SCI32: Fix bad default text scaling in RAMA 2017-09-23 20:57:02 -05:00
Colin Snover 602de8363b SCI32: Fix infinite reload in RAMA when loading from launcher 2017-09-23 20:57:02 -05:00
Colin Snover 9c28c25b67 SCI32: Add guest additions save/restore support for RAMA 2017-09-23 20:57:01 -05:00
Colin Snover 475bb5f91a SCI32: Remove unnecessary use of strncmp
One of the strings is a static string of the same size as the size
passed to strncmp so there is no point in not just using strcmp.
2017-09-23 20:57:01 -05:00
Colin Snover a63f516df0 SCI32: Replace magic number with kAutoSaveId in QFG4 save code 2017-09-23 20:57:00 -05:00
Colin Snover b038432952 SCI32: Support RAMA's custom save games through kFileIO 2017-09-23 20:56:48 -05:00
Colin Snover 9298f6a81e SCI: Split save game metadata writing to separate function
RAMA has its own custom save game format that game scripts write,
but we still want to be able to use these save game files from the
ScummVM launcher, so the metadata has to be able to be written
separately from the rest of the game saving.
2017-09-23 20:56:48 -05:00
Colin Snover d17ae077dd SCI: Use reference instead of pointer for required out-data in metadata save function 2017-09-23 20:56:48 -05:00
Colin Snover b3c27c2159 SCI: Clean-ups to file handling code
Preparations for adding support for RAMA's custom save game format.
2017-09-23 20:37:51 -05:00
Colin Snover 0ceab96e91 SCI32: Remove unused shrink-to-fit function for string arrays 2017-09-23 20:37:51 -05:00
Colin Snover 50cfb7ad46 SCI32: Fix size for dereferencing non-raw SCI32 arrays
The maxSize given when generating a SegmentRef is supposed to be
the maximum size of raw data that can be held inside the offset-
part of a reg_t, not the entire size including the segment.

This fixes a buffer overflow in "Inside the Chest", which still
does not work, but at least doesn't cause heap overflows anymore
with this change.
2017-09-23 20:37:51 -05:00
Paul Gilbert d74e94950b TITANIC: DE: Merged German NPC script subclasses back in
There ended up not being enough custom German code in the scripts
to warrant having sub-classes that reimplemented entire methods
2017-09-23 21:18:25 -04:00
Paul Gilbert e5cad39a58 TITANIC: DE: Updates for SuccUBusScript 2017-09-23 21:02:44 -04:00
Paul Gilbert e9034ddffe TITANIC: DE: Added changes to MaitreDScript 2017-09-23 20:39:12 -04:00
Paul Gilbert 6f150abf15 TITANIC: DE: Added changes for LiftbotScript 2017-09-23 19:30:28 -04:00
Paul Gilbert af71ec809b TITANIC: DE: Adding remaining DoorbotScript changes 2017-09-23 17:19:06 -04:00
Paul Gilbert 048bec6808 TITANIC: DE: Adding changes to DoorbotScript 2017-09-23 16:25:44 -04:00
Paul Gilbert 9e2d78446e TITANIC: DE: More BellbotScript changes 2017-09-22 22:31:42 -04:00
Paul Gilbert 5c6de7d2f2 TITANIC: DE: Adding new BellbotScript logic 2017-09-22 20:13:31 -04:00
Paul Gilbert ab624c9cd3 DEVTOOLS: Added German Preresponse lists to create_titanic 2017-09-22 20:06:49 -04:00
Paul Gilbert cd6927d39c TITANIC: DE: Added translations for BarbotScript::process 2017-09-22 07:41:55 -04:00
Bastien Bouclet be67f0d8bf COMMON: Remove DisposeAfterUse default value from dynamic write memory streams
The default value was DisposeAfterUse::NO, which made it very easy to
accidentally leak memory by omitting to specify a value.
2017-09-22 07:06:21 +02:00
Bastien Bouclet 3eb82462e7 ALL: Specify the DisposeAfterUse constructor argument for dynamic memory write streams 2017-09-22 07:06:21 +02:00
Bastien Bouclet 1b3cc08b75 ZVISION: Fix leaking save / thumbnail MemoryWriteStreamDynamic buffers 2017-09-22 07:06:20 +02:00
Bastien Bouclet ddac55699d SWORD25: Fix leaking the lua state MemoryWriteStreamDynamic buffer 2017-09-22 07:06:20 +02:00
Bastien Bouclet 9c2cfee4e5 SWORD25: Fix leaking the save thumbnail MemoryWriteStreamDynamic 2017-09-22 07:06:20 +02:00
Bastien Bouclet c3bff7f25a SWORD1: Fix leaking the save thumbnail MemoryWriteStreamDynamic buffer 2017-09-22 07:06:20 +02:00
Bastien Bouclet 382df4a7c5 GNAP: Fix leaking the save thumbnail MemoryWriteStreamDynamic buffer 2017-09-22 07:06:20 +02:00
Bastien Bouclet 9facbdecda FULLPIPE: Fix leaking the save MemoryWriteStreamDynamic buffer 2017-09-22 07:06:20 +02:00
Bastien Bouclet ab1243277a DM: Fix leaking the save thumbnail MemoryWriteStreamDynamic buffer 2017-09-22 07:06:20 +02:00
Bastien Bouclet 2832332e74 NETWORKING: Changed NetworkReadStream not to subclass MemoryReadWriteStream
Also fix the MemoryReadWriteStream managed buffer being leaked.
Fixes #9718.
2017-09-22 07:05:59 +02:00
Bastien Bouclet bc531e3ebf XEEN: Change OutFile not to subclass MemoryWriteStreamDynamic
Also fix leaking the MemoryWriteStreamDynamic buffer storage
2017-09-22 07:05:59 +02:00
Bastien Bouclet 48bf24b41e XEEN: Change SavesManager to use a map of pointers to MemoryWriteStreamDynamic
Our implementation of HashMap does not allow value types without a
zero-argument constructor.
2017-09-22 07:05:58 +02:00