drawChar is overloaded in FontSJIS. One takes a "Surface &" as first
parameter another one "void *", they furthermore have the exact same
number of required parameters. The one "void *" just had a few extra
parameters with default values. This resulted in a bug in SCUMM, where
"VirtScreen *" (a subclass of Surface) was passed instead of "VirtScreen &"
and thus the method taking "void *" was incorrectly used.
To make it easier to spot such bugs in the future I just removed the default
values and thus disallow such calls.
Silences the clang warning:
static data member specialization of '_singleton' must
originally be declared in namespace 'Common'; accepted as a C++0x
extension [-Wc++0x-extensions]
Wrapping "namespace Common {}" around the macro assignment causes clang
to complain about a spurious semicolon, and removing the semicolon at
the end of the macro causes some editors to misbehave.
Changing the requirement of using the macro in one namespace (the
global) to another (Common) seems a small price to pay to
silence a warning.
This tries to make our code a bit more compliant with our code formatting
conventions. For future use, this is the command I used:
git ls-files "*.cpp" "*.h" | xargs sed -i -e 's/[ \t]*$//'
This makes it easy to get a localized font for the current
TranslationManager charset if one has been loaded. It tries
first to find one for the BigGUI or GUI fonts and then looks
for any acceptable font.
Also only use lower case font name for the FontManager HashMap.
This is to avoid issues with the case when looking for a font by
its name. There was for example an issue for font helvB12 that is
named helvb12 in the scummmodern theme.
OSD is now using the kGUIFont instead. The main advantage is that
the kGUIFont can be used for translated text while only ASCII
characters were present in ScummFont.
Formerly the palette parameter was a value copy, which was assigned in
getPalette. That did not make much sense, thus I changed it to be a reference.
Since I am not quite sure whether this really shouldn't make a palette copy
I added an TODO comment about it.
Johannes Schickel
Ori Avtalion
Eugene Sandulenko
Littleboy
Filippos Karapetis
Max Horn
eriktorbjorn
CeRiAl
Willem Jan Palenstijn
Alyssa Milburn
Thierry Crozat
Matthew Hoops
strangerke
peres