Commit Graph
3264 Commits
Author SHA1 Message Date
Colin Snover 4d3f05ae79 SCUMM: Fix array overflow writing var when no current script is set
This situation is triggered normally when _currentScript is 0xFF,
but it could potentially also happen if _currentScript is some
other number >= NUM_SCRIPT_SLOT, so the check is a bit more
conservative than it might appear to need to be.
2017-12-01 19:39:30 -06:00
Colin Snover 2b5605362a SCUMM: Fix signed integer overflow reading default v70HE cursor 2017-12-01 19:23:00 -06:00
Colin Snover c7989bb333 SCUMM: Fix buffer overflow reading default v70HE cursor 2017-12-01 19:22:56 -06:00
Colin Snover 5cd2c9a387 SCUMM: Fix possible return of garbage values 2017-12-01 19:22:52 -06:00
Colin Snover 57084b4a1b SCUMM: Fix UB shifting negative integers in Actor 2017-12-01 19:22:35 -06:00
Colin Snover 9a36870e78 SCUMM HE: Fix UB shifting negative integers 2017-12-01 19:22:19 -06:00
Eugene Sandulenko 89a782466a SCUMM: Revert skipping of MM C64 demo original save screen display attempt
As per discussion in bug #10116.
2017-11-27 20:50:28 +01:00
Eugene Sandulenko 5183b2024c SCUMM: Do not do anything for real with original save screen in MM C64 demo 2017-11-26 05:15:42 +01:00
Eugene Sandulenko a7182e2a6a SCUMM: Do not try to show original save/load screen in C64 demo
Fixes bug #10116
2017-11-25 23:35:28 +01:00
Colin Snover 0eda63bed1 SCUMM: Fix race condition in MOD player
Fixes Trac#6272.
2017-11-12 23:15:05 -06:00
Colin Snover 51329c0dc6 ALL: Fix misuse of comma operator 2017-11-10 09:57:03 -06:00
Ben Castricum a8faf239a1 SCUMM: Prevent false detection of Steam games 2017-10-31 11:03:53 +01:00
Colin Snover 64191781b5 SCUMM: Fix compilation on systems without USE_RGB_COLOR 2017-10-07 13:09:07 -05:00
Colin Snover 432fd522d2 ENGINES: Remove default1x scaler flag
This flag is removed for a few reasons:

* Engines universally set this flag to true for widths > 320,
  which made it redundant everywhere;
* This flag functioned primarily as a "force 1x scaler" flag,
  since its behaviour was almost completely undocumented and users
  would need to figure out that they'd need an explicit non-default
  scaler set to get a scaler to operate at widths > 320;
* (Most importantly) engines should not be in the business of
  deciding how the backend may choose to render its virtual screen.
  The choice of rendering behaviour belongs to the user, and the
  backend, in that order.

A nearby future commit restores the default1x scaler behaviour in
the SDL backend code for the moment, but in the future it is my
hope that there will be a better configuration UI to allow users
to specify how they want scaling to work for high resolutions.
2017-10-07 12:30:29 -05:00
Bastien Bouclet 3eb82462e7 ALL: Specify the DisposeAfterUse constructor argument for dynamic memory write streams 2017-09-22 07:06:21 +02:00
Ben Castricum 203b5138fa SCUMM: Update MD5 include file 2017-08-21 16:04:31 +02:00
Ben Castricum f26e36c2e4 SCUMM: Add detection for German version of Spy Fox 1, fixes bug #9732 2017-08-21 16:04:31 +02:00
Ben Castricum ae8f6397eb SCUMM: Prevent darkenPallete() in Room 0 in FT, fixes bug #9871 2017-08-17 09:47:03 +01:00
Eugene Sandulenko b840320c5b SCUMM: Moonbase: Mark original bug as fall through to silence GCC 7 warning 2017-08-11 20:53:21 +02:00
Eugene Sandulenko e0b3001218 SCUMM: Add missing return statement 2017-08-11 20:20:25 +02:00
Eugene Sandulenko 41d8441ea8 SCUMM: Add missing break to INSANE code. Thanks to eriktorbjorn and GCC7 2017-08-11 20:13:24 +02:00
Kirben 2fe8931907 SCUMM: Don't list Amiga version of The Secret of Monkey Island as VGA, as it leads to confusion. 2017-08-10 09:35:33 +10:00
Torbjörn Andersson 0bde79b2b8 JANITORIAL: Silence some more GCC 7 fall through warnings 2017-08-06 16:35:25 +02:00
Torbjörn Andersson 4fb0d1e56f JANITORIAL: Increase buffer size to fix potential overflow
Caught by GCC 7 (though the warning seemed misleading to me). Since
SoundDesc->name can potentially be 14 characters "%s_reg%03d.fla"
can be 25 characters, plus the terminating \0.
2017-08-06 12:00:32 +02:00
Torbjörn Andersson b4c1e86d9f JANITORIAL: Silence GCC warning
Since case 64 was added for "MM C64 Costume Animation", and
considering the way it's written to only affect game version 0,
it is clearly an intentional fall through.
2017-08-06 11:51:57 +02:00
D G Turner 5c85230443 SCUMM: Fix Typo in Detection Table Comment.
No functional change.
2017-08-04 04:27:09 +01:00
Ben Castricum d58f594755 SCUMM: MI2 kill tune 113 on start of next, Fixes bug #1410 / Booty Island
Fix the "MI2: Two soundtracks playing at once" bug from the bug tracker.
It's triggered when the player enters the kiosk for the second time and
leaves before tune 113 is started.
2017-07-30 22:10:54 +02:00
Ben Castricum 392d8b44ff SCUMM: MI2 kill tune 107 on start of next, Fixes bug #1410 / Scabb Island
Fix the "MI2: Two soundtracks playing at once" bug from the forum.  It's
triggered when the player is moving faster then the scripts expect causing
the "stop tune 117" command be executed before the start of the tune.
Effectily creating a hanging tune 107.
This patch kills the tune when this sitation is detected.
2017-07-30 22:10:54 +02:00
Eugene Sandulenko 085332a3dc Merge pull request #902 from segrax/Fix_4556
SCUMM: Fix bug #4556 (Maniac: Purple Tentacle appears in Lab after being chased out)
2017-02-21 23:33:17 +01:00
Eugene Sandulenko b44b297a84 Merge pull request #903 from segrax/Fix_4112
SCUMM: Fix bug #4112 (MANIAC: Power never returns)
2017-02-21 23:32:10 +01:00
Robert Crossfield 038b3b1789 SCUMM: MM V0: Fix actors skipping between certain walk-boxes 2017-02-21 06:17:32 +11:00
Robert Crossfield 02ac724c66 SCUMM: MM V0: Fix an issue with Sandy appearing to slide across a walkbox 2017-02-15 17:05:28 +11:00
Robert Crossfield 56caa6f0a7 SCUMM: Cleanup Maniac Mansion workarounds 2017-02-14 19:26:11 +11:00
Robert Crossfield 9e07738b52 SCUMM: Fix bug #4112. If you enter the lab while Dr. Fred has the power off, the power won't be turned back on as the script is killed 2017-02-14 18:28:58 +11:00
Robert Crossfield 165a1bb070 SCUMM: Fix bug #4556 (Maniac C64/V1/V2: Purple Tentacle appears in Lab Entry after being chased out) 2017-02-13 17:51:00 +11:00
Eugene Sandulenko e5ebc903ea Merge pull request #877 from segrax/Fix_2285
SCUMM: Fix bug #2285 (ZAK C64/V1/V2 Caponians dont disguise after using crystal)
2017-01-13 23:15:35 +01:00
Robert Crossfield a3ca4412fa SCUMM: Fix bug #2285 (ZAK C64/V1/V2 Caponians don't disguise after using blue crystal) 2016-12-28 09:23:54 +11:00
Robert Crossfield c95b6a9f8d SCUMM: Fix bug #6817 (V1 Actors drawn 1 line too high) 2016-12-27 10:21:23 +11:00
Robert Crossfield 485f26e4d6 SCUMM: Fix bug #4515 (Dr. Fred facing wrong way in lab cutscene) 2016-12-27 10:21:09 +11:00
Torbjörn Andersson e17fa6216b SCUMM HE: Silence GCC indentation warning 2016-12-06 21:01:06 +01:00
Ben Castricum 6f38c1e55d ALL: game state => saved game 2016-11-29 20:15:20 +01:00
Ben Castricum d3cd42e1d4 ALL: Fix usage of 'etc.' 2016-11-29 20:14:41 +01:00
Eugene Sandulenko 83c74d68a1 SCUMM HE: Fix crash in Moonbase distrotion 2016-11-27 14:02:52 +01:00
Eugene Sandulenko 0ebe534771 SCUMM: Fix dialog initialization 2016-11-27 14:02:52 +01:00
Eugene Sandulenko cf5c6beb3a SCUMM: Set initial EOS state in Scumm::File class 2016-11-27 14:02:52 +01:00
Eugene Sandulenko 3f2fce5691 SCUMM: Properly inint FM-TOWNS gfx code 2016-11-27 14:02:52 +01:00
Eugene Sandulenko a9566997aa SCUMM HE: More class initializations 2016-11-27 14:02:52 +01:00
rootfather 70a990f6ab SCUMM: Enable translation for the unknown game warning
We have translations enabled for the warning created
by advancedDetector.cpp, so I think it would be neat
to have translations enabled here too.

This also enables the message about the "Lite" version
of Putt-Putt Saves the Zoo being unsupported to the
translation database.
2016-11-26 11:22:17 +01:00
Eugene Sandulenko 2fd5490de4 SCUMM HE: Fix Football logic initialization 2016-11-24 11:34:13 +01:00
Eugene Sandulenko cce8885b39 SCUMM HE: Hid noisy Moonbase AI warnings under debug channel 2016-11-20 23:38:33 +01:00