Commit Graph
194 Commits
Author SHA1 Message Date
Adrian Frühwirth 07efcfd458 SCUMM: Fix wrong comment about iMUSE digital variable 2018-05-21 11:24:40 +02:00
Colin Snover 2e061d95c5 COMMON: Move VER macro for serializer into common code 2018-01-31 17:58:01 +01:00
Colin Snover 9916b26383 SCUMM: Replace UB-triggering serialization code with Common::Serializer
Fixes Trac#10342.
2018-01-31 17:58:01 +01:00
Adrian Frühwirth 16eac57834 SCUMM: implement lipsync for v7 games 2018-01-31 16:38:07 +01:00
Torbjörn Andersson 4fb0d1e56f JANITORIAL: Increase buffer size to fix potential overflow
Caught by GCC 7 (though the warning seemed misleading to me). Since
SoundDesc->name can potentially be 14 characters "%s_reg%03d.fla"
can be 25 characters, plus the terminating \0.
2017-08-06 12:00:32 +02:00
Ori Avtalion 3564032330 JANITORIAL: Reduce audio header dependencies 2016-04-14 16:10:21 +03:00
Alexandre Detiste 6c298e964f JANITORIAL: Typos detected with lintian & grep 2016-02-15 18:27:02 +01:00
Matthew Hoops 1d45e08889 SCUMM: Do not reverse stereo for digital iMuse sounds 2015-09-04 23:48:40 -04:00
Johannes Schickel 3847465163 SCUMM: Make GPL headers consistent in themselves. 2014-02-18 02:39:38 +01:00
Eugene Sandulenko 2362498d54 SCUMM: Fix potential memory leak. CID 1003586 2013-11-03 01:28:03 +02:00
Rodrigo Rebello be2f292457 SCUMM: Fix unused variable warnings 2013-10-03 01:47:02 -03:00
Torbjörn Andersson 08be916049 SCUMM: Verify sample width in Digital iMUSE callback. CID 1002112
Verify that 'bits' really is one of 8, 12 or 16 before decoding
the data. It's probably always the case (unless the data files are
damaged) but if it isn't we'll either try to queue NULL to the
audio stream, or queue the same buffer more than once, or free the
buffer more than once. All of which are bad, though Coverity only
noticed the last of these cases.
2013-06-04 06:11:41 +02:00
Joel Teichroeb 93632681c0 SCUMM: Fix spelling of length 2012-04-04 21:23:14 -07:00
Eugene Sandulenko 78f1ea7690 OSYSTEM: extended installTimerProc() with timer ID parameter 2011-08-06 11:28:35 +01:00
athrxx 636a28c0dd SCUMM: fix crash in digital iMuse games when using RTL and restarting
(static array were not reset to NULL after being freed and therefore didn't get reallocated on restart)
2011-07-03 14:40:57 +02:00
Max Horn 82343f6649 SCUMM: Remove some unused var warnings (see bug #3293800) 2011-05-14 23:50:43 +02:00
Max Horn b37463fe59 SCUMM: Move class ResourceManager to its own header 2011-05-13 11:47:08 +02:00
strangerke 69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
Ori Avtalion 9414d7a6e2 JANITORIAL: Reduce header dependencies in shared code
Some backends may break as I only compiled SDL
2011-04-28 15:08:58 +03:00
Max Horn 4ab51a8b26 SCUMM: Typo 2011-04-14 09:26:50 +02:00
Max Horn 1759209b3b SCUMM: Use shared ADPCM data tables 2011-04-13 12:48:58 +02:00
Max Horn 9c2ff87db7 SCUMM: Fix bug #3187622 (COMI: incorrect decoding of audio codec 13/15) 2011-04-13 11:49:25 +02:00
Max Horn b52b6b8d2b SCUMM: Resolve some code duplication 2011-04-13 11:49:25 +02:00
Max Horn 29962bfc73 SCUMM: Move ADPCM decoder into separate function 2011-04-13 11:49:24 +02:00
Max Horn 0ce2ca4e00 COMMON: Replace MKID_BE by MKTAG
MKID_BE relied on unspecified behavior of the C++ compiler,
and as such was always a bit unsafe. The new MKTAG macro
is slightly less elegant, but does no longer depend on the
behavior of the compiler.
Inspired by FFmpeg, which has an almost identical macro.
2011-04-12 16:53:15 +02:00
dhewg d83a83ef50 JANITORIAL: Remove/comment unused vars
Found by GCC 4.6's -Wunused-but-set-variable
2011-03-29 21:57:56 +02:00
Max Horn 42ab839dd6 AUDIO: Rename sound/ dir to audio/
svn-id: r55850
2011-02-09 01:09:01 +00:00
Max Horn 54e0390752 SCUMM: Replace Common::File uses by SeekableReadStream and SearchMan
svn-id: r54434
2010-11-23 22:25:10 +00:00
Max Horn 2180b2d6b5 COMMON: Split common/stream.h into several headers
svn-id: r54385
2010-11-19 17:03:07 +00:00
Max Horn a1840bd573 AUDIO: Rename Mixer::playInputStream to playStream
svn-id: r48637
2010-04-12 09:14:17 +00:00
Johannes Schickel ef70f6996b Fix another mismatching new[] call (note that this needs to be replaced by malloc, since else MemoryReadStream will try to use free on an new[] allocated block.)
svn-id: r48162
2010-03-04 17:46:18 +00:00
Johannes Schickel fe35d372da - Rename FlacStream to FLACStream.
- Rename makeFlacStream to makeFLACStream.

svn-id: r47846
2010-02-03 09:42:11 +00:00
Max Horn 1565f14bc1 Moved audio stream implementations (for MP3, FLAC, etc.) to new dir sound/decoders/
svn-id: r47579
2010-01-26 22:48:45 +00:00
Max Horn 7ab85cd035 SCUMM: Get rid of some redundant enum vals in iMuse digitial
svn-id: r47436
2010-01-22 14:11:33 +00:00
Max Horn dc5e08e623 Move raw audio flags from sound/mixer.h to sound/raw.h
svn-id: r47395
2010-01-19 22:30:33 +00:00
Max Horn f0a0ed8f9e Get rid of Mixer::FLAG_REVERSE_STEREO; also change SCUMM's iMuse Digital emulation to reverse stereo again, as it once seems to have been intended
svn-id: r47374
2010-01-19 11:19:53 +00:00
Max Horn 557bb394de Get rid of Mixer::FLAG_AUTOFREE.
Also fix several recently introduced new/delete vs. malloc/free mismatches.

svn-id: r47369
2010-01-19 00:56:29 +00:00
Max Horn 7ec2da968c Switch most AudioStream factories to use DisposeAfterUse::Flag
svn-id: r47334
2010-01-16 21:36:08 +00:00
Max Horn c489259353 Switch SCUMM from AppendableAudioStream to QueuingAudioStream
svn-id: r47183
2010-01-08 22:10:19 +00:00
Johannes Schickel 5243157eb1 Adapt digital iMuse to use SeekableAudioStream::seek, instead of ryling on the deprecated FLAC, Vorbis and MP3 interface.
svn-id: r47064
2010-01-06 00:01:27 +00:00
Johannes Schickel 81a94a0644 - Put the new factories for MP3, Vorbis and FLAC in place.
- Marked the loop factories with loop related parameters as deprecated.

svn-id: r47061
2010-01-05 23:59:28 +00:00
Paweł Kołodziejski 227e4e65df fix for bug #2820389
svn-id: r44274
2009-09-23 13:22:12 +00:00
Paweł Kołodziejski e6580be475 not need continue checks after found
svn-id: r44272
2009-09-23 13:04:51 +00:00
Travis Howell 122ff32d75 Remove excess spaces.
svn-id: r44029
2009-09-11 10:13:54 +00:00
Torbjörn Andersson 01886d3e52 Added some more information to the "Compressed sound ... invalid" error. Maybe
this will help in determining what's causing bug #2830364. (It sounds like a
bad data file, but who knows...)

svn-id: r42974
2009-08-01 15:42:42 +00:00
Travis Howell cff307e55d Fix bug #2821986 - COMI: setting to 'subtitles only' does not disable speech.
svn-id: r42548
2009-07-17 00:25:27 +00:00
Torbjörn Andersson 0999534749 The error() and warning() functions add ! and newline automatically. (I didn't
look at debug() and debugC(), since I'm really bored with this now. :-)

svn-id: r41061
2009-05-31 10:02:16 +00:00
Max Horn 7d5f3e1714 Turned some static tables into static const tables; added some FIXME comments to global static vars that should be removed (many more exist in SCI, Tinsel, and some other engines)
svn-id: r40908
2009-05-26 11:30:21 +00:00
Max Horn 432e7917a5 SCUMM: Switched opcode tables to use Common::Functor0 (a bit like Kyra does it)
svn-id: r39956
2009-04-16 09:26:37 +00:00
Paweł Kołodziejski 5062401423 fixed 'if' statement as should be/was.
svn-id: r39745
2009-03-29 19:09:23 +00:00