Commit Graph
7940 Commits
Author SHA1 Message Date
Filippos Karapetis 6f7f6572c4 Fixed invalid memory read in LSL6 hires - kRobot(1) returns an integer
svn-id: r50024
2010-06-18 17:34:34 +00:00
Martin Kiewitz 8a8480c0ca SCI: fix typo when setting EGA palette
svn-id: r50023
2010-06-18 17:20:09 +00:00
Filippos Karapetis 680f7c897a Fixed a problem in kAnimate which occurred when a list was modified by a call (e.g. in KQ1 demo, PQ2)
svn-id: r50022
2010-06-18 15:40:18 +00:00
Filippos Karapetis 5d378574a4 Fixed show_instruments to ignore instruments in Sierra's special MIDI channel 15, and updated the comment regarding PQ2 accordingly (it only has 2 incorrect instruments)
svn-id: r50021
2010-06-18 15:18:14 +00:00
Filippos Karapetis 874eeb2370 Added hints inside validate_arithmetic(), together with some code useful for debugging. Some cleanup
svn-id: r50020
2010-06-18 14:48:39 +00:00
Filippos Karapetis b152f6d68f Added an explanation about the invalid instruments used when using the Adlib driver in PQ2
svn-id: r50019
2010-06-18 14:36:22 +00:00
Martin Kiewitz 562f8a9463 SCI: implementing fading for sci1 only for used channels of the object, fixes lsl1 music issues when going right at the start
svn-id: r50018
2010-06-18 13:36:29 +00:00
Martin Kiewitz 661a170c86 SCI: change error() inside adlib driver ::setPatch() to warning() again, fixing pq2
svn-id: r50017
2010-06-18 13:05:08 +00:00
Martin Kiewitz 919c348c5a SCI: pseudo-implemented 0x72 and 0x73 for kDisplay used by longbow-demo, although sierra sci doesn't support them at all
svn-id: r50016
2010-06-18 13:02:48 +00:00
Filippos Karapetis 543610d4d4 Don't throw a warning when we can't find hires content
svn-id: r50015
2010-06-18 12:15:33 +00:00
Lars Skovlund 8ade66ba13 SCI: Unbreak diskdump console command, maybe others
svn-id: r50014
2010-06-18 10:49:26 +00:00
Max Horn 5a95c2a652 SCI: Doxygenify some comments
svn-id: r50013
2010-06-18 09:37:25 +00:00
Max Horn bb528d894c SCI: Rewrap some overlong comments
svn-id: r50012
2010-06-18 09:37:06 +00:00
Martin Kiewitz 8493edf082 SCI: changing error to warning inside detectHires() for gk1 to work again...
svn-id: r50008
2010-06-18 06:47:16 +00:00
Martin Kiewitz 08ff57cc97 SCI: partially revert r49983 - all of those are not implemented in sierra sci or not even pseudo-valid in there. all of those seem to be script bugs
svn-id: r50007
2010-06-18 05:55:27 +00:00
Martin Kiewitz 8f655615d7 SCI: reverting #49978, it worked correctly. the new values contain the full height/width of the picture (may be much larger cause of scrollable areas) and we actually don't want that. the values before and now contain the height/width of the on-screen picture size - although this may contain 0, 0 for low-res games, but that's fine then
svn-id: r50006
2010-06-18 05:40:12 +00:00
Filippos Karapetis 98944b8171 Added information regarding a FIXME
svn-id: r50002
2010-06-18 02:29:20 +00:00
Filippos Karapetis 773f3bf145 Changed another warning into an error. Cleanup
svn-id: r49995
2010-06-18 02:23:30 +00:00
Filippos Karapetis 0eee4e79bf Changed an assert into a warning with a FIXME (happens in SQ1)
svn-id: r49994
2010-06-18 02:16:00 +00:00
Filippos Karapetis 31930b6d09 Error out on unimplemented kDeviceInfo() calls
svn-id: r49993
2010-06-18 02:09:12 +00:00
Filippos Karapetis 01cb1cf011 Turned more warnings into errors, some cleanup
svn-id: r49990
2010-06-18 02:03:28 +00:00
Filippos Karapetis 8f761de15f Added a new subop of kPalVary (PQ4)
svn-id: r49987
2010-06-18 01:48:56 +00:00
Filippos Karapetis 2d61dd8608 Fixed invalid memory access in SQ6
svn-id: r49986
2010-06-18 01:38:08 +00:00
Filippos Karapetis 7a22e491e3 Marked the KQ1 demo workaround as a workaround
svn-id: r49985
2010-06-18 01:29:07 +00:00
Filippos Karapetis 30ea5f3ad2 Added a workaround for the KQ1 demo (looks like a script bug)
svn-id: r49984
2010-06-18 01:27:25 +00:00
Filippos Karapetis ac4659b92a Added several unimplemented kDisplay subops, as well as a new sound command, found in the demo of Longbow
svn-id: r49983
2010-06-18 01:11:00 +00:00
Walter van Niftrik b453d139d4 SCI: (Temporary?) workaround for firmware bug in common USB-MIDI cables.
svn-id: r49982
2010-06-18 01:09:40 +00:00
Filippos Karapetis d2a9fdae26 Added stubs for kPalVary, subops 2 and 5 (XMAS '92, QFG4 demo)
svn-id: r49981
2010-06-18 00:59:10 +00:00
Filippos Karapetis 949493d141 Fixed invalid memory read in GK1CD
svn-id: r49980
2010-06-18 00:49:55 +00:00
Filippos Karapetis 880e07250e Added warning about unhandled kGraph subop 1 (GK1CD)
svn-id: r49979
2010-06-18 00:37:56 +00:00
Filippos Karapetis 660ae052c8 Fixed a bug in detectHires(), so that it actually works
svn-id: r49978
2010-06-18 00:36:20 +00:00
Filippos Karapetis 39e77edbb7 Process kAddAfter with 4 parameters (Torin's Passage)
svn-id: r49976
2010-06-18 00:05:41 +00:00
Filippos Karapetis 6946167f34 Strict mode: error out on unhandled subops, to note if they actually exist and where they're used
svn-id: r49975
2010-06-17 23:53:30 +00:00
Filippos Karapetis c9c9a21a08 Renamed error -> errorNum to avoid name clashes with error()
svn-id: r49974
2010-06-17 23:52:17 +00:00
Filippos Karapetis db70d66e4a Strict mode: Changed several warnings due to logic bugs into errors. If an error pops up from these ones, please add the game where it occurred and the steps to reproduce the error before turning it into a warning
svn-id: r49973
2010-06-17 23:50:28 +00:00
Filippos Karapetis 9c1ec81d76 Strict mode: Turned several severe errors (almost all detection related) into errors, instead of warnings
svn-id: r49972
2010-06-17 23:45:38 +00:00
Lars Skovlund f977faaf9f SCI: Fix a few errors in PlayVMD comment.
svn-id: r49971
2010-06-17 23:44:01 +00:00
Filippos Karapetis 50c3a087e3 Reduced header dependency
svn-id: r49970
2010-06-17 23:20:39 +00:00
Max Horn b474a72d18 SCI: Remove incorrect gameid check
svn-id: r49969
2010-06-17 23:14:57 +00:00
Max Horn 359be0c066 SCI: Change SciEngine's 'char *getGameID()' to 'Common::String getGameId()'
svn-id: r49968
2010-06-17 23:14:34 +00:00
Max Horn 78cd1aa145 SCI: Remove hack related to compiled kernel signatures.
Also change some things to comply to our code formatting conventions.

svn-id: r49967
2010-06-17 23:13:54 +00:00
Max Horn cfcbdf8656 SCI: Remove selector_name function, some cleanup
svn-id: r49966
2010-06-17 23:13:30 +00:00
Max Horn 337711d321 SCI: Get rid of duplicate _system member in SciEngine
svn-id: r49965
2010-06-17 23:12:59 +00:00
Max Horn 69fb703246 SCI: cleanup scancode rows code
svn-id: r49964
2010-06-17 23:12:38 +00:00
Max Horn 2556ea192c SCI: Turn _modifierStates into member of class EventManager
svn-id: r49963
2010-06-17 23:12:17 +00:00
Max Horn 06997c0da6 SCI: Update FIXME in SegmentManager
* Turn one FIXME into a simple comment
* Rewrap comment to 80 columns
* Turn several warnings into errors

svn-id: r49962
2010-06-17 23:11:56 +00:00
Max Horn fabba55e6d SCI: cleanup
svn-id: r49961
2010-06-17 23:11:34 +00:00
Max Horn a2bcf9ac31 SCI: Rename sciEvent to SciEvent
svn-id: r49960
2010-06-17 23:11:12 +00:00
Max Horn 8e07a1e167 SCI: Moved the event code a little bit around.
* Move sleep() from EventManager to SciEngine
* Rename EventManager methods: get -> getSciEvent, and
  getFromScummVM -> getScummVMEvent
* Make scancode_rows static const
* Turn altify & numlockify from EventManager methods into static
  functions (and comment out the currently unused numlockify)

svn-id: r49959
2010-06-17 23:10:37 +00:00
Lars Skovlund 37434d86ae SCI: PlayVMD(1): Hmmm. Don't print gammaBoost etc if they aren't used
svn-id: r49953
2010-06-17 22:08:07 +00:00