Martin Kiewitz
c536630648
SCI: adding space in kernelmap for workaround table
...
svn-id: r50506
2010-06-29 21:13:19 +00:00
Max Horn
b09996cb5c
SCI: Rewrap yet more comments
...
svn-id: r50505
2010-06-29 20:50:52 +00:00
Martin Kiewitz
7951e3ddcf
SCI: kernelMap cleanup and making it possible to have version (not implemented yet) or platform specific entries - changing signature for kNewWindow - using old dummy-signature for mac-only
...
svn-id: r50504
2010-06-29 20:44:19 +00:00
Filippos Karapetis
3a2ac994d4
Handle empty clip rectangles in GfxView::drawScaled(). Fixes an assert in the first room of the game
...
svn-id: r50503
2010-06-29 20:13:57 +00:00
Filippos Karapetis
42351265f1
Fixed 2 uninitialized reads in SQ6
...
svn-id: r50502
2010-06-29 20:12:42 +00:00
Max Horn
8db0f726c0
SCI: Rewrap more comments
...
svn-id: r50500
2010-06-29 14:55:32 +00:00
Max Horn
1027f870a6
SCI: Add some const qualifiers
...
svn-id: r50499
2010-06-29 14:55:09 +00:00
Max Horn
b743fcc9f5
SCI: Rename listEntry -> 'it' for better readability
...
svn-id: r50498
2010-06-29 14:54:47 +00:00
Max Horn
c8dca083d8
SCI: Simplify List::iterator usage in GfxAnimate
...
svn-id: r50497
2010-06-29 14:54:31 +00:00
Max Horn
32b69ccd9d
SCI: Simplify GfxAnimate code, get rid of _listData
...
svn-id: r50496
2010-06-29 14:54:15 +00:00
Martin Kiewitz
f75a6a6f47
SCI: print out actual and supposed parameter types when having a kernel call signature mismatch
...
svn-id: r50487
2010-06-29 10:39:13 +00:00
Filippos Karapetis
0b470dde63
SCI: Some cleanup of the GC code.
...
The version of push() that pushes arrays inside WorklistManager has been renamed to pushArray(), so that it's more apparent where arrays are pushed.
svn-id: r50486
2010-06-29 09:02:59 +00:00
Filippos Karapetis
316e96df2b
SCI: Removed reg_t_EqualTo, since reg_t already defines an equals operator
...
svn-id: r50485
2010-06-29 09:01:17 +00:00
Filippos Karapetis
9f1320d5cc
SCI: Made the SoundCommandParser a member of the SciEngine class and removed it from the EngineState, since it's static throughout the course of a game
...
svn-id: r50484
2010-06-29 09:00:08 +00:00
Martin Kiewitz
15f9f37d4d
SCI: removing ignoring of channel volume change code from r50463, the lsl5 issue was actually caused by the old volume adjust code that was also causing the issues in gk1
...
svn-id: r50466
2010-06-28 22:26:28 +00:00
Martin Kiewitz
668d820afd
SCI: its lsl5 sound resource 294, not 274 (changed comment only)
...
svn-id: r50465
2010-06-28 22:14:03 +00:00
Filippos Karapetis
ee6aebc780
Don't initialize graphics again when loading
...
svn-id: r50464
2010-06-28 22:08:46 +00:00
Martin Kiewitz
805374ff4e
SCI: ignoring set signal on tick 0 directly in parseNextEvent instead of filtering, also now ignoring channel volume changes on tick 0 (fixes lsl5 fading of sound 274, almost at the end), fixing also fading in gk1 and enabling fading in sci32 again
...
svn-id: r50463
2010-06-28 22:06:19 +00:00
Filippos Karapetis
58732b9df1
SCI: More changes to the code for loading from the launcher
...
- Added support for the LSL2 menu bar object
- We no longer need a reference to the init() selector - it's always the first method of the menu bar object
svn-id: r50462
2010-06-28 22:01:26 +00:00
Filippos Karapetis
0b33cc0dab
Fixed loading of saved games from the launcher
...
svn-id: r50460
2010-06-28 20:58:32 +00:00
Filippos Karapetis
438e670166
Applied patch #3022511 - "qfg4 detection cleanup"
...
svn-id: r50457
2010-06-28 20:31:30 +00:00
Martin Kiewitz
d8e4160f34
SCI: remove clipping of volume inside SciMidiParser::setvolume
...
svn-id: r50456
2010-06-28 20:17:43 +00:00
Martin Kiewitz
473c429b5c
SCI: updated comment about transparent pixels in views
...
svn-id: r50454
2010-06-28 18:10:21 +00:00
Martin Kiewitz
bc77740306
SCI: kAnimate resetting _lastCastCount all the time
...
svn-id: r50453
2010-06-28 18:07:40 +00:00
Martin Kiewitz
06648cb186
SCI: fix regression of r50422, please no refactoring without proper testing - fixes animations in all sorts of games
...
svn-id: r50451
2010-06-28 16:56:15 +00:00
Martin Kiewitz
e857cc623e
SCI: added comment - lsl5 also has too large windows
...
svn-id: r50450
2010-06-28 16:35:20 +00:00
Martin Kiewitz
8410dbab53
SCI: stupid oversight fix r50446, too hot here :P
...
svn-id: r50447
2010-06-28 14:49:54 +00:00
Martin Kiewitz
66fb9e7a90
SCI: fixing valgrind issue in Script::initialiseClasses thx to wjp for valgrind testing
...
svn-id: r50446
2010-06-28 14:46:28 +00:00
Martin Kiewitz
6402d64419
SCI: cleanup of execstack, output of backtrace slightly modified, is now also displaying local calls and exports
...
svn-id: r50445
2010-06-28 14:21:56 +00:00
Max Horn
9b4406fd35
SCI: Some more GC cleanup
...
svn-id: r50443
2010-06-28 12:55:47 +00:00
Max Horn
8ae9774a00
SCI: Turn more warnings into errors.
...
If one of these is triggered for you, you can add an exception to
the error, together with a comment explaining why this exception
is necessary. Ideally after verifying that the cause is a script
bug and not a bug in our code...
svn-id: r50442
2010-06-28 12:29:06 +00:00
Max Horn
4fdbd14a60
SCI: Move a few remaining Script methods to engine/script.cpp
...
svn-id: r50441
2010-06-28 12:28:46 +00:00
Max Horn
4f606cc10d
SCI: Clarify docs of GC related SegmentObj methods
...
svn-id: r50440
2010-06-28 12:28:29 +00:00
Max Horn
b3011faaef
SCI: Make various SegManager const
...
svn-id: r50439
2010-06-28 12:28:12 +00:00
Max Horn
a278c07aa6
SCI: get rid of Script::allocateObject
...
svn-id: r50438
2010-06-28 12:27:48 +00:00
Willem Jan Palenstijn
0f0977535c
Remove CRs
...
svn-id: r50435
2010-06-28 12:13:04 +00:00
Martin Kiewitz
445bfee08c
SCI: add const again to newWidth
...
svn-id: r50434
2010-06-28 12:09:48 +00:00
Martin Kiewitz
6981b943b5
SCI: fix regression of r50424, 2x scaling
...
svn-id: r50433
2010-06-28 12:04:35 +00:00
Max Horn
e5509d38b6
SCI: More comment rewrapping
...
svn-id: r50431
2010-06-28 11:23:16 +00:00
Max Horn
6c0205b104
SCI: Fix DEBUG_GC mode and permanently enable it
...
svn-id: r50430
2010-06-28 11:23:00 +00:00
Max Horn
31b2902714
SCI: Revise GC interface: use Common::Array<reg_t> instead of callbacks
...
This means a little bit more overhead but makes the code much more readable
and understandable.
svn-id: r50429
2010-06-28 11:22:41 +00:00
Max Horn
30218a2c32
SCI: Make Script member vars private; add const qualifiers
...
Only three Script members remain public (for now)
svn-id: r50428
2010-06-28 11:22:20 +00:00
Max Horn
85038e7d6c
SCI: Change warning back to error in Script::initialiseObjectsSci0
...
Instead of turning the error into a warning globally, we now have
code which ignores the error in Script 202 of KQ5 French, but will
keep reporting if it turns up in other places.
svn-id: r50427
2010-06-28 11:21:55 +00:00
Max Horn
12099176f7
SCI: More formatting cleanup
...
svn-id: r50426
2010-06-28 11:21:39 +00:00
Max Horn
1453093391
SCI: Cleanup GfxView code (formatting etc.); also insert some asserts to protect scalingX/Y arrays
...
svn-id: r50425
2010-06-28 11:21:23 +00:00
Max Horn
793d482f4f
SCI: Optimized GfxScreen::scale2x a bit
...
svn-id: r50424
2010-06-28 11:21:07 +00:00
Max Horn
7e0240ab14
SCI: Comment cleanup
...
svn-id: r50423
2010-06-28 11:20:51 +00:00
Max Horn
2c01d10a36
SCI: Remove GfxView::getLoopInfo; add assert to GfxView::getCelInfo
...
The return value of GfxView::getCelInfo was used virtually everywhere
without a check for it being non-NULL. Hence instead of returning
NULL when the loop count is zero, it makes more sense to assert out
(instead of a segfault, or worse, random data being used).
svn-id: r50422
2010-06-28 11:20:33 +00:00
Max Horn
9f48a37671
SCI: Add const qualifiers to many GfxView methods and their return values.
...
This helps to ensure proper data encapsulation.
Also reformatted some overlong comments to 80 chars per line, and
fixed some other code formatting issues.
svn-id: r50421
2010-06-28 11:20:14 +00:00
Max Horn
db2d41a433
SCI: Make src param of GfxScreen::scale2x const
...
svn-id: r50420
2010-06-28 11:19:45 +00:00