Commit Graph
7940 Commits
Author SHA1 Message Date
Martin Kiewitz 7f3ce51031 SCI: little cleanup
svn-id: r51539
2010-07-31 14:29:22 +00:00
Martin Kiewitz 2d76fe0092 SCI: kGameIsRestarting returns 2 when we restored
fixes castle of dr. brain save issue in puzzle room, fixes island of dr. brain save issue when saving in first room

svn-id: r51538
2010-07-31 14:09:42 +00:00
Martin Kiewitz fd7bc29536 SCI: adjusting inside view::getCelRect for sci0early
fixes cels being placed wrongly, sci0early didnt have the z adjust.

svn-id: r51537
2010-07-31 13:13:46 +00:00
Martin Kiewitz fec3ab7bee SCI: updating comment
svn-id: r51536
2010-07-31 12:42:23 +00:00
Martin Kiewitz 3a75d0fbe0 SCI: adding polish lsl1
svn-id: r51535
2010-07-31 12:37:49 +00:00
Martin Kiewitz e40ee138af SCI: kAnimate - limit update of nsRect when scaled
only set nsRect when being drawn later (scaled only), fixes sq5 instant-death in elevator shaft

svn-id: r51534
2010-07-31 08:05:23 +00:00
Martin Kiewitz 9deb52fba6 SCI: fixing stupid typo
svn-id: r51533
2010-07-31 07:37:06 +00:00
Johannes Schickel cc575359df SCI: Whitespace cleanup.
svn-id: r51532
2010-07-31 02:11:05 +00:00
Matthew Hoops 43e82aa895 SCI: Fix walking in GK1 later in the game
The Feature class uninit'd workaround needs to be extended to all levels of inheritance.

svn-id: r51527
2010-07-31 00:54:32 +00:00
Martin Kiewitz 5dac7ba6ba SCI: fix kAddToPic called with view data
and adding workaround for pq2 when showing windows with pictures
change to kAddToPic fixes bad coordinates of cels when restoring the game (should also fix lsl2)

svn-id: r51526
2010-07-31 00:48:03 +00:00
Johannes Schickel fd0f5696a5 SCI: Add comment about stability requirements in makeSortedList.
svn-id: r51523
2010-07-30 23:24:45 +00:00
Johannes Schickel e29d6e681a SCI: Switch to Common::RandomSource.
Since I got no response to my mail to -devel, I just assume that there is
no specific reason for using rand() in SCI.

As explained in my mail to -devel about why SCI uses rand, this might allow
SCI to work with our event recording, when that ever gets finished.

I adapted kRandom so that it also supports negative random numbers. And
furthermore that the toNumber argument is smaller than the fromNumber
argument. I am not sure whether that really happens though, but it should
be safer to have this. I marked that place with an TODO/CHECKME.

svn-id: r51521
2010-07-30 22:47:01 +00:00
Martin Kiewitz 062d9eedce SCI: fixing view scaling code
fixes crash in sq5 with elevator on goliath

svn-id: r51520
2010-07-30 22:44:23 +00:00
Martin Kiewitz 685c124a8e SCI: speed throttler cleanup and iceman comment
svn-id: r51518
2010-07-30 21:29:45 +00:00
Matthew Hoops 75b5ac38fb SCI: Fix saving/restoring games in fan games
The SCI Studio function library incorrectly calls kDeviceInfo with one parameter to get the current device.

svn-id: r51514
2010-07-30 18:45:28 +00:00
Martin Kiewitz 839ba339ed SCI: finally fixing font codes
fixing regressions of r51511&51512 and cleaning up as well - for sq5

svn-id: r51513
2010-07-30 16:55:36 +00:00
Martin Kiewitz 6aa228ccd8 SCI: fixing another text color code issue
(sq5 some dialog boxes again using wrong font in rare cases)

svn-id: r51512
2010-07-30 16:23:09 +00:00
Martin Kiewitz 6dd5dfb7d0 SCI: fixing font code handling in kTextSize
fixes incorrect window proportions in sq5 when hailing ship at clorox II

svn-id: r51511
2010-07-30 16:08:27 +00:00
Martin Kiewitz c785645123 SCI: adding workaround for kSetCursor kq5cd
adding comments as well

svn-id: r51510
2010-07-30 15:26:30 +00:00
Filippos Karapetis cbbafc138b SCI: Updated the op_mod changes and added a link to the original bug report
svn-id: r51509
2010-07-30 15:19:21 +00:00
Filippos Karapetis 5b401215d9 SCI: Added handling of negative numbers to
op_mod for SCI01 and newer games. Fixes the
battlecruiser mini-game in SQ5. Many thanks
to lskovlun, wjp and m_kiewitz for their
joined effort on this issue

svn-id: r51508
2010-07-30 14:56:38 +00:00
Filippos Karapetis c665b9e9a7 Merged the two QFG3 workarounds and the two SQ1 workarounds
svn-id: r51506
2010-07-30 13:29:33 +00:00
Filippos Karapetis 28eea504e9 SCI: Adjusted return value of the script bug workaround in rev #51504 to a bigger number, just in case
svn-id: r51505
2010-07-30 12:46:47 +00:00
Filippos Karapetis 241e76d19d SCI: Fixed script bug #3036263, "LB2CD: Disappearing Journal Entries" by changing the return value of the workarounds made for bugs #3036274 and #3035068. The game scripts perform lt on the uninitialized temp, and if it's smaller than expected they start removing journal entries
svn-id: r51504
2010-07-30 12:40:06 +00:00
Martin Kiewitz 2fc1461f2b SCI: arguments of mag-kSetCursor documented
adding primitive support to just set the cursor to the required view resource, nothing else implemented yet

svn-id: r51501
2010-07-30 08:44:40 +00:00
Martin Kiewitz 034fb5343f SCI: cleaning up kSetCursor
showing warning about unsupported mag-cursor when argc = 10 is used
removing argc = 9 support, must have been a script bug somewhere

svn-id: r51500
2010-07-30 08:21:54 +00:00
Filippos Karapetis a9a0451b15 SCI: Updated some comments related to Freddy Pharkas and silenced warning for kDoAudio subop 13
svn-id: r51499
2010-07-30 07:11:57 +00:00
Filippos Karapetis 7c190074c1 SCI: Added PQ2 1.001.006 from bug report #3028479
svn-id: r51498
2010-07-30 07:05:40 +00:00
Filippos Karapetis c77eefad24 SCI: Added a case for 10 params inside kSetCursorSci11(), thus fixing the crash from bug #3034973 - "PHARKAS: Crash early in game'
svn-id: r51497
2010-07-30 06:18:28 +00:00
Filippos Karapetis d4aa4bc4d4 SCI: Fixed script bug #3036942 - "KQ4SCI demo: Menu crash"
svn-id: r51496
2010-07-30 05:31:20 +00:00
Alejandro Marzini fb4086cadb Merged from trunk, from Rev 50841 to HEAD
svn-id: r51495
2010-07-30 05:28:09 +00:00
Filippos Karapetis ffe7dcaa6b SCI: Fixed script bug #3036918 - "HOYLE3: Uninitialized read for temp 1"
svn-id: r51494
2010-07-30 05:25:09 +00:00
Filippos Karapetis a17e3c4449 SCI: Fixed script bug #3036601 - "LONGBOW: Druid hand code brings up ScummVM console", along with a related bug after giving an answer through the hand code
svn-id: r51486
2010-07-29 23:58:47 +00:00
Martin Kiewitz 2c9d30290e SCI: fixing hoyle 3
hoyle 3 is using kCanBeHere, but it has cantBeHere and canBeHere selectors so our auto detection would fail
it also has a cantBeHere stub in Actor, thus it won't set acc at all. We reset acc because of that before calling cantBeHere selector (!) of the actors (canBeHere isnt used) so that we wont get a collision otherwise because acc is non zero when calling kDoBresen (fixes all sorts of bugs, clone2727 should clean it up :P

svn-id: r51485
2010-07-29 22:52:48 +00:00
Martin Kiewitz df9f4b5bfe SCI: reverting r51479 and adding TODOs for fixing the hoyle issue (fixing this properly should make credits etc. appear and solve all the other issues that clone submitted)
svn-id: r51484
2010-07-29 22:04:23 +00:00
Martin Kiewitz 4101d40957 SCI: finished logkernel command
use 'logkernel DoSound' on to log calls to all kDoSound subfunctions. use 'logkernel DoSoundPlay' to log calls to kDoSound(play)

svn-id: r51483
2010-07-29 21:33:42 +00:00
Martin Kiewitz 1c24f2ca8f SCI: midi hold behaviour fixed
we shouldnt react on hold midi data when no actual hold was called, fixes eq2/amulet problem (bug #3035392)

svn-id: r51482
2010-07-29 21:12:16 +00:00
Filippos Karapetis e9234b61d6 SCI: Fixed Hoyle 3 bugs #3035077, #3035080, #3035081 and #3035242, by using the "completed" case removed in rev #50921 for Hoyle 3
svn-id: r51479
2010-07-29 19:48:17 +00:00
Matthew Hoops bc54fde8e1 SCI: Ignore setAttribute() on any non-existent menu items
This fixes two fan games: Al Pond 2 and Aquarius. The original interpreter did this as well.

svn-id: r51477
2010-07-29 19:08:07 +00:00
Martin Kiewitz 483f25b9e6 SCI: fixing qfg1 workaround
svn-id: r51476
2010-07-29 17:26:56 +00:00
Martin Kiewitz 41ed8b4389 SCI: some subfunction support for logkernel
svn-id: r51475
2010-07-29 17:22:38 +00:00
Filippos Karapetis c61ed6e3aa SCI: Removed the language check from the
KQ5 workaround, as there could be an issue
with other non-English versions, too (e.g. 
the Spanish floppy version)

svn-id: r51472
2010-07-29 15:50:53 +00:00
Filippos Karapetis 123d1f6bf6 Extended the workaround for KQ5 French floppy for the German floppy too. Fixes bug #3035396 - "KQ5: Crash when start the game"
svn-id: r51471
2010-07-29 15:40:09 +00:00
Filippos Karapetis 9b6c78a4fe SCI: Fixed bug #3036331 - "KQ5: Floppy version
crashes after title", together with a related
problem (kRedrawBox is called erroneously with
an additional parameter when any dialog is
closed)

svn-id: r51470
2010-07-29 15:24:19 +00:00
Matthew Hoops a113986dc2 SCI: Add detection for the April 2010 competition template (fan game)
svn-id: r51469
2010-07-29 13:45:52 +00:00
Filippos Karapetis a64131ec0f SCI: Fixed script bug #3036483 - "LSL2: Crash at the ship"
svn-id: r51463
2010-07-29 12:43:33 +00:00
Filippos Karapetis f22821af66 SCI: Added back debug output to sound commands
svn-id: r51460
2010-07-29 10:58:01 +00:00
Martin Kiewitz 6b63c951eb SCI: updating screen within kAnimate as well - fixes pseudo hang in eq1 credits (bug #3036154)
svn-id: r51459
2010-07-29 10:48:54 +00:00
Filippos Karapetis 82bf2437e3 SCI: also break in AvoidPath instead of continuing, when the start point is contained in multiple polygons, otherwise we'll end up in an infinite loop
svn-id: r51458
2010-07-29 09:08:20 +00:00
Filippos Karapetis 5d72193c51 Oops, removed leftover code
svn-id: r51457
2010-07-29 08:03:16 +00:00