Commit Graph
123 Commits
Author SHA1 Message Date
Eugene Sandulenko 22b674777f SCI: Added overried specifiers 2018-03-28 12:35:22 +02:00
Willem Jan Palenstijn 3a933138ce SCI: Avoid buffer overflow in amigamac sound driver
By default, frac_t is interpreted as signed. The resulting range isn't
large enough to store offsets, so we interpret it as unsigned here
instead. Fixes a crash in QfG1/Mac where instrument->loop_size is 49457.
2017-12-03 12:49:11 +01:00
Ruud Klaver 6843870af2 SCI: Set default MT-32 reverb before each sound
Set the default reverb configuration present in either the MT-32
patch data or MT32.DRV of SCI0 games before playing each sound, as
a previously played sound may have changed it.

Also, do not perform a general reverb init, since the start of a
sound will do that now.

Closes gh-1023.
2017-10-04 23:47:21 -05:00
Colin Snover 9ac219648e SCI: Omit SysEx delays when sending to MT-32 emulator
Real MIDI devices, and MT-32 in particular, need delays between
SysEx messages to ensure sufficient time to receive and process
the incoming data buffer. Sending too much data too quickly to
these devices can cause them to crash with a buffer overflow.

The MT-32 emulator, on the other hand, has no problem receiving
SysEx data instantly, so skipping the delays means that games that
send lots of data to the MT-32 will start up much faster.
2017-09-12 20:08:02 -05:00
Colin Snover 90cd56e4b6 SCI32: Fix missing music in MGDX
GM patch data is the same across all SCI32 games.
2017-07-07 13:25:02 -05:00
Colin Snover a233696212 SCI: Update formatting strings to match updated Span API 2017-03-30 14:23:41 -05:00
Colin Snover 31daa956d6 SCI: Implement bounds-checked reads of game resources 2017-03-27 19:42:31 -05:00
Willem Jan Palenstijn 1b1fae6494 SCI: Clean up unnecessary casts 2017-02-26 14:23:36 +01:00
Colin Snover d03508e8ce SCI: Fix buffer overflow in AmigaMac sound driver 2016-12-03 12:21:55 -06:00
Colin Snover bf293fface SCI: Fix non-responsive application warning during sysex transfers
This also fixes the display of the startup LCD message, which had
been delayed until after the sysex transfer was finished.
2016-12-03 12:21:54 -06:00
Eugene Sandulenko 86d6a46fb6 SCI: Plug memory leak 2016-06-07 22:23:23 +02:00
Ori Avtalion 3564032330 JANITORIAL: Reduce audio header dependencies 2016-04-14 16:10:21 +03:00
Filippos Karapetis cdbd7c8add SCI: Use uint32 instead of unsigned int 2016-03-01 01:12:58 +02:00
Martin Kiewitz 0dd760724e SCI32: split up SCI2.1 into EARLY/MIDDLE/LATE
- Detection works via signatures (couldn't find a better way)
- new kString subcalls were introduced SCI2.1 LATE
- kString now has signatures and is split via subcall table
- kString fix, so that KQ7 doesn't crash, when starting a chapter
- Sci2StringFunctionType removed, because no longer needed
2015-12-29 01:44:11 +01:00
Walter van Niftrik 56c0238f9b SCI: Delete OPL when init fails 2015-07-07 20:19:48 -04:00
Walter van Niftrik 82f585871b SCI: Check OPL init return code 2015-07-07 20:19:48 -04:00
Matthew Hoops bed9da8b9d AUDIO: Remove all AudioStream access to OPL 2015-07-07 20:19:47 -04:00
Matthew Hoops 24add3c745 SCI: Use the built-in OPL timer 2015-07-07 20:19:43 -04:00
Matthew Hoops 2e8f9dcec9 AUDIO: Remove the sample rate configuration from the OPL code 2015-07-07 20:19:42 -04:00
Filippos Karapetis ae2be20a20 SCI: Fix bug #6725 - "SCI: LSL5 Mac doesn't launch with MT-32 music"
Thanks to waltervn for his help
2014-10-13 12:21:39 +03:00
Filippos Karapetis 43cb57ba00 SCI: Add comments for the MT-32/GM patch contents 2014-10-13 12:21:39 +03:00
Ben Castricum cb94d1f943 MISC: Fix typo s/Adlib/AdLib/ (only where visible to the user) 2014-08-22 06:40:06 +02:00
Johannes Schickel 09cb06d1fa SCI: Small formatting fix. 2014-07-24 01:23:11 +02:00
Johannes Schickel 8fc7d60feb SCI: Make GPL headers consistent in themselves. 2014-02-18 02:39:37 +01:00
Filippos Karapetis b8eaefbf8a SCI: Silence some false positive warnings - CID 1003539, 1003540, 1003541, 1003542 2013-05-01 01:51:12 +03:00
Willem Jan Palenstijn 430db6719f SCI: Fix confusing use of strncpy 2013-04-17 23:55:01 +02:00
Filippos Karapetis b4df7868a1 SCI: Remove some useless checks in the MIDI driver 2013-03-27 23:06:27 +02:00
Johannes Schickel 89abab97e3 JANITORIAL: Remove trailing whitespaces.
Powered by:
git ls-files "*.cpp" "*.h" "*.m" "*.mm" | xargs sed -i -e 's/[ \t]*$//'
2012-09-26 04:17:55 +02:00
Filippos Karapetis 7824d0e8e9 SCI: Limit the hack used for sound initialization to the Fun Seeker's demo only 2012-09-01 20:17:27 +03:00
Johannes Schickel 56e8268073 SCI: Do not cast away const qualifier. 2012-04-05 00:40:25 +02:00
Tarek Soliman a4798602d7 JANITORIAL: Fix missing whitespace in pointer cast
find -name '*.h' -or -name '*.cpp' | xargs sed -r -i 's@\(([A-Za-z0-9]+)\*\)@(\1 *)@g'

This seems to have caught some params as well which is not undesirable IMO.
It also caught some strings containing this which is undesirable so I
excluded them manually. (engines/sci/engine/kernel_tables.h)
2012-02-15 10:07:10 -06:00
Matthew Hoops 509cc5f4c4 SCI: Add preliminary support for SCI1 early Amiga sound patches
As used by KQ1 and MUMG. Sound still seems a bit off, but it's close.
2011-12-08 20:11:33 -05:00
athrxx 6c23f78cb9 SCI: add Japanese MUMG detection entry and adapt Fm-Towns sound driver 2011-11-05 21:02:05 +01:00
Filippos Karapetis cdedfa3d85 SCI: Removed a duplicate variable assignment 2011-11-04 00:42:37 +02:00
Torbjörn Andersson 884ee96708 SCI: Remove unnecessary semicolon 2011-11-02 21:53:13 +01:00
Filippos Karapetis d6658db7c0 SCI: Fixed unexpected end of file in fmtowns.cpp 2011-11-01 23:20:09 +02:00
athrxx 6a91508475 SCI: add sound driver for KQ5 FM-Towns 2011-11-01 20:31:40 +01:00
Johannes Schickel 5443ef943f SCI: Made some static data const. 2011-09-08 00:35:12 +02:00
Christoph Mallon 23a0f5318c JANITORIAL: Remove trailing empty lines. 2011-08-07 13:53:33 +02:00
Max Horn 88913c0139 ALL: Remove trailing whitespaces
This tries to make our code a bit more compliant with our code formatting
conventions. For future use, this is the command I used:
  git ls-files "*.cpp" "*.h" | xargs sed -i -e 's/[ \t]*$//'
2011-06-20 00:59:48 +02:00
Walter van Niftrik ae4f63a256 SCI: Add more debug output to AmigaMac sound driver 2011-06-07 13:34:59 +02:00
Walter van Niftrik 12366c91e5 SCI: Use Sound debug channel in AmigaMac sound driver. 2011-06-07 01:39:00 +02:00
md5 bd2bfe85c9 SCI: Don't include several debug tables when REDUCE_MEMORY_USAGE is defined 2011-05-13 16:12:52 +03:00
strangerke 69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
Ori Avtalion 9414d7a6e2 JANITORIAL: Reduce header dependencies in shared code
Some backends may break as I only compiled SDL
2011-04-28 15:08:58 +03:00
md5 d28344bb55 SCI: Removed unused variables
Thanks to LordHoto and the trusty -Wunused-but-set-variable option :)
2011-04-27 13:13:35 +03:00
md5 9a987001d4 SCI: Some initial work on supporting patch.005 in KQ1 Amiga 2011-04-15 11:20:07 +03:00
md5 22046d2480 SCI: Added handling for another version of mt32.drv (bug #3285556)
This is used in another version of KQ4 early (0.000.274)
2011-04-13 10:29:24 +03:00
dhewg 23ad90b781 SCI: Replace not required emumidi header 2011-04-02 13:31:53 +02:00
Walter van Niftrik 6501a86095 SCI: Fix default pan value in MIDI driver. 2011-03-27 00:04:28 +01:00