ScummVM/scummvm
1
0
Fork 0
mirror of https://github.com/scummvm/scummvm.git synced 2026-06-20 05:45:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
86,814 Commits 45 Branches 139 Tags
578a6794de9ba7679966fee9aec02c6b2bdbce94
Commit Graph
4076 Commits
Author SHA1 Message Date
Filippos Karapetis 0b4802c24b SCI: Fixed bug #3413020 - "SCI: Longbow: Robin is stuck in the final monk chase scene" 
Special thanks to wjp for his work on bisecting to find the regression and
for checking against the KQ5CD disasm
 2011-09-23 00:22:44 +03:00
Filippos Karapetis b807041ad2 SCI: Ignore invalid pointers if the kernel function signature specifies it 
SCI scripts can send stale pointers to kernel functions (e.g. after
loading a saved game). This is normal in some cases (such as kDisplay
and kGraphRestoreBox), and their signatures are set to allow invalid
pointers.
Thus, in such cases, allow invalid pointers, as the kernel functions
will handle them themselves. Fixes bug #3412002, and properly fixes bugs
#3389579, #3292251, #3308087 and #3056811. Removed a relevant TODO.
 2011-09-22 04:18:13 +03:00
Filippos Karapetis 7f675de855 SCI: Fixed compilation with VM_DEBUG_SEND defined 2011-09-22 04:18:11 +03:00
Johannes Schickel 5443ef943f SCI: Made some static data const. 2011-09-08 00:35:12 +02:00
Filippos Karapetis 41cc1932d2 SCI32: Added an initial skeleton structure for the SCI2 text drawing code 
This includes kCreateTextBitmap, and moves all of the text drawing code
into the new GfxText32 class
 2011-09-03 14:51:51 +03:00
Filippos Karapetis d570b41561 SCI: Fixed bug #3396887 - "SCI: pq2-pc98-jp - Listing of items / Inventory not working" 
Thanks to wjp for his valuable help on this
 2011-08-26 01:25:41 +03:00
Filippos Karapetis 0382e990ec SCI: Fixed QFG3 bug #3377429, by removing the problematic script patch 
for script 23 (bug #3040722).

This script patch messes up the conversation with Manu the monkey later
on in the game, thus it's not correct.
 2011-08-25 03:06:20 +03:00
Filippos Karapetis 3774c38db5 SCI: Added two workarounds for script bug #3389579 2011-08-25 01:49:26 +03:00
Max Horn 529919e20b SCI: Remove dead code 2011-08-08 20:33:42 +02:00
Willem Jan Palenstijn 85a056f382 SCI: Fix kFormat's handling of %c with a 0 argument 
SSCI used a sprintf to handle %c, appending the result to the output,
which is effectively a nop for a zero argument.

This is bug #3368821. Thanks to digitall for tracing it to KFormat
and testing this patch.
 2011-07-18 23:36:56 +02:00
Willem Jan Palenstijn 3e38e6e221 SCI: Restore deleted LSL6 workaround for crash on loading 
This was probably accidentally removed in
194081e7ae. The TODO/CHECKME on it still
applies. Reported in bug #3366329.
 2011-07-13 22:43:21 +02:00
Filippos Karapetis 72da8ef5ad SCI: Applied patch #3357096 with minor modifications 
This prevents a string pointer from getting invalidated under some
circumstances in kString(Dup).
Thanks to lephilousophe for the patch.
 2011-07-07 03:43:06 +03:00
Filippos Karapetis 168ba00ea3 SCI: Fixed script bug #3292327 - "SCI: HOYLE4: Cribbage bug" 2011-06-28 12:56:09 +03:00
Willem Jan Palenstijn bc4691a23e SCI: Fix incorrect usage of sizeof 
Thanks to salty-horse for the reports.
 2011-06-25 21:16:12 +02:00
Littleboy b694a78f62 ANALYSIS: Add static casts to is* functions 
This fixes a potential problem with passing char values that would be sign-extended and yield unexpected results.
See http://msdn.microsoft.com/en-us/library/ms245348.aspx
 2011-06-23 08:52:52 -04:00
Max Horn 88913c0139 ALL: Remove trailing whitespaces 
This tries to make our code a bit more compliant with our code formatting
conventions. For future use, this is the command I used:
  git ls-files "*.cpp" "*.h" | xargs sed -i -e 's/[ \t]*$//'
 2011-06-20 00:59:48 +02:00
Willem Jan Palenstijn 4296ac6d15 SCI: Fix sign in disasm of relative jumps 2011-06-12 02:00:09 +02:00
md5 ece449298d SCI: Fixed script bug #3313962 - "ECOQUEST2 Spanish: Crash near beginning" 2011-06-11 14:34:47 +03:00
md5 eea48434f5 SCI: Changed order of script and room in error messages 
This matches the order in which workarounds are stored in workarounds.cpp
 2011-06-11 14:00:02 +03:00
Max Horn aec2ea9661 ENGINES: Remove some uses of g_engine 2011-06-03 18:21:58 +02:00
Max Horn 11bd6da595 SCI: Switch some char* to Common::String& 2011-06-03 16:16:38 +02:00
Max Horn 477d6233c3 ENGINES: Change 2nd param of Engine::saveGameState to Common::String 2011-06-02 18:31:59 +02:00
Walter van Niftrik 05ac17f7b9 SCI: Fix up start/end points when pathfinding with opt == 0. 
Fixes bug #3304901: "SCI: Freddy Pharkas - Stuck in the brothel door".
 2011-05-31 16:26:38 +02:00
md5 1ea96002b8 SCI: Added a more generalized fix for bug #3306417 2011-05-29 21:12:37 +03:00
Lars Skovlund ff62a6050a Revert "SCI: Don't attempt to modify null/disposed objects." 
This fix for bug #3303802 is a potential cause of unreproducible bugs
in all SCI games that taint savegames.
This reverts commit 48140a012d.
 2011-05-27 13:15:57 +02:00
md5 48140a012d SCI: Don't attempt to modify null/disposed objects. 
These cases occur usually because of script bugs. Fixes script bug
#3303802 - "SCI: PQ1VGA - Crash at the jail"
 2011-05-27 03:06:06 +03:00
md5 28b7cf71a9 SCI: Added a workaround for bug #3308087 - "SCI: SQ1VGA - Engine Abort Upon Loading Ulence Flats Save" 2011-05-27 02:47:48 +03:00
md5 a010884c9b SCI: Fixed bug #3306417 - "LAURA BOW 2: segmentation fault while talking to Dr. Myklos" 2011-05-27 02:32:22 +03:00
Matthew Hoops 9539017ee3 ALL: initialise -> initialize 2011-05-25 11:17:11 -04:00
Matthew Hoops 28301e2bd1 ALL: analyse -> analyze 2011-05-25 10:50:47 -04:00
Matthew Hoops eea482fa43 ALL: behaviour -> behavior 2011-05-25 10:50:46 -04:00
Max Horn 8615cecfe0 SCI: Constify Object::_baseVars 
This may have to be undone if we ever want to start free'ing _baseVars again.
 2011-05-25 16:44:50 +02:00
Willem Jan Palenstijn c01fed7159 SCI: Avoid incrementing lockers of deleted script 
Having a deleted script with non-zero lockers had the side effect of
making the deleted script re-appear in the GC's work list, including
any (deleted) objects in the script.

This should be the root cause of bugs #3299458 and #3295849, so
also delete the workaround added for that in 35086fe1.
 2011-05-13 23:09:04 +02:00
md5 bd2bfe85c9 SCI: Don't include several debug tables when REDUCE_MEMORY_USAGE is defined 2011-05-13 16:12:52 +03:00
md5 c9cef5e971 SCI: Marked the sanity check inside processWorkList() as a workaround 
The sanity check added in rev #35086fe17c fixes the crashes with that
code when an invalid reference is about to be processed, but these
references shouldn't be in the stack at all in the first place, so the
root cause seems to be somewhere else.
 2011-05-13 00:15:41 +03:00
md5 a3c6439a1a SCI: Added workarounds for bug #3292251, instead of patching the script 
This fixes bug #3295853
 2011-05-13 00:10:44 +03:00
md5 35086fe17c SCI: Fixed bugs #3299458 and #3295849 2011-05-12 12:52:12 +03:00
Tarek Soliman 33b1ca2b08 SCI: Fix signature of script patch qfg3DialogCrash (bug #3300241) 2011-05-12 09:33:40 +02:00
strangerke 69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
Ori Avtalion 9414d7a6e2 JANITORIAL: Reduce header dependencies in shared code 
Some backends may break as I only compiled SDL
 2011-04-28 15:08:58 +03:00
Ori Avtalion cd6ee0589d JANITORIAL: Format forward declarations to follow convention 2011-04-28 12:20:34 +03:00
md5 14865cbf9c SCI: Fixed script bug #3292334 - "HOYLE4: Gin Rummy bug" 2011-04-26 19:08:02 +03:00
md5 c24d388468 SCI: Fixed script bug #3292251 - "SCI: QFG3: Script error when buying robe" 2011-04-26 18:24:53 +03:00
md5 1ba3d462d2 SCI: Fixed 2 script bugs in Hoyle 4 - hearts 
This fixes bug #3292333 - "HOYLE4: Hearts bug"
 2011-04-26 13:03:04 +03:00
md5 f752b1b2fc SCI: Fixed several uninitialized variable script bugs in Hoyle 4 Bridge 
This fixes bug #3292332, along with other related issues
 2011-04-26 12:56:11 +03:00
Willem Jan Palenstijn dda6df668a SCI: Avoid (unused) sqrt of a negative number 
This fixes bug #3289799.
 2011-04-21 22:14:05 +02:00
Willem Jan Palenstijn eb8b1a962b SCI: Fix precedence (bug #3087872) 2011-04-20 23:38:28 +02:00
md5 6c4f09c058 SCI: Silenced the warning for kMacPlatform(1) 
This warning produces a lot of spam in the console (e.g. it pops up
whenever the icon bar is opened in Dr. Brain Mac), thus it has been
silenced
 2011-04-15 11:20:05 +03:00
Max Horn 2e095e25f2 ALL: centre -> center 2011-04-14 14:34:28 +02:00
md5 b4051db142 SCI: Extended the script workaround for the sign reading script (bugs #3272735, #3275413) 2011-04-05 10:23:51 +03:00