Commit Graph
287 Commits
Author SHA1 Message Date
Matthew Hoops eea482fa43 ALL: behaviour -> behavior 2011-05-25 10:50:46 -04:00
strangerke 69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
Ori Avtalion 9414d7a6e2 JANITORIAL: Reduce header dependencies in shared code
Some backends may break as I only compiled SDL
2011-04-28 15:08:58 +03:00
Lars Skovlund a55a211ddc SCI32: Reroute kSave(5) to kGetSaveFiles(). Any differences to pre-SCI32
kGetSaveFiles() should be worked out there.
2011-03-09 20:18:34 +01:00
md5 9cc12cfc97 SCI21: kSave(1) is kRestoreGame 2011-03-04 00:25:22 +02:00
md5 49f3f5e1e8 SCI: Fixed a memory leak. Thanks to digitall for finding this using Valgrind 2011-02-26 16:30:47 +02:00
Max Horn c093925763 SCI: Fix (rare) leak in kSaveGame, tweak kFileIOFindNext, cleanup
svn-id: r55867
2011-02-10 13:39:01 +00:00
Max Horn 41121be4d6 GUI: Rename SaveLoadChooser::runModal to runModalWithPluginAndTarget
This avoids hiding an overloaded virtual method, which in turn can
cause weird bugs (see also the next commit).

svn-id: r55815
2011-02-07 22:58:22 +00:00
Filippos Karapetis fc83afc5f2 SCI2.1: Added/documented some functionality used by Shivers 1
- Added kFileIO subop 17 (create save slot)
- Added information about a (probably debug) kernel function used in a puzzle, kCelInfo
- Added some information on two kSave subops
- Added 2 workarounds for uninitialized variables

svn-id: r55158
2011-01-08 10:23:27 +00:00
Filippos Karapetis 32d7e687ee SCI: debugC calls no longer require a debug level of 2 to show output
svn-id: r55086
2011-01-01 12:48:12 +00:00
Filippos Karapetis de2ef2edc0 SCI: Removed the system strings code and replaced it with a much more simplified version, thus greatly simplifying handling of system strings
svn-id: r54805
2010-12-07 00:47:05 +00:00
Filippos Karapetis 77da22290d SCI: kSave case 0 is actually kSaveGame. Based on a patch by lskovlun
svn-id: r54215
2010-11-11 23:51:43 +00:00
Max Horn e27b05ef35 COMMON: Rename String::printf() to String::format()
This is a first step towards getting rid of all uses of regular printf,
fprintf, vprintf, vfprintf, puts, fputs, etc. in our codebase.

The name format() reflects the purpose of the function, and parallels
String.format() in Java, boost::format, and others.

svn-id: r54004
2010-11-01 16:02:28 +00:00
Filippos Karapetis dca3c8d8bf SCI: Play time related changes
- Added support for savegame play time
- Removed obsolete variables for calculating the play time (EngineState::gameStartTime and Console::_enterTime)
- Renamed some variables to camelCase

svn-id: r53974
2010-10-31 01:45:24 +00:00
Torbjörn Andersson c91a07229a JANITORIAL: Removed most punctuation at end of warning() and error()
Our warning() and error() functions always add an exclamation mark
to the end of the message anyway.

svn-id: r52791
2010-09-18 10:55:16 +00:00
Thierry Crozat c073369f0a i18n: Translate Save and Restore buttons in SCI engine
svn-id: r52694
2010-09-12 21:56:37 +00:00
Martin Kiewitz 10a460443b SCI: adding save description, if none was entered
fixes bug #3061964

svn-id: r52637
2010-09-08 16:15:42 +00:00
Martin Kiewitz 4f70b6814b SCI: fix warning
svn-id: r52457
2010-08-30 17:06:11 +00:00
Martin Kiewitz 1067a72769 SCI: adding comments for r52450
svn-id: r52451
2010-08-30 10:18:31 +00:00
Martin Kiewitz 154099d0a4 SCI: check filesize of qfg import files
filter out files that are larger than 1k, actually removes real saved games from the list

svn-id: r52450
2010-08-30 10:14:50 +00:00
Martin Kiewitz 6d7d0ee940 SCI: reverting r52448
broke importing, also savedgames are named "qfg1.0xx", so they werent showed before anyway and ".sav" is not mandatory for exported character files.

svn-id: r52449
2010-08-30 08:47:57 +00:00
Filippos Karapetis 3e6d55aee7 SCI: Only show exported characters in the QFG import screens.
QFG can't import saved games, thus there is no point in including them in the
character import screens.

svn-id: r52448
2010-08-29 23:35:23 +00:00
Martin Kiewitz 2fb722056c SCI: fix warning (thx wjp, thank you not msvc)
svn-id: r52443
2010-08-29 15:23:08 +00:00
Martin Kiewitz 357fb5c604 SCI: fix build
svn-id: r52442
2010-08-29 15:18:24 +00:00
Martin Kiewitz ff7476d9f1 SCI: adding virtual lists for qfg-import rooms
now lists import files of all possible games, adds game title before that, removes game prefixes for all files

svn-id: r52441
2010-08-29 15:13:25 +00:00
Filippos Karapetis 99d2f23ab3 SCI: fixed debug output
svn-id: r52438
2010-08-29 11:10:18 +00:00
Filippos Karapetis 6a058892fb SCI: Throw a warning in QFG import screens for unmatched files
The original SCI games supported up to 12 characters for file names, thus we
use the file name returned as a mask to find the actual file, as we don't
wrap/unwrap save file names in these screens. If no files match, or if more
than 1 files match, throw a warning.

svn-id: r52437
2010-08-29 11:08:27 +00:00
Filippos Karapetis 3f1f894e8e SCI: Added proper handling of QFG exported character files.
Now, QFG2, 3 and 4 may read exported characters from all
other QFG games, like the originals did. Fixes bug
#3054692 - "QFG2/QFG3 Import issues".

svn-id: r52430
2010-08-29 00:17:56 +00:00
Martin Kiewitz f8276a36fb SCI: adjust r52397
actually they return 0:0, when no bytes were read, otherwise they return the destination pointer

svn-id: r52398
2010-08-26 07:31:54 +00:00
Martin Kiewitz c0f81439dc SCI: kFileIOReadString/kFGets return byte count
in sierra sci of read bytes

svn-id: r52397
2010-08-26 07:26:30 +00:00
Willem Jan Palenstijn ca81bdde9b SCI: Return empty string from fgets with maxsize 1
This should fix r3049360 in Hoyle4.

svn-id: r52396
2010-08-25 22:05:10 +00:00
Martin Kiewitz 01a8fc604b SCI: replacing save dialog as well
experimental feature - enable by putting "scireplacedialog=true" inside scummvm section of scummvm.ini

LSL6 currently loses the ability to quicksave, when using the feature. Although i don't see it as a huge loss. That way it's now possible to save to up to 100 slots instead of just 20.

svn-id: r52345
2010-08-24 15:11:53 +00:00
Martin Kiewitz 5fbe5f049b SCI: more work on replacing save dialog
also removing some previous code, because it wont work that way

svn-id: r52342
2010-08-24 14:40:18 +00:00
Martin Kiewitz b192de5423 SCI: changing signature of kRestoreGame
and changing patch code accordingly

svn-id: r52320
2010-08-24 09:11:53 +00:00
Martin Kiewitz d5d8434fd6 SCI: now pausing/unpausing music in replaced restore dialog
dialog will not get replaced in sci32, nor in mother goose. Enable by adding "scireplacedialog" inside scummvm section of scummvm.ini file. Note: this feature is experimental

svn-id: r52318
2010-08-24 09:00:53 +00:00
Martin Kiewitz e93eaa0d95 SCI: some more work on replacing restore dialog
svn-id: r52314
2010-08-23 23:04:07 +00:00
Martin Kiewitz 45a87ffe3f SCI: some work on replacing sierra restore dialog
svn-id: r52305
2010-08-23 19:10:06 +00:00
Martin Kiewitz 7b8add291e SCI: multiple changes for mother goose vga
which is sci1 and sci1.1
fixes bug #3051145
- separating this mother goose from ega and sci2.1
- adding workaround when restoring saved games in these games, games try to calculate restored savedgameid instead of looking it up, we patch this code out and also set the global to the current savedgameid
- adding workaround for scripts checking savedgameid to be below 13 (our savedgameids begin at 100 now)
- changing official range for savedgameids from 1000->1999 to 100->199, otherwise mother goose would have required much larger patches and this range should be fine even if we replace savedgame dialogs later

svn-id: r52301
2010-08-23 16:33:19 +00:00
Filippos Karapetis 23d4177d20 SCI: Check for EOF and errors when reading from a file. Fixes bug #3049360 - "SCI: Bug in file read/write operations"
svn-id: r52298
2010-08-23 12:56:41 +00:00
Matthew Hoops 3677a8a382 SCI: Fix a bug in kFileIOWriteString. The first return statement should go inside the if-statement.
svn-id: r52269
2010-08-22 03:50:42 +00:00
Filippos Karapetis 3faae2a831 Reverted part of r52256, it's not really undefined behavior (the two parts of the bitwise OR aren't reading from the same source)
svn-id: r52258
2010-08-21 13:24:09 +00:00
Filippos Karapetis d986a78834 SCI: Fixed potentially undefined behavior
svn-id: r52256
2010-08-21 13:03:35 +00:00
Filippos Karapetis 849ccc9eab SCI: Changed a warning into a debugC
svn-id: r52220
2010-08-20 07:38:33 +00:00
Martin Kiewitz d42d7ad6c5 SCI: allowing kCheckSaveGame with id 0
qfg2 - when trying to restore from an empty saved game list

svn-id: r51663
2010-08-02 21:44:41 +00:00
Matthew Hoops 75b5ac38fb SCI: Fix saving/restoring games in fan games
The SCI Studio function library incorrectly calls kDeviceInfo with one parameter to get the current device.

svn-id: r51514
2010-07-30 18:45:28 +00:00
Martin Kiewitz 7e545888fd SCI: moving some fileio warnings to debug level
svn-id: r51392
2010-07-27 20:46:12 +00:00
Martin Kiewitz 3cae0f3452 SCI: kCheckFreeSpace support for sci1.1
and possible sci32

svn-id: r51383
2010-07-27 18:45:32 +00:00
Martin Kiewitz c721b4d612 SCI: some changes for kq7
- resetting negative plane left/top
- kSave(0) returns SIGNAL

svn-id: r51281
2010-07-25 19:47:12 +00:00
Filippos Karapetis 9862f3fe24 SCI: Moved the SCI32 kernel functions out of kernel32.cpp and into their respective files
svn-id: r51108
2010-07-21 21:18:21 +00:00
Martin Kiewitz 525794927e SCI: fix regression of r50896, behaviour of kFileIO(readString) is supposed to return the string instead of the size, fixes signature mismatch in hoyle 3
svn-id: r50977
2010-07-18 04:25:57 +00:00