This slows down the Selentic age sound receiver spin rate
when fully depressing either of the turn buttons.
This is a deviation from the original and improves
the users experience.
In the original when the button is fully depressed
the receiver turns so fast that it is impossible
to predict what angle you full be at when you let go.
Fixes #Trac10486.
For 12 Hr format versions, in ScummVM when the hour was set to
what should be 12:XX it was displayed as 0:XX.
This differs with the original English versions which displays
the 12:xx.
I verified this fix in both Myst ME and Myst English CD.
* Keep playing the previously running background sound while playing the
flyby.
* Don't play the flyby after loading a save.
* Play the flyby before both linking sounds.
Fixes#10482, Fixes#10483.
This commit introduces the following changes:
1. Graphics::loadThumbnail()
Now returns a boolean and takes a new argument skipThumbnail which
defaults to false. In case of true, loadThumbnail() reads past the
thumbnail data in the input stream instead of actually loading the
thumbnail. This simplifies savegame handling where, up until now,
many engines always read the whole savegame metadata (including
the thumbnail) and then threw away the thumbnail when not needed
(which is in almost all cases, the most common exception being
MetaEngine::querySaveMetaInfos() which is responsible for loading
savegame metadata for displaying it in the GUI launcher.
2. readSavegameHeader()
Engines which already implement such a method (name varies) now take
a new argument skipThumbnail (default: true) which is passed
through to loadThumbnail(). This means that the default case for
readSavegameHeader() is now _not_ loading the thumbnail from a
savegame and just reading past it. In those cases, e.g.
querySaveMetaInfos(), where we actually are interested in loading
the thumbnail readSavegameHeader() needs to explicitely be called
with skipThumbnail == false.
Engines whose readSavegameHeader() (name varies) already takes an
argument loadThumbnail have been adapted to have a similar
prototype and semantics.
I.e. readSaveHeader(in, loadThumbnail, header) now is
readSaveHeader(in, header, skipThumbnail).
3. Error handling
Engines which previously did not check the return value of
readSavegameHeader() (name varies) now do so ensuring that possibly
broken savegames (be it a broken thumbnail or something else) don't
make it into the GUI launcher list in the first place.
In older releases of Myst the flyby video had the play on card change
flag set to true, causing the bug. As a workaround patch the resource to
mach newer releases.
Fixes#10472.
Otherwise the movie position is zero which leads the comparison with the
stored opcode position to always be false.
Fixes#10426, a regression from cf1171d4d9.
When videos are skipped, they would sometimes not quite be seeked to the
last frame. In that case, when they are played again without being
restarted, they would end immediatly.
Now videos are automatically rewinded when they end or are skipped so
that they always start from the beginning when played again.
Fixes#10389.
This flag is removed for a few reasons:
* Engines universally set this flag to true for widths > 320,
which made it redundant everywhere;
* This flag functioned primarily as a "force 1x scaler" flag,
since its behaviour was almost completely undocumented and users
would need to figure out that they'd need an explicit non-default
scaler set to get a scaler to operate at widths > 320;
* (Most importantly) engines should not be in the business of
deciding how the backend may choose to render its virtual screen.
The choice of rendering behaviour belongs to the user, and the
backend, in that order.
A nearby future commit restores the default1x scaler behaviour in
the SDL backend code for the moment, but in the future it is my
hope that there will be a better configuration UI to allow users
to specify how they want scaling to work for high resolutions.
The Steam version is a DVD version, but also has files from the CD
version in the data folder. We need to load only the files from the DVD
version to prevent data inconsistencies.
Also check on startup that all the required datafiles are present.
Possibly fixes#10052.
David Fioramonti
Eugene Sandulenko
Bastien Bouclet
Adrian Frühwirth
rootfather
Thierry Crozat
Colin Snover
Torbjörn Andersson