Commit Graph
166 Commits
Author SHA1 Message Date
Ori Avtalion 3564032330 JANITORIAL: Reduce audio header dependencies 2016-04-14 16:10:21 +03:00
Matthew Hoops bed9da8b9d AUDIO: Remove all AudioStream access to OPL 2015-07-07 20:19:47 -04:00
Matthew Hoops 5803dffead KYRA: Use the built-in OPL timer 2015-07-07 20:19:43 -04:00
Matthew Hoops 2e8f9dcec9 AUDIO: Remove the sample rate configuration from the OPL code 2015-07-07 20:19:42 -04:00
Matthew Hoops f1f29302f5 AUDIO: Remove the legacy OPL API 2015-07-07 20:19:42 -04:00
Torbjörn Andersson 6d08055db3 KYRA: Update comment since the file it pointed to moved
Also, ScummVM does have a more modern FMOPL implementation now, so
there's no need to bring up other implementations.
2015-05-21 22:49:29 +02:00
Johannes Schickel 183f8eea43 KYRA: Slight cleanup. 2014-08-24 00:57:39 +02:00
Johannes Schickel 2f547a887c KYRA: Constify base type for some pointers in AdLibDriver. 2014-08-24 00:57:39 +02:00
Johannes Schickel c5dfe1d917 KYRA: Add safety checks for getProgram/getInstrument return values.
This fixes a crash in Hand of Fate when scaring off the rat by using the
swampsnake potion on Zanthia. This crash is timing sensitive since the game is
stopping the offending sound resource at this point. If it still gets to the
instruction setting up an invalid instrument, it will crash ScummVM with in
invalid read.
2014-08-24 00:57:39 +02:00
Johannes Schickel 3612f88025 KYRA: Extend safety check inside AdLibDriver::getProgram.
This also removes an TODO and replaces it with a comment explaining this
safety check.
2014-08-24 00:52:34 +02:00
Johannes Schickel b79c2156d0 KYRA: Make GPL headers consistent in themselves. 2014-02-18 02:39:35 +01:00
Johannes Schickel 8d5b4b75d4 KYRA: Make all hex constants use uppercase letters.
Done with:
git ls-files "*.cpp" *".h" | xargs sed -i -e 's/0x\([0-9a-f]*\)/0x\U\1/g'
2013-01-09 06:01:28 +01:00
Johannes Schickel f361a7d624 KYRA: Make Sound::hasSoundFile const again. 2012-11-23 02:50:20 +01:00
athrxx 93e69aa4da KYRA: clean up audio resource handling
(this was really ugly, now it's somewhat less ugly)
2012-11-11 19:14:31 +01:00
athrxx eaa5d50c3f KYRA: (EOB) - add basic distinction between music and sound effects
(The original code of the DOS version does not distinguish here, but
we do it anyway so as to make more sense of the GMM volume settings)
2012-01-06 14:45:38 +01:00
athrxx 0aa3238523 KYRA: (EOB/LOL) - rename some vars
(all cases of Eob to EoB, all cases of Lol to LoL, all cases of LolEobCommon to RpgCommon)
2011-12-26 16:18:16 +01:00
athrxx 814c78e84e KYRA: (AdLib Driver) - fix queue handling for Eob
Huge numbers of sound effects get started as soon as a couple of monsters are around. If we start dropping sound when the queue is full, we won't have any sounds in these situations, but we'll get tons of useless warnings instead.
2011-12-26 16:18:10 +01:00
athrxx 2bcae2451a KYRA: (AdLib Driver) - prevent squashing of sounds during halt track execution
This patch makes sure that the stopping track (track 0) does not squash sounds which get queued during the execution of the stopping track. This seems to be a hardware problem (original driver implementation not suitable for modern machines).
2011-12-26 16:18:10 +01:00
athrxx 2da431aa65 KYRA: (AdLib Driver) - increase versions and add necessary EOB modifications 2011-12-26 16:18:09 +01:00
athrxx 93321ca485 KYRA: (AdLib Driver) - fix secondary effect 2011-12-26 16:18:09 +01:00
athrxx 86a8f694c0 KYRA: (AdLib Driver) - rename some variables to make more sense 2011-12-26 16:18:09 +01:00
athrxx 4098feff57 KYRA: (AdLib Driver) - allow sound trigger query 2011-12-26 16:18:09 +01:00
athrxx f2a1ff3f78 KYRA: (AdLib Driver) - fix invalid memory write issue 2011-12-26 16:18:09 +01:00
athrxx 77a81a80b4 KYRA: (AdLib Driver) - implement sound effects volume
(also make internal driver version more flexible)
2011-12-26 16:18:09 +01:00
Johannes Schickel a588d6e3e2 KYRA: Add another delay for new tracks in the AdLib driver.
This is to play really safe and to avoid messing up of sound data.
2011-10-29 02:50:52 +02:00
Johannes Schickel 488fb5c14b KYRA: Fix haltTrack and beginFadeOut for AdLib driver.
Formerly the were not executed properly when the sfx output was disabled.
2011-10-29 02:40:50 +02:00
Johannes Schickel 8ea2d5dbb1 KYRA: Simplify AdLib output code a bit.
This might cause nasty regressions, since it changes the way sounds are
started. On the other hand it gets rid of the low level driver interface
which was implemented before. And it should be a bit better secured against
race conditions.
2011-10-29 02:37:44 +02:00
Johannes Schickel d0bc84d5b7 KYRA: Implemented LoL style volume control in AdLib output. 2011-10-29 01:00:18 +02:00
Johannes Schickel 6da0549133 KYRA: Fix minor bug in AdLibDriver::primaryEffect1. 2011-10-02 02:17:59 +02:00
Johannes Schickel a3a40c4a6f KYRA: Fix bumping into a wall AdLib SFX in Lands of Lore. 2011-10-02 01:49:27 +02:00
Johannes Schickel 88fa659ace KYRA: Name another variable in the AdLib output code. 2011-10-02 00:13:41 +02:00
Johannes Schickel 2dd85c0cad KYRA: Some minor cleanup. 2011-10-02 00:13:41 +02:00
Johannes Schickel 1fa858d339 KYRA: Made some more static data const. 2011-09-08 00:33:10 +02:00
Christoph Mallon 23a0f5318c JANITORIAL: Remove trailing empty lines. 2011-08-07 13:53:33 +02:00
Matthew Hoops 9539017ee3 ALL: initialise -> initialize 2011-05-25 11:17:11 -04:00
strangerke 69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
Johannes Schickel 7d03da14cb KYRA: Clean up of header includes. 2011-04-28 15:39:57 +02:00
Johannes Schickel 64c4e65201 KYRA: Enforce use of American English in comments. 2011-04-14 14:03:07 +02:00
Max Horn 42ab839dd6 AUDIO: Rename sound/ dir to audio/
svn-id: r55850
2011-02-09 01:09:01 +00:00
Johannes Schickel 607920c869 KYRA: Fix some code errors reported by ICC (i.e. subclasses not overwriting methods by missing a const.)
svn-id: r53911
2010-10-28 23:56:36 +00:00
Johannes Schickel feff6fecdf KYRA: Cleanup.
svn-id: r52340
2010-08-24 13:41:24 +00:00
Johannes Schickel 0fe2ba6a0d Some more enforcement of our formatting conventions in KYRA too.
svn-id: r49069
2010-05-17 23:29:44 +00:00
Max Horn a1840bd573 AUDIO: Rename Mixer::playInputStream to playStream
svn-id: r48637
2010-04-12 09:14:17 +00:00
Johannes Schickel cf85c0b318 Fix bug #2985387 "KYRA1: Crash at the end of game".
svn-id: r48617
2010-04-11 15:05:26 +00:00
Johannes Schickel 0d995c5920 Rename all "Adlib" uses to "AdLib" to match the real name of the sound card / company.
Check this for reference:
http://en.wikipedia.org/wiki/Ad_Lib,_Inc.
http://www.crossfire-designs.de/images/articles/soundcards/adlib.jpg (note the upper left of the card)

This commit does not touch "adlib" and "ADLIB" uses!

Also it does not update all the SCUMM detection entries, which still use "Adlib".

svn-id: r47279
2010-01-12 21:07:56 +00:00
Max Horn f720d99b0a Switch Mixer::playInputStream to use DisposeAfterUse::Flag
svn-id: r47182
2010-01-08 22:09:43 +00:00
Johannes Schickel c671c17258 Use Common::StackLock.
svn-id: r46870
2010-01-02 00:54:11 +00:00
Johannes Schickel 8817d6eeb5 Merge update_nop1 and update_nop2.
svn-id: r46860
2010-01-01 22:33:45 +00:00
Johannes Schickel 82b4b65bdc - Fix out of bounds array access.
- Add some asserts in output related functions

svn-id: r46859
2010-01-01 22:26:26 +00:00
Johannes Schickel 671cc15bd1 - Add some asserts
- Renamed snd_unkOpcode3 to snd_stopChannel
- Cleanup

svn-id: r46855
2010-01-01 21:59:11 +00:00