Commit Graph
42 Commits
Author SHA1 Message Date
Johannes Schickel 18193d170e Revert "KYRA: Plug memory leak"
This reverts commit 9909cc615d.

This will likely cause invalid memory reads because it frees the last output
buffer which is used to keep files in memory. There is a possible memory leak
here, when the input data is not well formed. However, fixing this takes some
more effort than the solution in the reverted commit.
2016-05-15 15:48:17 +02:00
Eugene Sandulenko 9909cc615d KYRA: Plug memory leak 2016-05-15 13:14:37 +02:00
Johannes Schickel b79c2156d0 KYRA: Make GPL headers consistent in themselves. 2014-02-18 02:39:35 +01:00
Johannes Schickel 8d5b4b75d4 KYRA: Make all hex constants use uppercase letters.
Done with:
git ls-files "*.cpp" *".h" | xargs sed -i -e 's/0x\([0-9a-f]*\)/0x\U\1/g'
2013-01-09 06:01:28 +01:00
Johannes Schickel 9b51b138db KYRA: Some formatting fixes. 2011-12-26 21:34:22 +01:00
athrxx 540d081a6f KYRA: (EOB) - initial code base commit 2011-12-26 16:18:10 +01:00
Andrea Corna a6ec4f70da COMMON: Make more members of Archive constant. 2011-12-13 17:55:57 +01:00
strangerke 69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
Max Horn 0ce2ca4e00 COMMON: Replace MKID_BE by MKTAG
MKID_BE relied on unspecified behavior of the C++ compiler,
and as such was always a bit unsafe. The new MKTAG macro
is slightly less elegant, but does no longer depend on the
behavior of the compiler.
Inspired by FFmpeg, which has an almost identical macro.
2011-04-12 16:53:15 +02:00
Max Horn 2180b2d6b5 COMMON: Split common/stream.h into several headers
svn-id: r54385
2010-11-19 17:03:07 +00:00
Max Horn e27b05ef35 COMMON: Rename String::printf() to String::format()
This is a first step towards getting rid of all uses of regular printf,
fprintf, vprintf, vfprintf, puts, fputs, etc. in our codebase.

The name format() reflects the purpose of the function, and parallels
String.format() in Java, boost::format, and others.

svn-id: r54004
2010-11-01 16:02:28 +00:00
Torbjörn Andersson 54b2a8c98d JANITORIAL: Cleanup (mostly whitespace)
svn-id: r53161
2010-10-12 04:19:58 +00:00
Johannes Schickel c23f597f50 KYRA: Cleanup.
svn-id: r52348
2010-08-24 15:48:43 +00:00
Johannes Schickel 51939fe743 KYRA: Implement new handling of KYRA3's TLK files.
This speeds up loading of KYRA3's TLK files by a lot, since only the index
table will be load now. This should help the startup time for KYRA3 when
playing from CD or other slow storages.

svn-id: r52347
2010-08-24 15:48:17 +00:00
Johannes Schickel 501d7cbb84 KYRA: Simplify PAK/INS/TLK loading.
This also reduces the number of seeks done while loading TLK files.

svn-id: r52346
2010-08-24 15:47:53 +00:00
Johannes Schickel 2985d27e40 KYRA: Cleanup.
svn-id: r52200
2010-08-19 02:38:42 +00:00
Johannes Schickel 0fe2ba6a0d Some more enforcement of our formatting conventions in KYRA too.
svn-id: r49069
2010-05-17 23:29:44 +00:00
Johannes Schickel aed02365ec Strip trailing spaces/tabs.
svn-id: r47541
2010-01-25 01:39:44 +00:00
Max Horn 0cf53b025d Move DisposeAfterUse::Flag from Common to global namespace, and into a new header common/types.h
svn-id: r47180
2010-01-08 22:07:35 +00:00
Johannes Schickel 0e5de0c36d Fix for bug #2905439 "AmigaOS: Recent Kryandia changes broke compilation".
svn-id: r46178
2009-11-28 20:13:45 +00:00
Florian Kagerer ac19f4146b LOL/Floppy: fixed crash
svn-id: r46177
2009-11-28 20:08:20 +00:00
Johannes Schickel 6fb79b8b3c Fix compilation on 64bit systems.
svn-id: r46176
2009-11-28 18:58:55 +00:00
Florian Kagerer 5905b9e479 LOL: completed support for floppy installer files
svn-id: r46174
2009-11-28 18:40:37 +00:00
Max Horn 2bbf708dea Introduced new type Common::DisposeAfterUse::Flag
svn-id: r45233
2009-10-18 19:41:59 +00:00
Max Horn f242266f6d Change a couple places from 'end of namespace' to 'End of namespace', for consistency
svn-id: r44634
2009-10-04 21:26:33 +00:00
Johannes Schickel 64e6c596c7 Formatting.
svn-id: r40991
2009-05-29 12:52:03 +00:00
Johannes Schickel f1079ef624 Cleanup.
svn-id: r39421
2009-03-15 14:55:48 +00:00
Johannes Schickel 0e8bd97367 Fix for loading Kyra1 Amiga PAK files.
svn-id: r39420
2009-03-15 14:48:08 +00:00
Max Horn 5181546c63 Rewrote Common::List iterator code to ensure const correctness is preserved.
We tried to implement the list iterators in a clever way, to reduce code
duplication. But this is essentially impossible to do properly, sadly --
this is one of the places where the ugly drawbacks of C++ really show.
As a consequence, our implementation had a bug which allowed one to
convert any const_iterator to an iterator, thus allowing modifying
elements of const lists.

This rewrite reintroduces code duplication but at least ensures that no
const list is written to accidentally.

Also fix some places which incorrectly used iterator instead of const_iterator
or (in the kyra code) accidentally wrote into a const list.

svn-id: r39279
2009-03-09 22:26:02 +00:00
Max Horn 2d866c0483 Renamed Kyra's Resource::getFileStream to createReadStream
svn-id: r36022
2009-01-23 04:57:18 +00:00
Max Horn 14c5bbbccf Renamed Archive::openFile to createReadStreamForMember
svn-id: r36021
2009-01-23 04:45:44 +00:00
Max Horn 9861afd8fd Renamed ArchiveMember::open -> createReadStream, and made it a cv member (const); same for Archive::openFile
svn-id: r36020
2009-01-23 04:36:18 +00:00
Johannes Schickel bf08c82054 Fixed bug in PAK link list code, now file links are correctly initialized.
svn-id: r35902
2009-01-18 16:49:03 +00:00
Eugene Sandulenko 696897b058 Whoa! Removing trailing spaces.
svn-id: r35648
2009-01-01 15:06:43 +00:00
Florian Kagerer 83194b2188 KYRA: fix mt-32 sysex loading for LOL floppy
svn-id: r35434
2008-12-19 07:32:08 +00:00
Max Horn a28b531ed0 Added ArchiveMember::getDisplayName() method; changed ArchiveMember::getName() to always return a name compatible with Archive::openFile()
svn-id: r35139
2008-11-21 12:17:35 +00:00
Johannes Schickel 282ebbb0e5 Commit of patch #2207782 "ARCHIVE: New method 'getMember'".
svn-id: r34871
2008-11-01 12:49:29 +00:00
Florian Kagerer e25265425d - fix installer file support for Kyra 2 and 3
- fix bug in pc98 audio driver

svn-id: r34791
2008-10-13 06:29:14 +00:00
Johannes Schickel f3469eae94 Check all 'kyra.dat' files in setup paths instead of only the first one found.
svn-id: r34735
2008-10-03 18:18:42 +00:00
Johannes Schickel e417471177 Committed slightly modified patch #2034983 "Case-insensitivy and directory handling for engines".
svn-id: r34734
2008-10-03 16:57:40 +00:00
Max Horn 655ce26b3f Big patch changing the signature of various Stream methods (some ports may need to be slightly tweaked to fix overloading errors/warnings)
svn-id: r34514
2008-09-13 16:51:46 +00:00
Johannes Schickel 7aaf6139e2 Moved Kyra resource code to a SearchSet/Archive based implementation, this removes dependencies on Common::File.
svn-id: r34428
2008-09-07 21:46:37 +00:00