Colin Snover
972c453986
BBVS: Remove all bit shifts of potentially negative integers
...
Previous patches that removed shifts of constant negative values
to eliminate UB were valid, but did not correct all places where
this engine was potentially bit shifting negative values. There is
no reason to not just use multiplication and division and let the
compiler make the right choice for optimisation for an
architecture, so that is what this patch does.
2017-11-10 09:57:03 -06:00
Colin Snover
cc12c878b7
BBVS: Fix UB shifting negative signed integers
...
These shifted values are replaced with their literal equivalents
as would be calculated on an x86.
2017-09-11 08:13:58 +02:00
Eugene Sandulenko
89a9c452ed
BBVS: Remove guitar minigame strings from translation.
...
Although they're shown in our GUI, they were not supposed to be
translatable, rather extracted from the original executable
2016-11-24 11:34:14 +01:00
Eugene Sandulenko
fab199d37e
JANITORIAL: Make GPL headers uniform
2016-09-03 12:46:38 +02:00
Ori Avtalion
253e18c440
JANITORIAL: Reduce GUI header dependencies
2016-04-14 13:30:14 +03:00
Willem Jan Palenstijn
5d6f924fa6
BBVS: Fix typo in array size
...
Ideally this shouldn't use a hardcoded constant at all...
Thanks to WindlePoons for debugging.
2015-11-14 22:43:16 +01:00
Eugene Sandulenko
81a4359eee
BBVS: Implement file chooser for Air Guitar minigame
2015-11-07 13:26:55 +01:00
johndoe123
aa518306b8
BBVS: Fix out-of-bounds array access in air guitar minigame as reported by Coverity
2015-02-01 17:21:34 +01:00
johndoe123
a48a6ad30e
BBVS: Implement loading and saving in the air guitar minigame
2015-01-29 13:11:03 +01:00
Filippos Karapetis
88e5998ee5
BBVS: Remove trailing whitespace
2014-10-28 16:24:45 +02:00
Johannes Schickel
f2685a8876
BBVS: Use floating point constants of type float.
2014-06-02 01:00:15 +02:00
Matthew Hoops
d5b5d4b545
BBVS: Silence gcc conversion warnings
2014-06-01 17:28:34 -04:00
Strangerke
cf3bf73cde
BBVS: Use a boolean for _gameResult. Adapt function declarations accordingly
2014-02-28 07:45:16 +01:00
Strangerke
79bad44750
BBVS: Initialize a pointer to nullptr instead of 0
2014-02-28 07:40:46 +01:00
Strangerke
7cd6b8b898
BBVS: Fix uninitialized variables in Minigame
2014-02-28 07:39:24 +01:00
Strangerke
42c159d017
BBVS: Fix out of bounds access in air guitar mini game
2014-02-28 07:21:46 +01:00
Strangerke
6cd0d012b1
BBVS: remove useless check in updateIndicator()
2014-02-23 07:45:30 +01:00
Strangerke
0958ac9b7f
BBVS: Silent some CppCheck warnings
2014-02-22 18:26:35 +01:00
johndoe123
608485729b
BBVS: Make kAnimationsTbl and kObjKindAnimTables const in BBAnt minigame
2014-02-16 00:37:14 +01:00
johndoe123
3aba8da16b
BBVS: Remove Point type and use BBPoint instead in BBAnt minigame
2014-02-16 00:28:43 +01:00
johndoe123
882cf2f5ba
BBVS: Fix const char string arrays
2014-02-16 00:27:00 +01:00
johndoe123
3847654bcd
BBVS: Fix include guard and include guard name comments for endifs
2014-02-15 23:48:08 +01:00
johndoe123
9263bb9eb3
BBVS: Fix formatting (use tab instead of spaces)
2014-02-15 23:43:22 +01:00
johndoe123
86b5192d1b
BBVS: Use spaces instead of tabs for formatting
2014-02-15 23:39:05 +01:00
johndoe123
8fcfe61003
BBVS: Add delayMillis to update loops to save some cpu time
2014-01-30 20:16:33 +01:00
johndoe123
24fd658795
BBVS: Add loading/saving of minigame hiscores
2014-01-29 13:27:49 +01:00
johndoe123
ef55f5b774
BBVS: Replace minigame flags parameter
2014-01-29 13:27:48 +01:00
johndoe123
11a5807110
BBVS: Remove obsolete code in BbAnt minigame
2014-01-29 13:27:48 +01:00
johndoe123
5f4fc9a1dd
BBVS: Initial commit
2014-01-29 13:27:47 +01:00