- Changing rotation back to "<default>" had no effect
- Unchecking "Override" checkbox did not change rotation
- "Override" checkbox initialization was not affected by rotation
Fixes or works around https://bugs.scummvm.org/ticket/15243 . This may
not be appropriate, but it avoids a segfault (nil _aspectCheckbox) for
me when I've specified `--disable-aspect` and switch from SDL to
OpenGL, anyway.
We were disabling way too much things when the cloud was disabled,
e.g. icon packs are now available when cloud is disabled.
Also, now we enable local server when SDL_Net is present, even if the
cloud is disabled.
The backend options tab is for backend specific options. The backends
supporting it implements the function buildBackendOptionsWidget which
defines the options elements and layout.
The backend options tab layout may differ depending on the current
domain. The options in the "Global options" tab applies to all games
while the options in the "Game options" tab only applies to a specific
game. The options in the "Global config" options tab can be set during
game play. Some options, e.g. graphics cannot be changed while running
the game while backend options can.
The first version of the backend options tab was a non-scrollable
container. The "Game options" tab includes an "Override Global options
checkbox" which, when checked, enables the options defined by the
backend.
The number of iOS7 backend options increased rapidly which caused some
options to fall outside the tab container on screens with limited
space in height. An attempt to fix that was made by the same creator
of this commit in the commit: 8db736f155
The attempt was not perfect in any way, else this commit wouldn't
exist... The "Override Global options checkbox" on the "Game options"
tab became misplaced. It also required the backend to add padding
to GUI elements it shouldn't know of.
To fix this properly put the backend options tab in a single Scroll-
Container. This way the "Override Global options checkbox" can be
properly placed related to the backend options widgets. All backend
options can also be accessed in every backend options tab layout,
Global options, Game options and Global config thanks to the scrollbar
automatically provided by the ScrollContainer.
Update all themes with the new layout.
The same condition was scattered around in the code to switch between
normal labels and images and their lowres counterparts. Factorizing
that condition in a function will allow changing it easily.
When calling any of:
- Widget::setEnabled
- EditTextWidget::setEditString
- EditableWidget::setEditString
- StaticTextWidget::setLabel
there is no need to call neither GuiManager::scheduleTopDialogRedraw nor
Widget::markAsDirty afterwards -- they set up the call by themselves.
Also, refactor a couple of code blocks into calling just
GuiManager::redrawFull as it does the same thing.
- remove Options widgets of the old wizard;
- add CloudConnectionWizard dialog;
- remove old widgets and add new ones in the layouts;
- update local webserver to allow passing a callback that needs to be called if storage was connected via /connect_cloud.
Filippos Karapetis
sluicebox
Eugene Sandulenko
Vladimir Serbinenko
Tarek Soliman
scummvmuser
Le Philousophe
Cameron Cawley
athrxx
Matthew Jimenez
Lars Sundström
elasota
Thierry Crozat
AndywinXp
Ankush Dutt
elasota
antoniou79
Miro Kropacek
Alexander Tkachov
D G Turner