This is actually used for images without Rgn as well. The new code
should be easier to understand, and it handles all of the black and
white images from the Mac versions of Loom, Indy 3, Indy 4, MI1, and
MI2. It's still unfortunate - and perhaps unnecessary - that we had two
different decoders for Rect/Rgn, but I'm not comfortable modifying the
old one. Maybe later.
The version number decides if opcodes are 1 or 2 bytes, but we don't
know for sure which it is until the first opcode has been handled. But
the way the o_versionOp1 opcode is defined, we should recognize it it
regardless, so going from assumed version 2 to confirmed version 1
should be no problem. I do not have any test case to confirm this,
though.
What I do know is that going from assumed version 1 to confirmed version
2 does not work, so we want _version to be well defined (even if wrong)
from the beginning.
Apple's desktop operating system was formerly called "Mac OS X" and "OS X", but since 2016 it has been called "macOS" (starting with version 10.12).
Changing across all comments and documentation to use this current terminology, except in cases where the historical versions are explicitly referenced. No code changes are made; we should consider changing those in future PRs.
Mostly done using the following Ruby script:
(Dir.glob('**/*.cpp') + Dir.glob('**/*.h')).each do |file|
s = File.read(file, encoding: 'iso8859-1')
t = s.gsub(/(([\w_.\[\]]+)\s*=\s*new\s+\S+?\[[^\]]+?\](?!\())([^\{\}]*?)\n\s+memset\(\s*\2\s*,\s*0\s*,[^;]*;/m, '\1()\3')
if t != s
File.open(file, 'w') { |io| io.write(t) }
end
end
Add limited support for unpacked PICT bits which FPFP Mac requires.
SCI games use packed PICT bits unless an image is less than 8 bytes
per row in which case they can't be packed, like FPFP's shovel icon.
Fixes bug #7059 which prevents the game from being completed.
neuromancer
Cameron Cawley
Matthew Jimenez
Eugene Sandulenko
Torbjörn Andersson
AndywinXp
never
Pragyansh Chaturvedi
Donovan Watteau
Thunderforge
Orgad Shaneh
D G Turner
sluicebox
Bastien Bouclet
Matthew Hoops