diff --git a/devtools/create_engine/create_engine.cpp b/devtools/create_engine/create_engine.cpp index ba115c068b8..42c89f375d6 100644 --- a/devtools/create_engine/create_engine.cpp +++ b/devtools/create_engine/create_engine.cpp @@ -47,7 +47,7 @@ static const char *const FILENAMES[] = { "metaengine.h", "module.mk", "xyzzy.cpp", "xyzzy.h", "POTFILES", nullptr }; -const char *const ENGINES = "create_project ..\\.. --use-canonical-lib-names --msvc\n"; +const char *const ENGINES = "create_project ..\\.. --msvc\n"; bool fileExists(const char *name) { #ifdef _WIN32 diff --git a/devtools/create_project/create_project.cpp b/devtools/create_project/create_project.cpp index 88077b07d56..39171ddbe3b 100644 --- a/devtools/create_project/create_project.cpp +++ b/devtools/create_project/create_project.cpp @@ -298,7 +298,7 @@ int main(int argc, char *argv[]) { } else if (!std::strcmp(argv[i], "--sdl1")) { setup.useSDL2 = false; } else if (!std::strcmp(argv[i], "--use-canonical-lib-names")) { - setup.useCanonicalLibNames = true; + // Deprecated: Kept here so it doesn't error } else if (!std::strcmp(argv[i], "--use-windows-unicode")) { setup.useWindowsUnicode = true; } else if (!std::strcmp(argv[i], "--use-windows-ansi")) { @@ -737,9 +737,6 @@ void displayHelp(const char *exe) { " --tests Create project files for the tests\n" " (ignores --build-events and --installer, as well as engine settings)\n" " (default: false)\n" - " --use-canonical-lib-names Use canonical library names for linking. This makes it easy to use\n" - " e.g. vcpkg-provided libraries\n" - " (default: false)\n" " --use-windows-unicode Use Windows Unicode APIs\n" " (default: true)\n" " --use-windows-ansi Use Windows ANSI APIs\n" diff --git a/devtools/create_project/create_project.h b/devtools/create_project/create_project.h index 061142e2c08..36c35bdba9d 100644 --- a/devtools/create_project/create_project.h +++ b/devtools/create_project/create_project.h @@ -245,7 +245,6 @@ struct BuildSetup { bool runBuildEvents; ///< Run build events as part of the build (generate revision number and copy engine/theme data & needed files to the build folder bool createInstaller; ///< Create installer after the build bool useSDL2; ///< Whether to use SDL2 or not. - bool useCanonicalLibNames; ///< Whether to use canonical libraries names or default ones bool useStaticDetection; ///< Whether to link detection features inside the executable or not. bool useWindowsUnicode; ///< Whether to use Windows Unicode APIs or ANSI APIs. bool useXCFramework; ///< Whether to use Apple XCFrameworks instead of static libraries @@ -257,7 +256,6 @@ struct BuildSetup { runBuildEvents = false; createInstaller = false; useSDL2 = true; - useCanonicalLibNames = false; useStaticDetection = true; useWindowsUnicode = true; useXCFramework = false; diff --git a/devtools/create_project/msvc.cpp b/devtools/create_project/msvc.cpp index 634c65ed266..7c0a2773321 100644 --- a/devtools/create_project/msvc.cpp +++ b/devtools/create_project/msvc.cpp @@ -43,46 +43,44 @@ MSVCProvider::MSVCProvider(StringList &global_warnings, std::maprelease; - if (setup.useCanonicalLibNames) { + // Vcpkg already adds the libs + if (!setup.useVcpkg) { + const char *basename = library->release; // Debug name takes priority if (!isRelease && library->debug) { basename = library->debug; } - } else { - // Legacy name ignores configuration - if (library->legacy) { - basename = library->legacy; + if (basename) { + libs += basename; } } - if (basename) { - libs += basename; - } } return libs; diff --git a/devtools/create_project/msvc.h b/devtools/create_project/msvc.h index 9d24e4d59ac..86ea9c61ba5 100644 --- a/devtools/create_project/msvc.h +++ b/devtools/create_project/msvc.h @@ -47,7 +47,6 @@ protected: const char *release; ///< Filename of the Release build of the library. const char *debug; ///< Filename of the Debug build of the library. const char *depends; ///< Win32 libs this library must be linked against. - const char *legacy; ///< Legacy name for old precompiled libraries (deprecated). }; std::string getLibraryFromFeature(const char *feature, const BuildSetup &setup, bool isRelease) const; diff --git a/dists/msvc/create_msvc.bat b/dists/msvc/create_msvc.bat index 4e32df9dd00..f7ce6eab4d1 100644 --- a/dists/msvc/create_msvc.bat +++ b/dists/msvc/create_msvc.bat @@ -55,28 +55,28 @@ goto done echo. echo Creating project files with all engines enabled (stable and unstable) echo. -create_project ..\.. --enable-all-engines --use-canonical-lib-names --msvc +create_project ..\.. --enable-all-engines --msvc goto done :stable echo. echo Creating normal project files, with only the stable engines enabled echo. -create_project ..\.. --use-canonical-lib-names --msvc +create_project ..\.. --msvc goto done :tools echo. echo Creating tools project files echo. -create_project ..\.. --tools --use-canonical-lib-names --msvc +create_project ..\.. --tools --msvc goto done :tests echo. echo Creating tests project files echo. -create_project ..\.. --tests --use-canonical-lib-names --msvc +create_project ..\.. --tests --msvc goto done :clean_check diff --git a/ports.mk b/ports.mk index 991c02fedec..0ee485410ed 100644 --- a/ports.mk +++ b/ports.mk @@ -647,7 +647,7 @@ endif @echo Creating Code::Blocks project files... @cd $(srcdir)/dists/codeblocks && $(PWD)/devtools/create_project/create_project ../.. --codeblocks >/dev/null && git add -f engines/*.h *.workspace *.cbp @echo Creating MSVC project files... - @cd $(srcdir)/dists/msvc && $(PWD)/devtools/create_project/create_project ../.. --use-canonical-lib-names --msvc-version 12 --msvc >/dev/null && git add -f engines/*.h *.sln *.vcxproj *.vcxproj.filters *.props + @cd $(srcdir)/dists/msvc && $(PWD)/devtools/create_project/create_project ../.. --msvc-version 12 --msvc >/dev/null && git add -f engines/*.h *.sln *.vcxproj *.vcxproj.filters *.props @echo @echo All is done. @echo Now run