From deab35bbbf26fc4b7fa2a93cb29e740482cfd2de Mon Sep 17 00:00:00 2001 From: Donovan Watteau Date: Thu, 29 Aug 2024 14:30:52 +0200 Subject: [PATCH] SCUMM: Add a TODO for the Trac#2826 old workaround It's an old, known bug, but so far I haven't been able to locate an original release (or interpreter?) showing this issue. Maybe only the very first English releases had this issue? Owning a copy of the release showing this bug would help understanding what the original interpreters did there, and decide what Enhancement class should be used for it. --- engines/scumm/script.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/engines/scumm/script.cpp b/engines/scumm/script.cpp index 318c00ef6c9..b73dc3a6aea 100644 --- a/engines/scumm/script.cpp +++ b/engines/scumm/script.cpp @@ -170,6 +170,11 @@ int ScummEngine::getVerbEntrypoint(int obj, int entry) { // WORKAROUND for bug #2826: Disallow pulling the rope if it's // already in the player's inventory. + // + // TODO: it would be nice to explore what the impacted original + // interpreter did in this case, and decide which Enhancement + // value we give to this, but so far, I couldn't locate an + // original release (interpreter?) showing this issue. -dwa if (_game.id == GID_MONKEY2 && obj == 1047 && entry == 6 && whereIsObject(obj) == WIO_INVENTORY) { return 0; }