From 5ba177998ddee462b3dc4b4564190cdf5ad80c19 Mon Sep 17 00:00:00 2001 From: Mateusz Armatys Date: Wed, 27 Mar 2024 12:03:03 +0100 Subject: [PATCH] fix(presentation-compose): Add padding for the second row of `ProtonSettingsItem`. --- ...ntSettingsItemSnapshotTest_accountSettingsItemWithHint.png | 4 ++-- ...ttingsItemSnapshotTest_accountSettingsItemWithHintDark.png | 4 ++-- ...se_AccountSettingsListSnapshotTest_accountSettingsList.png | 4 ++-- ...ccountSettingsListSnapshotTest_accountSettingsListDark.png | 4 ++-- ...ccountSettingsScreenSnapshotTest_accountSettingsScreen.png | 4 ++-- ...ntSettingsScreenSnapshotTest_accountSettingsScreenDark.png | 4 ++-- .../kotlin/me/proton/core/compose/component/ProtonSettings.kt | 2 +- 7 files changed, 13 insertions(+), 13 deletions(-) diff --git a/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsItemSnapshotTest_accountSettingsItemWithHint.png b/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsItemSnapshotTest_accountSettingsItemWithHint.png index 360c92b73..d33d16b69 100644 --- a/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsItemSnapshotTest_accountSettingsItemWithHint.png +++ b/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsItemSnapshotTest_accountSettingsItemWithHint.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:c7b62b117baf769e79c3696efeebb8b526cf843a1cd9e198aa1e022299529cc4 -size 10198 +oid sha256:a368d1948582e97599b3acdbe364a21570fef57142b80320d120865075eb37f2 +size 10179 diff --git a/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsItemSnapshotTest_accountSettingsItemWithHintDark.png b/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsItemSnapshotTest_accountSettingsItemWithHintDark.png index 441cf96ee..7ae736e97 100644 --- a/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsItemSnapshotTest_accountSettingsItemWithHintDark.png +++ b/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsItemSnapshotTest_accountSettingsItemWithHintDark.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:d5ef5f0e35570054efbc46ce7e4556b18d2d8b51d0ba629d8d0084b43ef7a831 -size 10477 +oid sha256:652bbd812cdd5e6578932d898c39aad8a69339342e761235b945c44a9e7ce1cd +size 10397 diff --git a/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsListSnapshotTest_accountSettingsList.png b/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsListSnapshotTest_accountSettingsList.png index dc9ef3caa..e9ca648a6 100644 --- a/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsListSnapshotTest_accountSettingsList.png +++ b/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsListSnapshotTest_accountSettingsList.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:69273eb25804f093f29ea7c441a31141b394b9fdccf5485cc014380136e19fcb -size 21687 +oid sha256:61bde9744db09eaadf658a0e7a5da813de14418313fb16253f47b27646672a57 +size 21735 diff --git a/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsListSnapshotTest_accountSettingsListDark.png b/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsListSnapshotTest_accountSettingsListDark.png index e49bdb699..9da8b87eb 100644 --- a/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsListSnapshotTest_accountSettingsListDark.png +++ b/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsListSnapshotTest_accountSettingsListDark.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:e9c445889a8681f0221a20c1ee01fd775465930278b9df24715f36b9adbf0b3e -size 22011 +oid sha256:73d94be80f3f6627b6d17f8d07e11f6bb20d310166c3bc832ba41677ee2565a3 +size 22086 diff --git a/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsScreenSnapshotTest_accountSettingsScreen.png b/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsScreenSnapshotTest_accountSettingsScreen.png index d22806043..f81a94d52 100644 --- a/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsScreenSnapshotTest_accountSettingsScreen.png +++ b/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsScreenSnapshotTest_accountSettingsScreen.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:1e5f296dce186ed1f6b4c3ea5ad2efc4b4c3fd8896958593a7c3718ce079a5ee -size 25455 +oid sha256:49bfa1b70bbc235a3e70a4cdc4790d87ef629d0c1f23633cf1529091f81b01a5 +size 25493 diff --git a/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsScreenSnapshotTest_accountSettingsScreenDark.png b/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsScreenSnapshotTest_accountSettingsScreenDark.png index 53dbabcb5..c420ad138 100644 --- a/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsScreenSnapshotTest_accountSettingsScreenDark.png +++ b/account-manager/presentation-compose/src/test/snapshots/images/me.proton.core.accountmanager.presentation.compose_AccountSettingsScreenSnapshotTest_accountSettingsScreenDark.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:f8e5cad318f2d349a01663e751fb491cfb36afdd24860cff81f28048fc946c43 -size 25875 +oid sha256:4429e403bca8f279704c9bddf7a59852819ea563ab60d8b6080d35e605b50eb3 +size 25913 diff --git a/presentation-compose/src/main/kotlin/me/proton/core/compose/component/ProtonSettings.kt b/presentation-compose/src/main/kotlin/me/proton/core/compose/component/ProtonSettings.kt index 07151e6d7..79c085b77 100644 --- a/presentation-compose/src/main/kotlin/me/proton/core/compose/component/ProtonSettings.kt +++ b/presentation-compose/src/main/kotlin/me/proton/core/compose/component/ProtonSettings.kt @@ -160,7 +160,7 @@ fun ProtonSettingsItem( ) hint?.let { Text( - modifier = Modifier, + modifier = Modifier.padding(top = ProtonDimens.ExtraSmallSpacing), text = hint, color = ProtonTheme.colors.textHint, style = ProtonTheme.typography.body2Regular