From 3db00b95a30534aa29280414841c30c48fe2bd85 Mon Sep 17 00:00:00 2001 From: Robin Dorpe Date: Tue, 28 Apr 2026 15:29:50 +0200 Subject: [PATCH] ET-5951: Updated snapshot tests after MR review --- .../UI/MainToolbar/MainToolbarSnapshotTests.swift | 11 +++++------ ...hUpsell-upsellType.upsellType-mailPlus_dark.png} | Bin ...Upsell-upsellType.upsellType-mailPlus_light.png} | Bin ...Upsell-upsellType.upsellType-unlimited_dark.png} | Bin ...psell-upsellType.upsellType-unlimited_light.png} | Bin ...e.dark.png => mainToolbarWithoutUpsell.dark.png} | Bin ...light.png => mainToolbarWithoutUpsell.light.png} | Bin 7 files changed, 5 insertions(+), 6 deletions(-) rename Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/{mainToolbarWithUpsell-style-upsellType.upsellType-mailPlus_dark.png => mainToolbarWithUpsell-upsellType.upsellType-mailPlus_dark.png} (100%) rename Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/{mainToolbarWithUpsell-style-upsellType.upsellType-mailPlus_light.png => mainToolbarWithUpsell-upsellType.upsellType-mailPlus_light.png} (100%) rename Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/{mainToolbarWithUpsell-style-upsellType.upsellType-unlimited_dark.png => mainToolbarWithUpsell-upsellType.upsellType-unlimited_dark.png} (100%) rename Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/{mainToolbarWithUpsell-style-upsellType.upsellType-unlimited_light.png => mainToolbarWithUpsell-upsellType.upsellType-unlimited_light.png} (100%) rename Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/{mainToolbarWithoutUpsell-style.dark.png => mainToolbarWithoutUpsell.dark.png} (100%) rename Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/{mainToolbarWithoutUpsell-style.light.png => mainToolbarWithoutUpsell.light.png} (100%) diff --git a/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/MainToolbarSnapshotTests.swift b/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/MainToolbarSnapshotTests.swift index 10b980e48f..1236a934ab 100644 --- a/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/MainToolbarSnapshotTests.swift +++ b/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/MainToolbarSnapshotTests.swift @@ -29,22 +29,21 @@ import proton_app_uniffi @MainActor final class MainToolbarSnapshotTests { - @Test(arguments: [UIUserInterfaceStyle.light, .dark], [UpsellType.mailPlus, .unlimited]) - func mainToolbarWithUpsell(style: UIUserInterfaceStyle, upsellType: UpsellType) { + @Test(arguments: [UpsellType.mailPlus, .unlimited]) + func mainToolbarWithUpsell(upsellType: UpsellType) { let view = makeToolbarView(upsellEligibility: .eligible(upsellType)) assertSnapshotsOnIPhoneX( of: view, named: "upsellType.\(upsellType)", - styles: [style], drawHierarchyInKeyWindow: true, precision: 0.99 ) } - @Test(arguments: [UIUserInterfaceStyle.light, .dark]) - func mainToolbarWithoutUpsell(style: UIUserInterfaceStyle) { + @Test + func mainToolbarWithoutUpsell() { let view = makeToolbarView(upsellEligibility: .notEligible) - assertSnapshotsOnIPhoneX(of: view, styles: [style], drawHierarchyInKeyWindow: true) + assertSnapshotsOnIPhoneX(of: view, drawHierarchyInKeyWindow: true) } private func makeToolbarView(upsellEligibility: UpsellEligibility) -> some View { diff --git a/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-style-upsellType.upsellType-mailPlus_dark.png b/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-upsellType.upsellType-mailPlus_dark.png similarity index 100% rename from Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-style-upsellType.upsellType-mailPlus_dark.png rename to Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-upsellType.upsellType-mailPlus_dark.png diff --git a/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-style-upsellType.upsellType-mailPlus_light.png b/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-upsellType.upsellType-mailPlus_light.png similarity index 100% rename from Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-style-upsellType.upsellType-mailPlus_light.png rename to Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-upsellType.upsellType-mailPlus_light.png diff --git a/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-style-upsellType.upsellType-unlimited_dark.png b/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-upsellType.upsellType-unlimited_dark.png similarity index 100% rename from Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-style-upsellType.upsellType-unlimited_dark.png rename to Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-upsellType.upsellType-unlimited_dark.png diff --git a/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-style-upsellType.upsellType-unlimited_light.png b/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-upsellType.upsellType-unlimited_light.png similarity index 100% rename from Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-style-upsellType.upsellType-unlimited_light.png rename to Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithUpsell-upsellType.upsellType-unlimited_light.png diff --git a/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithoutUpsell-style.dark.png b/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithoutUpsell.dark.png similarity index 100% rename from Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithoutUpsell-style.dark.png rename to Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithoutUpsell.dark.png diff --git a/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithoutUpsell-style.light.png b/Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithoutUpsell.light.png similarity index 100% rename from Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithoutUpsell-style.light.png rename to Modules/App/Tests/Tests/Snapshots/UI/MainToolbar/__Snapshots__/MainToolbarSnapshotTests/mainToolbarWithoutUpsell.light.png