From f4dd13059b23ec40f8e8ce4ce0b860f462841cf1 Mon Sep 17 00:00:00 2001 From: Rok Oblak Date: Wed, 5 Mar 2025 18:13:51 +0700 Subject: [PATCH] Fix tests MAILANDR-2511: search no results issue --- .../SearchResultsLocalDataSourceImplTest.kt | 16 ++++++++++++++-- .../SearchResultsRepositoryImplTest.kt | 14 +++++++++----- .../domain/usecase/DeleteSearchResultsTest.kt | 7 +++---- 3 files changed, 26 insertions(+), 11 deletions(-) diff --git a/mail-message/data/src/test/kotlin/ch/protonmail/android/mailmessage/data/local/SearchResultsLocalDataSourceImplTest.kt b/mail-message/data/src/test/kotlin/ch/protonmail/android/mailmessage/data/local/SearchResultsLocalDataSourceImplTest.kt index 12186912f6..3fa25f66fc 100644 --- a/mail-message/data/src/test/kotlin/ch/protonmail/android/mailmessage/data/local/SearchResultsLocalDataSourceImplTest.kt +++ b/mail-message/data/src/test/kotlin/ch/protonmail/android/mailmessage/data/local/SearchResultsLocalDataSourceImplTest.kt @@ -72,12 +72,24 @@ class SearchResultsLocalDataSourceImplTest { fun `delete search results calls corresponding dao function with given parameters`() = runTest { // Given val keyword = "keyword" - coEvery { searchResultDao.deleteAll(userId, keyword) } just runs + coEvery { searchResultDao.deleteAllForKeyword(userId, keyword) } just runs // When searchResultsLocalDataSource.deleteResults(userId, keyword) // Then - coVerify(exactly = 1) { searchResultDao.deleteAll(userId, keyword) } + coVerify(exactly = 1) { searchResultDao.deleteAllForKeyword(userId, keyword) } + } + + @Test + fun `delete all search results calls corresponding dao function with given parameters`() = runTest { + // Given + coEvery { searchResultDao.deleteAll(userId) } just runs + + // When + searchResultsLocalDataSource.deleteAllResults(userId) + + // Then + coVerify(exactly = 1) { searchResultDao.deleteAll(userId) } } } diff --git a/mail-message/data/src/test/kotlin/ch/protonmail/android/mailmessage/data/repository/SearchResultsRepositoryImplTest.kt b/mail-message/data/src/test/kotlin/ch/protonmail/android/mailmessage/data/repository/SearchResultsRepositoryImplTest.kt index 340908b1fc..cd98a602c6 100644 --- a/mail-message/data/src/test/kotlin/ch/protonmail/android/mailmessage/data/repository/SearchResultsRepositoryImplTest.kt +++ b/mail-message/data/src/test/kotlin/ch/protonmail/android/mailmessage/data/repository/SearchResultsRepositoryImplTest.kt @@ -18,6 +18,7 @@ package ch.protonmail.android.mailmessage.data.repository +import ch.protonmail.android.mailmessage.data.local.MessageLocalDataSource import ch.protonmail.android.mailmessage.data.local.SearchResultsLocalDataSource import io.mockk.coEvery import io.mockk.coVerify @@ -31,21 +32,24 @@ import kotlin.test.Test class SearchResultsRepositoryImplTest { private val userId = UserId("1") - private val keyword = "keyword" private val searchResultsLocalDataSource = mockk() + private val messageLocalDataSource = mockk() private val searchResultsRepository = SearchResultsRepositoryImpl( - localDataSource = searchResultsLocalDataSource + localDataSource = searchResultsLocalDataSource, + messageLocalDataSource = messageLocalDataSource ) @Test fun `delete all should call delete search results from local data source`() = runTest { // Given - coEvery { searchResultsLocalDataSource.deleteResults(userId, keyword) } just runs + coEvery { searchResultsLocalDataSource.deleteAllResults(userId) } just runs + coEvery { messageLocalDataSource.deleteSearchIntervals(userId) } just runs // When - searchResultsRepository.deleteAll(userId, keyword) + searchResultsRepository.deleteAll(userId) // Then - coVerify(exactly = 1) { searchResultsLocalDataSource.deleteResults(userId, keyword) } + coVerify(exactly = 1) { searchResultsLocalDataSource.deleteAllResults(userId) } + coVerify(exactly = 1) { messageLocalDataSource.deleteSearchIntervals(userId) } } } diff --git a/mail-message/domain/src/test/kotlin/ch/protonmail/android/mailmessage/domain/usecase/DeleteSearchResultsTest.kt b/mail-message/domain/src/test/kotlin/ch/protonmail/android/mailmessage/domain/usecase/DeleteSearchResultsTest.kt index 2327cd79f0..4ce1c92db3 100644 --- a/mail-message/domain/src/test/kotlin/ch/protonmail/android/mailmessage/domain/usecase/DeleteSearchResultsTest.kt +++ b/mail-message/domain/src/test/kotlin/ch/protonmail/android/mailmessage/domain/usecase/DeleteSearchResultsTest.kt @@ -37,13 +37,12 @@ class DeleteSearchResultsTest { @Test fun `delete search results calls repository with given parameters`() = runTest { // Given - val keyword = "keyword" - coEvery { searchResultsRepository.deleteAll(userId, keyword) } just runs + coEvery { searchResultsRepository.deleteAll(userId) } just runs // When - deleteMessages(userId, keyword) + deleteMessages(userId) // Then - coVerify { searchResultsRepository.deleteAll(userId, keyword) } + coVerify { searchResultsRepository.deleteAll(userId) } } }