Commit Graph

2816 Commits

Author SHA1 Message Date
Daniel Rosenwasser fee50a6dbc Made the actual implementation of the lexical classifier be non-optional. 2015-02-16 14:59:22 -08:00
Vladimir Matveev 9f7c252ee0 Merge pull request #2027 from Microsoft/redefinedLetConst
Disallow let\const declarations in the same scope with var declarations.
2015-02-13 15:14:09 -08:00
CyrusNajmabadi 5047d2da70 Merge pull request #2028 from Microsoft/rwcInvariants
Don't check invariants when running RWC tests. It adds too much running ...
2015-02-13 14:43:44 -08:00
Yui cb3bc8519f Merge pull request #2033 from Microsoft/fixTimeMeasurement
Fix time measurement
2015-02-13 14:12:21 -08:00
Yui T cfb9cf0c7d Merge branch 'master' into fixTimeMeasurement 2015-02-13 13:46:11 -08:00
Yui T 91a39dd000 Fix time measurement 2015-02-13 13:42:17 -08:00
Vladimir Matveev 941728de07 pass missing argument to error message 2015-02-13 13:14:47 -08:00
Vladimir Matveev 3d26fbc4d4 adjust error message text based on PR feedback 2015-02-13 13:12:51 -08:00
Daniel Rosenwasser 1dca5620f5 Addressed CR feedback. 2015-02-13 12:56:21 -08:00
Vladimir Matveev e5d80db72c addressed PR feedback 2015-02-13 10:04:44 -08:00
Cyrus Najmabadi be40cac7fd Don't check invariants when running RWC tests. It adds too much running time. 2015-02-12 17:25:57 -08:00
Vladimir Matveev 07dbd30ba1 update comment text 2015-02-12 16:40:06 -08:00
Vladimir Matveev a9df539b7e added check that var and let\const cannot share scope, added check that var is not shadowed by the let\const from the inner scope 2015-02-12 16:37:07 -08:00
Daniel Rosenwasser 15b333e102 Added comment for 'syntacticClassifierAbsent'. 2015-02-12 16:29:03 -08:00
Daniel Rosenwasser 1838800b6c Fixed assertion 2015-02-12 16:29:01 -08:00
Daniel Rosenwasser ab79faef85 Added tests, fixed order of emptying templateStack, unconditionally perform template classification. 2015-02-12 16:28:45 -08:00
Daniel Rosenwasser 3fea0aefbe classifyKeywordsInGenerics -> syntacticClassifierAbsent 2015-02-12 15:48:32 -08:00
Daniel Rosenwasser f1f085eda6 Addressed CR feedback. 2015-02-12 15:48:30 -08:00
Daniel Rosenwasser 3429fab6fb Fixed issue with the kinds we check. 2015-02-12 15:48:27 -08:00
Daniel Rosenwasser ea30c68128 Rudimentary, but imperfect, lexical classification for templates. 2015-02-12 15:48:21 -08:00
Daniel Rosenwasser 3e8babedcf Merge pull request #1271 from Microsoft/taggedSigHelpAtEnd
Fixed bug where tagged templates with a literal adjacent to EOF showed sig help past the end.
2015-02-12 11:37:32 -08:00
togru d94cbed413 Merge remote-tracking branch 'upstream/master' 2015-02-11 10:12:22 +01:00
togru 091f38b3e0 improved equality checks in AMD module sorting function 2015-02-11 10:10:11 +01:00
Vladimir Matveev f29d931bd9 disallow let to be used as name in let\const in ES6 2015-02-10 13:36:24 -08:00
Anders Hejlsberg 4b92e42b62 Merge pull request #1931 from Microsoft/spreadCall
Support spread operator in call expressions
2015-02-10 09:24:53 -08:00
togru 8492dfdffd moved AMD module sorting to emitter, updated test case 2015-02-10 10:28:09 +01:00
Cyrus Najmabadi b86ef44e59 Add assert that clients do not try to call updateSourceFile multiple times on a source file. 2015-02-09 17:24:01 -08:00
Cyrus Najmabadi 11d19e3019 Fix issue with cancellation corrupting LS state.
The problem here was as follows:
1) Host calls into the LS to do some sort of operation.
2) LS tries to synchronize with the host.
3) During synchronization we attempt to create a new program.
4) Creating the new program causes us to incrementally update some source files.
5) Incrementally updating a source file produces a new source file, and invalidates the old one.
6) *Then* the host asks to cancel this operation.
7) THe synchronization process cancels itself, leaving the LS in an inconsistent state where some
   of its source files have had their trees updated, but the information about the source file still
   thinks that we have the previous version.

The fix is to not allow cancellation during host synchronization.  Once we start, we have to go
all the way to completion.
2015-02-09 17:15:29 -08:00
Cyrus Najmabadi 2eb1a213c7 Prevent index out of bounds exception. 2015-02-09 14:55:54 -08:00
Cyrus Najmabadi 17dd6c2de0 Be more conservative about reusing parameters. 2015-02-09 14:40:03 -08:00
Cyrus Najmabadi a79e8e928b Remove code duplication in isModuleElement. 2015-02-09 14:34:47 -08:00
Cyrus Najmabadi e417f3016b Add additional asserts, and make code more unified. 2015-02-09 14:23:55 -08:00
Cyrus Najmabadi d37fdfe213 Add additional asserts. 2015-02-09 14:12:32 -08:00
Cyrus Najmabadi 318aa8ce7a Don't use dynamic type checks while incrementally parsing. 2015-02-09 14:07:09 -08:00
Mohamed Hegazy 9207d9dd22 Merge remote-tracking branch 'origin/master' into fourslashCleanup
Conflicts:
	src/harness/harnessLanguageService.ts
2015-02-09 09:31:19 -08:00
Mohamed Hegazy 08f51b9070 Respond to code review comments 2015-02-09 09:19:50 -08:00
togru a27a893eeb previous AMD ordering was not correct 2015-02-09 09:00:42 +01:00
togru 36990570c4 Added AMD dependency reordering, so import order matches with provided names 2015-02-09 08:44:34 +01:00
Cyrus Najmabadi d0aa7891de Add additional incremental assert. 2015-02-08 18:02:13 -08:00
Cyrus Najmabadi 9d6b6b422a Rename a few members and clean up comments. 2015-02-08 17:48:56 -08:00
Cyrus Najmabadi ad7c77ea08 Check the text change range before and after we expand it. 2015-02-08 17:35:54 -08:00
Cyrus Najmabadi 1a17fd1daf Move assertions into the parsing layer. 2015-02-08 17:30:27 -08:00
Cyrus Najmabadi a82c57c4b9 Make sure positions of child elements are consistent. 2015-02-08 16:40:04 -08:00
Cyrus Najmabadi f1cb97b692 Add additional aggressive checks during incremental parsing. 2015-02-08 16:10:16 -08:00
CyrusNajmabadi 911a705e8d Merge pull request #1974 from Microsoft/multiLineEmitting
Preserve single line blocks when emitting.
2015-02-06 22:00:41 -05:00
CyrusNajmabadi 5a1c740ca8 Merge pull request #1973 from Microsoft/objectLiteralSemicolons
Have better error recovery for whne a user uses semicolons instead of commas to delimit an object literal.
2015-02-06 21:52:05 -05:00
Cyrus Najmabadi 36b6f4e1b7 Preserve single line blocks when emitting. 2015-02-06 18:45:09 -08:00
Cyrus Najmabadi 449f4a4f37 Have better error recovery for whne a user uses semicolons instead of commas to delimit an object literal. 2015-02-06 17:30:29 -08:00
Mohamed Hegazy 55aa240ade Merge branch 'master' into LSAPICleanup
Conflicts:
	src/services/services.ts
2015-02-06 17:17:23 -08:00
CyrusNajmabadi b5715bfe40 Merge pull request #1968 from Microsoft/sourceFileTestInvariants
Check source file invariants after creating/updating them in our tests.
2015-02-06 18:13:28 -05:00