Component commits:
91631435ca Fix newline inserted in empty block at end of formatting range
79b600aaa3 Clean up
19ef6b67c5 Fix refactoring mistake
Co-authored-by: Andrew Branch <andrew@wheream.io>
Component commits:
465042e278 Only issue @param suggestions with codefixes in TS
Previously, there were 2 JS errors that were issued as suggestions in TS
files. But there was no codefix for these errors, and the errors were
incorrect in TS.
This PR only issues the JS-specific errors on JS files.
4056b38860 Minimise test
4fb10f170a Merge branch 'main' into only-suggest-param-codefixes-in-ts
72499acabf Merge branch 'main' into only-suggest-param-codefixes-in-ts
Co-authored-by: Nathan Shively-Sanders <nathansa@microsoft.com>
* Fix error term of declaration in modules
* fix test
* change error code of "An import declaration can only be used at the top level of a module."
* Separate js and ts files for export errors in module.
* Change non-top-level error in namespace
* format
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
* WIP: pass in checkmode to getNarrowableTypeForReference
* add tests
* another pass through new check mode argument
* rename new check mode
* only use rest flag for rest elements in objects
* add and update tests
* change check mode flag name
* restore package-lock.json
* fix comments
* get rid of fourslash tests
* fix caching in checkExpressionCached when checkMode is not normal
* Don't distinguish between object and array rest elements
* get rid of undefined check mode
* don't make includeOptionality into checkmode flag
1. During name resolution, `@param` and `@return` tags should walk up
through the jsdoc comment and then jump to the host function. Previously they
did not, which would cause them to not resolve type parameters bound in
the scope of a host that was not a sibling of the comment. The example
from #46618 is a prototype method:
```js
/**
* @template {T}
* @param {T} t
*/
C.prototype.m = function (t) {
}
```
2. During name resolution, prototype methods are supposed to resolve
types both from the host function's location and from the containing
class' location. The containing class lookup happens in a separate call
to `resolveName`. Previously, the code that finds the containing class
only worked for the above style of comment, which is on the outer
ExpressionStatement, but not for the below style, which is on the
function expression itself:
```js
C.prototype.m =
/**
* @template {T}
* @param {T} t
*/
function (t) {
}
```
* Fix @link https:// formatting
Also improve .d.ts formatting of `@link`,`@linkcode`,`@linkplain`.
Fixes#46734
1. Previously, `@link` incorrectly put a space between "https" and "://"
when formatting jsdoc for editors. Now it does not.
2. When fixing the same output for .d.ts, I discovered that all `@link` tags
were formatted as `@link`, even if they were `@linkcode` or
`@linkplain`. I fixed that too.
* semicolon lint
* Fix inlay hint crash for jsdoc function type syntax
Parameters in JSDoc function types do not have names. The type does not
reflect this. This PR fixes the crash; I'll see how much churn it causes
to fix the type as well.
Fixes#47606
* make inlay hints test smaller
* Fix duplicate completions from two different copies of a node_modules package
* Fix logic for scoped packages
* Fix errors from merge
* Less gross way to reconcile these two conflicting PRs
* Allow moduleSymbolToValidIdentifier to be uppercase for JSX tags
* Cleaner way of getting the uppercase name when needed
* Fix build errors, get rid of basically unnecessary ScriptTarget
* More accurate name for parameter
* Rename other parameter too
* Fix failing test
* Import fix
* Wire up completions, add sorting to fix
* Fix overlapping changes when there’s only one import specifier
* Update API baseline
* Add sorting and filtering back to UMD fix
* tmp
* fix jsdoc inheritage for property and setter/getter
* fix test
* fix test
* fix mirrors
* add more tests
* add tests of jsdoc for intance of class
Andrew BranchandGitHub
Ron BucktonandGitHub
Oliver Joseph AshandGitHub
ZzzenandGitHub
Ryan CavanaughandGitHub
magic-akariandGitHub
Song GaoandGitHub
Gabriela Araujo BrittoandGitHub