Commit Graph
2534 Commits
Author SHA1 Message Date
Andy 2ee92948d8 Support @param tag on property declaration initializer (#21907)
* Support @param tag on property declaration initializer

* Update test

* Finish updating test
2018-02-14 10:12:38 -08:00
Andy 8c2756fdf6 Support getting string literal completions based on a type argument constraint (#21168)
* Support getting string literal completions based on a type argument constraint

* Fix bug: look for require call before argument info

* Code review

* @sandersn code review

* Remove test cast

* Reduce completions.ts diff

* @weswigham review

* Remove getTypeArgumentConstraint's dependence on checkTypeArgumentConstraints

* Remove TODO
2018-02-13 15:18:26 -08:00
Andy 458c12fa78 importFixes: Fix bug by using replaceNode and removing changeIdentifierToPropertyAccess (#21898) 2018-02-12 13:05:40 -08:00
Sheetal Nandi d6d9953f6d Fix completion of jsx attributes in self closing element
Fixes #21844
2018-02-12 11:57:20 -08:00
Andy fcf348610c documentHighlights: Handle some invalid modifier locations (#21893) 2018-02-12 11:34:49 -08:00
Mohamed Hegazy 3fb481ff40 Multiple telemetry debug assert failure fixes (#21886)
* Use getAllowSyntheticDefaultImports to access `--allowSyntheticDefaultImport` value

* Fix #21788: Handel missing imporotClause case

* Fix #21789: Add a defensive check to forgottenThisPropertyAccess code fix for non-identifier locations

* Do not suggest prefix with `this` if the name we are looking for is diffrent from the errorLocation

* Fix #21796: Handel case of unknown module

* Add check to capture more info for #21800

* Fix #21807: check for symbol before looking up its flags

* Fix #21812: Gracefully fail if the token is not `this`.
2018-02-12 10:34:17 -08:00
Eric Grube 879cb69d6a add beautifier rule for space after close paren and destructure bracket (#21859) 2018-02-10 12:45:54 -08:00
Priyantha Lankapura a732ff6b35 Add type infer formatting (#21850)
* add test for type infer formatting

* Fix type infer formatting

* update test to use condtional
2018-02-10 12:36:04 -08:00
Andrew Casey 1baae42149 Handle variable declaration without initializer in Convert to ES6 Module
Fixes #21786
2018-02-09 18:08:47 -08:00
Andy 49e78f68d2 findAllRefs: Fix bug for export not at top-level of a module/namespace (#21846) 2018-02-09 15:10:34 -08:00
Andy 425a4182a3 Handle empty declaration list in Convert to ES6 Module (#21843)
* Handle empty declaration list in Convert to ES6 Module

* Fix test
2018-02-09 14:46:57 -08:00
Andy 31ec5e7390 findAllReferences: Don't fail on broken re-export (#21841) 2018-02-09 13:56:04 -08:00
Andy aa1ebda6a6 Fix bug: handle missing symbol.parent for non-accessible symbol (#21834) 2018-02-09 13:48:40 -08:00
Andy e2178ecfab In getSymbolAtLocation, return undefined instead of unknownSymbol (#21774)
* In getSymbolAtLocation, return undefined instead of unknownSymbol

* Update check in completions to look for undefined instead of unknownSymbol
2018-02-08 14:35:21 -08:00
Andy 16f3b93ffd Simplify TextSpan creation (#21306)
* Simplify TextSpan creation

* Rename 'start' to 'pos' where possible
2018-02-08 13:51:10 -08:00
Nathan Shively-Sanders 37f15ccb41 Print deferred mapped symbols 1 level deep (#21311)
* Print deferred mapped symbols 1 level deep

Previously, deferred mapped symbols would not print their type at all;
it would always print as `any`. This differed from the older behaviour
that printed it forever if necessary. As a compromise, we now print
deferred mapped symbosl 1 level deep before giving up and printing
`any`. This should cover the most common uses of mapped types.

* Use context flags instead of a global
2018-02-08 13:35:00 -08:00
Mohamed Hegazy 4150a463e2 Fix #20805 (#21755)
* Add `-dev` to version patch number in master

* Refactor to handel non-identifier tokens for UMD modules

* Be more graceful handeling non-identifier tokens in import fixes

* Fix bad merge

* Remove check for isIdentifier
2018-02-08 10:32:08 -08:00
Sheetal Nandi 353cfbddc6 Merge pull request #21750 from Microsoft/memberCompletionOfUnknownRightSideOfImport
Fix the member completion returned on right side of the import when it does not resolve to any symbol
2018-02-08 10:07:12 -08:00
Andy 05510a8612 Don't use export function for a function whose name differs from its exported name (#21739)
* Don't use `export function` for a function whose name differs from its exported name

* Fix lint
2018-02-08 09:53:53 -08:00
Priyantha Lankapura 79dde93068 Fix formatting of conditional types (#21762)
* Add test for formatting of conditional types

* Fix formatting of conditional types
2018-02-08 09:28:38 -08:00
Sheetal Nandi 5b1f29c722 Fix the member completion returned on right side of the import when it does not resolve to any symbol
Fixes #20794
2018-02-07 15:44:22 -08:00
Wesley Wigham 65149063ed Fix #21641, Add indirect location for default imports for synthetic defaults (#21703) 2018-02-07 15:04:37 -08:00
Andy ed941c27b8 Don't check modifier legality, highlight anyway (#21335) 2018-02-07 13:51:08 -08:00
Sheetal Nandi 01d160e3b6 Merge pull request #21740 from Microsoft/gotoDefinition
Fix assert when goToDefinition, from location that is new expression target but not a class symbol
2018-02-07 13:50:02 -08:00
Sheetal Nandi dab0dbe6f0 Avoid the class declaration not found assert when the new expression doesnt contain construct signature 2018-02-07 13:30:58 -08:00
Sheetal Nandi 1472b654db Add test case when new expression target is not Class declaration 2018-02-07 13:25:36 -08:00
Andy 786bacfa3b Fix bug: support non-Identifier previousToken in importFixes (#21650)
* Fix bug: support non-Identifier previousToken in importFixes

* Remove intersection type
2018-02-07 12:33:16 -08:00
Priyantha Lankapura 4cfb7a5105 Fix space issue in mapped type formatting (#21712)
* Add the test for mapped type formatting issue

* Fix inconsistent number of spaces within braces when formatting mapped types
2018-02-07 09:23:31 -08:00
Andy c1b4c5b827 Fix bug in normalizeAndPreserveTrailingSlash: For "./", return "", not "/" (#21704) 2018-02-07 09:07:05 -08:00
Andy a1ffa9478c Fix ScriptElementKind for path mapping completions (#21695) 2018-02-06 13:42:32 -08:00
Andy c4c9a00a9f Support incomplete identifier in JSX initializer completions (#21681) 2018-02-06 11:40:39 -08:00
Andy cd22ea73d3 Remove leading directory separator from path mapping completion (#21688) 2018-02-06 11:39:09 -08:00
Andy cde1cd0075 Add top-level completion for path mapping (#21686) 2018-02-06 11:17:06 -08:00
Andy 57a50f4b9d fixInvalidImportSyntax: Preserve comment (#21684) 2018-02-06 10:19:14 -08:00
Andy 044fb53476 Escape quotes in bracketed completions (#21676) 2018-02-06 09:28:03 -08:00
Andy d6f52c3477 importFixes: Bundle module specifiers with import kinds, and replace ImportCodeActionMap with existing functionality (#20700) 2018-02-06 08:57:32 -08:00
Andy 48c0af5d43 Support testing document highlights with "filesToSearch" (#21640)
* Support testing document highlights with "filesToSearch"

* Fix lint
2018-02-05 14:02:50 -08:00
Andy d584f4d97b Fix assertion: class reference location may be 'default' keyword instead of class name (#21630)
* Fix assertion: class reference location may be 'default' keyword instead of class name

* Update API baselines
2018-02-05 13:24:08 -08:00
Andy 120af861f7 Fix bug: replacmentSpan for completion shouldn't include property name that doesn't start with completion name (#21587) 2018-02-05 11:20:22 -08:00
Andy 1784e51929 Fix harness getDirectores implementation to not include directory as prefix (#21633) 2018-02-05 11:11:00 -08:00
Andy 14bd0a2d56 Detect and prevent creation of bad Identifier (#21581) 2018-02-05 09:13:38 -08:00
Anders Hejlsberg 7034d671db Merge branch 'conditionalTypes' into inferTypes 2018-02-03 08:41:54 -08:00
Wesley Wigham 058b2f7f11 Allow boolean literals to be generated from contextual types again (#21503)
* Allow boolean literals to be generated from contextual types again

* Update fourslash test
2018-02-01 12:34:16 -08:00
Andrew Casey 02972899d7 Merge pull request #21379 from amcasey/HighlightingAssert
Check syntax kind in isDeclarationNameOrImportPropertyName
2018-02-01 10:11:10 -08:00
Andy df15d5b977 Don't treat class name contextToken as a completion list blocker if it is not the previousToken (#21534) 2018-02-01 09:24:57 -08:00
Andrew Casey cd0000110d Add FAR test 2018-01-31 11:12:09 -08:00
Anders Hejlsberg 7c241ba2f7 Merge branch 'conditionalTypes' into inferTypes
# Conflicts:
#	src/compiler/checker.ts
#	tests/cases/fourslash/completionInJSDocFunctionNew.ts
#	tests/cases/fourslash/completionInJSDocFunctionThis.ts
2018-01-30 13:40:16 -08:00
Andrew Casey 3020f3d2e6 Handle trivia in code fix forgotten-this
Fixes #21433
2018-01-30 13:25:39 -08:00
Matt McCutchen f0ba16c9a5 Unused type parameters should be checked by --noUnusedParameters, not (#21167)
--noUnusedLocals.

Fixes #20568.
2018-01-25 16:18:35 -08:00
Andy 7c4e755eff When applying // @ts-ignore fix as a group, apply to a line only once. (#21413)
* When applying `// @ts-ignore` fix as a group, apply to a line only once.

* Rename line to lineNumber
2018-01-25 13:53:08 -08:00