Commit Graph
20484 Commits
Author SHA1 Message Date
Nathan Shively-Sanders f139455229 Address PR comments 2019-07-01 15:06:16 -07:00
Nathan Shively-Sanders cce2b9316e Merge branch 'master' into report-multiple-overload-errors 2019-07-01 10:17:03 -07:00
Nathan Shively-SandersandGitHub b46c44d70d Merge pull request #32181 from microsoft/use-only-immediately-preceding-jsdoc
Use only immediately preceding JSDoc
2019-07-01 10:12:05 -07:00
Sheetal NandiandGitHub ebf323ea19 Merge pull request #32124 from austincummings/affectsEmitToModuleAndEsModuleInterop
Add affectsEmit to module and esModuleInterop options
2019-07-01 09:59:41 -07:00
Sheetal NandiandGitHub 1bd631e593 Merge pull request #32076 from stristr/master
Make close() in interface Watch<T> public
2019-07-01 09:46:09 -07:00
Anders HejlsbergandGitHub f89165d072 Merge pull request #32049 from microsoft/noDuplicateIntersectionSignatures
Remove duplicate signatures in intersections
2019-06-30 19:38:37 -07:00
Austin Cummings c30054de63 Fix esModuleInterop affectsEmit change test 2019-06-30 11:06:00 -07:00
Nathan Shively-Sanders fefb857847 Use only immediately preceding JSDoc
Now only the immediately preceding jsdoc of a node is retrieved by
getJSDoc, although it still does the correct non-local lookup for nodes
like ParameterDeclaration.

This doesn't change parsing or binding, which use the per-node Node.jsdoc
property directly. But it does change everything that relies on getJSDoc,
which includes the checker and language service.

Fixes #32062, which contains the analysis that justifies the change.
2019-06-29 08:05:10 -07:00
Austin Cummings 5b694f8302 Add tests for module and esModuleInterop affectsEmit change 2019-06-28 18:34:59 -07:00
Austin Cummings 4195f1a409 Add affectsEmit to module and esModuleInterop options 2019-06-28 17:51:05 -07:00
Nathan Shively-Sanders 71276a21af Merge branch 'master' into report-multiple-overload-errors 2019-06-28 16:24:38 -07:00
Nathan Shively-Sanders 97784749b5 Fix lint 2019-06-28 16:09:54 -07:00
Daniel RosenwasserandGitHub 410b71751e Merge pull request #32034 from dragomirtitian/GH-32013-improve-error-messages-for-calling-types
Improved error message for calling/constructing types
2019-06-28 16:08:18 -07:00
Nathan Shively-Sanders c48018f95e Merge branch 'master' into report-multiple-overload-errors 2019-06-28 16:02:35 -07:00
Nathan Shively-Sanders 47bbc9546e Convert related spans to message chains 2019-06-28 15:42:27 -07:00
Titian Cernicova-Dragomir e4bca9649a Improved error spans for call errors:
1. When calling a non-callable expression the error span is on the call target not on the whole call
2. When calling a method, the error for overload resolution now includes the arguments (this was previously regressed by #31414)
2019-06-28 23:53:47 +03:00
Titian Cernicova-Dragomir bc07eec015 Added tests for new error messages on calls to unions. 2019-06-28 23:23:17 +03:00
Titian Cernicova-Dragomir 768318b30c Improved error message for calling/constructing types 2019-06-28 23:23:16 +03:00
Wesley WighamandGitHub b4a1a5996f Rework declaration emit visibility calculation for namespaces (#32156)
* Rework declaration visibility for namespaces

* Accept skipped baselines
2019-06-28 13:23:15 -07:00
Wesley WighamandGitHub 6760a03cec Add vscode docker test (#32152)
* Add vscode docker test

* Remove PID-log line

* Update user baselines (#18)
2019-06-28 13:22:25 -07:00
Nathan Shively-Sanders ba9d8e2e81 Switch DiagnosticMessageChain to be a tree 2019-06-27 16:30:35 -07:00
Wesley WighamandGitHub 2af8ac73ff Add xterm test to docker suite (#32149) 2019-06-27 15:29:22 -07:00
Sheetal NandiandGitHub b32afb55d1 Merge pull request #31985 from microsoft/buildInfoData
Make paths in tsbuildinfo file to be relative to the file
2019-06-27 12:49:52 -07:00
Andrew CaseyandGitHub f1c781fa13 Merge pull request #31988 from amcasey/SyntacticClassifications
Trivially expose getEncodedSyntacticClassifications
2019-06-27 10:16:57 -07:00
Nathan Shively-Sanders 35dda10865 Fix lint, remove overloads 2019-06-27 09:09:59 -07:00
Anders Hejlsberg ea0a6de82f Compare type parameters, constraints, and defaults in signature identity 2019-06-26 18:09:30 -10:00
Nathan Shively-Sanders 8454ef114d JSDoc:Treat tokens between backticks as comments
even `@`, which would otherwise start a new tag.
2019-06-26 16:04:46 -07:00
Andrew Casey 2d785c8c91 Make args types internal 2019-06-26 15:09:30 -07:00
Klaus MeinhardtandRyan Cavanaugh 392d775095 allow const-assertion on aliased enum symbol (#32110)
Fixes: #32087
2019-06-26 14:42:06 -07:00
OrtaandGitHub a50a5d309c Merge pull request #32088 from orta/fix-32068
Handle making sure that two less thans are never converted into >>
2019-06-26 14:10:02 -07:00
Nathan Shively-Sanders 0436cfca16 Do not report multiple diagnostics per signature.
If there are multiple diagnostics per signature, choose the signature
with the fewer diagnostics to report. If there are more than one with
the minimum, choose the latest in the overload set.
2019-06-26 12:56:14 -07:00
Andrew BranchandGitHub 871bdeeec4 Merge pull request #31480 from andrewbranch/bug/25487
Fix invalid JSXExpressions having identifier-ish things in their trivia, improve error messages for comma expressions in JSX
2019-06-26 10:13:42 -07:00
Nathan Shively-Sanders c0ff286b34 Merge branch 'master' into report-multiple-overload-errors 2019-06-26 10:06:29 -07:00
Nathan Shively-Sanders 68968fd396 Improve error messages and related spans 2019-06-26 10:05:44 -07:00
Wesley WighamandGitHub 34eb5ddf75 Fix tuple and array comparisons during identity checking (#32089) 2019-06-25 20:56:41 -07:00
Nathan Shively-SandersandGitHub 261952247a Merge pull request #31945 from microsoft/skip-costly-tests
Skip costly tests
2019-06-25 15:47:49 -07:00
Orta Therox 897fb3a2a6 Handle making sure that two less thans are never converted into >> 2019-06-25 15:16:15 -07:00
Nathan Shively-Sanders b58932e638 Fix lint and remove done TODOs 2019-06-25 14:54:43 -07:00
Nathan Shively-Sanders 67b8ca77d9 Merge branch 'master' into report-multiple-overload-errors 2019-06-25 14:07:56 -07:00
Nathan Shively-Sanders 66244f7937 Don't double-check JSX calls
The JSX code path stands on its own
2019-06-25 13:57:30 -07:00
Nathan Shively-Sanders f20f700025 Update baselines, except JSX
JSX is still broken
2019-06-25 13:16:34 -07:00
Orta Therox 444c3059f6 Handle feeedback 2019-06-25 09:41:26 -07:00
0a272e04ef Update src/services/formatting/README.md
Co-Authored-By: Andrew Branch <andrewbranch@users.noreply.github.com>
2019-06-24 17:08:34 -07:00
3f9395be39 Update src/services/formatting/README.md
Co-Authored-By: Andrew Branch <andrewbranch@users.noreply.github.com>
2019-06-24 17:08:28 -07:00
Sasha Joseph 314f2e68b7 Make close() in interface Watch<T> public
Closes #31526
2019-06-24 17:05:19 -07:00
Orta Therox ba4aad79dc Adds some docs for how a formatter works 2019-06-24 15:42:56 -07:00
Nathan Shively-Sanders ecfa902ba1 Use existing reporting mechanism 2019-06-24 15:32:58 -07:00
Wesley WighamandGitHub a150d55592 Explicitly error when an exclude is provided by a test as it will be unused (#32014) 2019-06-24 15:29:02 -07:00
Andrew BranchandGitHub 6717d8d928 Merge pull request #31942 from andrewbranch/bug/30882
Improve error message on indexed access to private members of type parameters
2019-06-24 09:22:21 -07:00
Anders Hejlsberg 762fff1f65 Remove duplicate call/construct signatures in intersections 2019-06-23 09:00:42 -10:00