Commit Graph
15931 Commits
Author SHA1 Message Date
Sheetal NandiandMohamed Hegazy ecddf8468f Fix the assert for undefined leaf in LineNode (#21924)
Fixes #21818
2018-02-16 16:37:32 -08:00
Sergii BezliudnyiandMohamed Hegazy b6f82adfed add template to jsdoc completion (#21978) 2018-02-16 16:27:57 -08:00
Andrew CaseyandGitHub 8341b1369d Merge pull request #22004 from amcasey/FARBadImport
Make FAR handle non-existent imported symbols
2018-02-16 16:17:04 -08:00
Mohamed HegazyandGitHub f95b9bc65d Port generated lib files (#22003)
* Port generated lib files

* Port generated lib files
2018-02-16 15:53:44 -08:00
Andrew Casey b64eefdb20 Remove redundant null check 2018-02-16 15:50:12 -08:00
Andrew CaseyandGitHub d2cbd8de06 Merge pull request #22001 from amcasey/OrganizeImportsMissedCommits
Group imports before sorting and coalescing
2018-02-16 15:28:15 -08:00
Andrew Casey 9c2b95dae3 Make FAR handle non-existent imported symbols 2018-02-16 14:49:23 -08:00
Nathan Shively-SandersandGitHub 7e8dab681a typingsInstaller:Remove triple-slash references (#21982)
Replace them with an explicit list of files in tsconfig. I got this list
by adding --listFiles to the jake-generated command.
2018-02-16 14:00:10 -08:00
Andrew Casey 7a31394788 Group imports before sorting and coalescing 2018-02-16 13:15:07 -08:00
Andrew CaseyandGitHub 70e9a5e6dc Merge pull request #21909 from amcasey/OrganizeImports
Introduce an organizeImports command
2018-02-16 12:49:02 -08:00
Andrew Casey 5c278cee17 Address PR feedback
Eliminate cancellation token

Add organizeImports.ts to tsconfig.json

Simplify ts.OrganizeImports.organizeImports

Simplify sortImports

Semantic change: all invalid module specifiers are now considered to be
equal.

Simplify comparisons using ||

Pull out imports with invalid modules specifiers

...for separate processing.  They are tacked on to the end of the
organized imports in their original order.

Bonus: downstream functions can now assume imports have valid module
specifiers.

Rename baseline folder with leading lowercase

Simplify coalesceImports

Remove some unnecessary null checks

Simplify baseline generation
2018-02-16 10:56:16 -08:00
Andrew Casey f4141ac6bf Separate OrganizeImports into its own namespace and file 2018-02-16 10:52:29 -08:00
Andrew Casey 979b14689e Fix lint errors 2018-02-16 10:52:21 -08:00
Andrew Casey 5656f35b6a Introduce an organizeImports command
In phase 1, it coalesces imports from the same module and sorts the
results, but does not remove unused imports.

Some trivia is lost during coalescing, but none should be duplicated.
2018-02-16 10:51:38 -08:00
AndyandGitHub b70aa229c6 getTextOfPropertyName: Assert input value is a PropertyName (#21981) 2018-02-16 10:48:57 -08:00
AndyandGitHub cfc234f959 Simplify getBraceMatchingAtPosition (#21979) 2018-02-15 16:29:42 -08:00
AndyandGitHub f8f4bb8fdd textChanges: Clean up handling of newLineCharacter (#21970) 2018-02-15 13:02:56 -08:00
AndyandGitHub 347bff14a9 textChanges: Simplify getChanges (#21971)
* textChanges: Simplify getChanges

* Return ReadonlyArray
2018-02-15 13:02:45 -08:00
AndyandGitHub 81df5313d7 Simplify getOccurrencesAtPosition (#21977) 2018-02-15 13:02:32 -08:00
Anders HejlsbergandGitHub 0f697c376b Merge pull request #21947 from Microsoft/fixKeyofWildcard
Fix issue with 'keyof T' and conditional types
2018-02-15 12:44:51 -08:00
AndyandGitHub a133cec246 Fix bug: Interface type parameter merged with property is not unused (#21966) 2018-02-15 09:30:58 -08:00
AndyandGitHub 1b6aa1386f Handle non-preserved const enums in debug messages (#21945) 2018-02-15 09:21:33 -08:00
AndyandGitHub 8518343dc8 Add isStringLiteralLike helper (#21953) 2018-02-14 13:25:04 -08:00
AndyandGitHub 2ee92948d8 Support @param tag on property declaration initializer (#21907)
* Support @param tag on property declaration initializer

* Update test

* Finish updating test
2018-02-14 10:12:38 -08:00
Anders Hejlsberg 3a61f638ba Instantiation of 'keyof T' for wildcard type produces wildcard type 2018-02-14 09:19:47 -08:00
AndyandGitHub 47d84f87ce assertItemInCompletionList: Fix error messages (#21908)
* assertItemInCompletionList: Fix error messages

* Fix lint
2018-02-14 08:11:38 -08:00
Priyantha LankapuraandMohamed Hegazy 80464e8ff1 fix typo in intellisense (#21914) 2018-02-13 18:52:33 -08:00
AndyandGitHub 8c2756fdf6 Support getting string literal completions based on a type argument constraint (#21168)
* Support getting string literal completions based on a type argument constraint

* Fix bug: look for require call before argument info

* Code review

* @sandersn code review

* Remove test cast

* Reduce completions.ts diff

* @weswigham review

* Remove getTypeArgumentConstraint's dependence on checkTypeArgumentConstraints

* Remove TODO
2018-02-13 15:18:26 -08:00
Anders HejlsbergandGitHub f8a378a1d7 Merge pull request #21919 from Microsoft/mappedTypeModifiers
Improved control over mapped type modifiers
2018-02-13 11:21:07 -08:00
Anders Hejlsberg 2cc1d735ec Add Required<T> to lib.d.ts 2018-02-13 06:47:52 -08:00
Sheetal NandiandGitHub 274bb5dab4 Merge pull request #21910 from Microsoft/projectUpdateOnFileOpenClose
Fix for No Default project scenario
2018-02-13 06:21:05 -08:00
Sheetal Nandi d9d98cf11a Handle the delayed updates due to user action correctly when ensuring the project structure is upto date
Fixes #20629
2018-02-12 16:53:47 -08:00
Anders Hejlsberg a629acd8fd Allow +/- to prefix 'readonly' and '?' modifiers in mapped types 2018-02-12 16:20:49 -08:00
AndyandGitHub 74f01abfcf Clean up findPrecedingToken and avoid returning whitespace-only jsx text token (#21903) 2018-02-12 14:42:16 -08:00
Anders HejlsbergandGitHub d07523e9e5 Merge pull request #21866 from Microsoft/fixIndexedAccessWildcard
Fix indexed access issue with conditional types
2018-02-12 14:18:44 -08:00
Adrian LeonhardandMohamed Hegazy 6ab5d97a5d Changed "Duplicate Identifier" to "enum cannot be merged..." (#18579)
* Changed "Duplicate Identifier" to "enum can only be merged..."
when either declaration of the identifier is an enum.

Partial (?) fix for #529

Not sure if the new test is necessary, all the cases seem to have been covered by others tests.

* picked a nit
2018-02-12 13:38:08 -08:00
Ron BucktonandGitHub 2ff8fae5da Merge pull request #21900 from Microsoft/fix21620
Fix emit when binder treats exported const as namespace
2018-02-12 13:34:54 -08:00
Sheetal Nandi e702d90cfe Repro scenario for finding no project of #20629 2018-02-12 13:12:55 -08:00
Sheetal Nandi 6ca65b71b4 Refactoring project updates in openFile 2018-02-12 13:12:55 -08:00
AndyandGitHub 458c12fa78 importFixes: Fix bug by using replaceNode and removing changeIdentifierToPropertyAccess (#21898) 2018-02-12 13:05:40 -08:00
AndyandGitHub 20a6be67a0 Clarify assumptions in verifyImportFixAtPosition (#21899) 2018-02-12 13:05:13 -08:00
Ron BucktonandGitHub 7a6a0673df Merge pull request #21897 from Microsoft/fix21626
Fix duplicate label in es2017 async function
2018-02-12 13:04:39 -08:00
Ron Buckton c84b7caa25 Fix emit when binder treats exported const as namespace 2018-02-12 13:02:47 -08:00
Ron BucktonandGitHub 641f787006 Merge pull request #21896 from Microsoft/fix21878
Revert BOM emit change
2018-02-12 12:31:12 -08:00
Ron Buckton 6736ced51d Fix duplicate label in es2017 async function 2018-02-12 12:30:29 -08:00
Ron Buckton ea8f5158c2 Revert BOM emit change 2018-02-12 12:02:34 -08:00
Sheetal Nandi d6d9953f6d Fix completion of jsx attributes in self closing element
Fixes #21844
2018-02-12 11:57:20 -08:00
AndyandGitHub fca3db440c Give MethodDeclaration and MethodSignature parent types (#21892)
* Give MethodDeclaration and MethodSignature parent types
* And fix code that used MethodDeclaration for parameter that might be a MethodSignature

* Move type check back inside checkGrammarArrowFunction
2018-02-12 11:56:44 -08:00
Mohamed HegazyandGitHub c9a0b7ec5b Port generated lib files (#21889) 2018-02-12 11:53:03 -08:00
AndyandGitHub fcf348610c documentHighlights: Handle some invalid modifier locations (#21893) 2018-02-12 11:34:49 -08:00