Commit Graph
955 Commits
Author SHA1 Message Date
Andrew Casey ebee7c62be Only decrement activeRequestCount on SetTypings responses
InvalidateCache responses are triggered by file watchers, rather than by
requests.
2017-09-15 15:32:10 -07:00
Andrew Casey 14c860b9cb Don't get typings for projects with disabled language services (#18324) 2017-09-14 11:51:23 -07:00
Mohamed Hegazy 1c7a29eeb3 Port fixes from master into release-2.5 (#18361)
* Test: parsing of two-line @typedef jsdoc

* Fix forEachChild's visit of JSDocTypedefTag

Also remove JSDocTypeLiteral.jsdocTypeTag, which made no sense since it
was only useful when storing information for its parent `@typedef` tag.

* Update baselines

* Inline variable to aid control flow

* Improved caching scheme for anonymous types

* Fix signature help

* Optimize caching of type literals

* Accept new baselines

* Fix linting errors

* Use canonicalized forms when comparing signatures

* Minor changes

* Document ThrottledOperations.schedule

* Limit the number of unanswered typings installer requests

If we send them all at once, we (apparently) hit a buffer limit in the
node IPC channel and both TS Server and the typings installer become
unresponsive.

* Fix lint issues

* Add explanatory comment
2017-09-09 12:54:30 -07:00
Andy 9434a81b71 extractMethod: Support renameLocation (#18351) 2017-09-08 17:09:17 -07:00
Ryan Cavanaugh 6425ea29c9 Don't crash when a JS file appears in an inferred context 2017-08-29 14:31:28 -07:00
Ryan Cavanaugh 13eeb34e57 Ignore scripts for types packages (#17969) 2017-08-24 11:31:21 -07:00
Mohamed Hegazy 1420fbc2d4 Bind logger function before using (#17983)
* Bind logger function before using

* Use lambda isntead of bind
2017-08-23 12:35:34 -07:00
Mohamed Hegazy ba56b62b9f Ensure string enums are generated in protocol.d.ts 2017-08-18 15:38:19 -07:00
Andy 4e570f0784 Revert public API changes to logger (#17901) 2017-08-18 11:31:10 -07:00
Andy eeb40fe863 session.ts: Revert some emptyArray back to undefined (#17781)
* session.ts: Revert some `emptyArray` back to `undefined`

* Fix
2017-08-14 14:58:58 -07:00
Ron Buckton 360dc914c3 Merge pull request #17602 from Microsoft/multiInferredProjects
Adds support for inferred project isolation by projectRootPath
2017-08-11 16:06:49 -07:00
Ron Buckton c272c3c5cd Comment update 2017-08-11 16:06:24 -07:00
Andy f64b8ad902 Add "preserveSymlinks" option (#16661)
* Add "preserveSymlinks" option

* Respond to PR comments
2017-08-11 10:03:21 -07:00
Ron Buckton b031777566 PR Feedback 2017-08-10 17:43:22 -07:00
Andy 08fbcd8b80 Fix many no-object-literal-type-assertion lint errors (#17278)
* Fix many no-object-literal-type-assertion lint errors

* Simple fixes

* Use a union for FlowNode

* PR feedback and remove remaining `id()` uses

* Use a union for CodeBlock

* Discriminate CodeBlock by CodeBlockKind
2017-08-10 12:52:15 -07:00
Andy f124e19971 Session: don't return undefined if a response is required (#17165)
* Session: don't return undefined if a response is required

* Use ReadonlyArray and emptyArray

* Remove inferred return type
2017-08-09 13:46:47 -07:00
Andy b8c37bb50c Inline childFromLineNumber and childFromCharOffset (#17018)
* Inline childFromLineNumber and childFromCharOffset

* Handle empty document -- root node with 0 children

* Fix test
2017-08-09 13:43:25 -07:00
Andy bd68122821 scriptVersionCache: Export less (#17202)
* scriptVersionCache: Export less

* Remove LineIndexForTest, use LineIndex

* Add /* @internal */ to class LineIndex

* Make CharRangeSelection a const enum
2017-08-09 10:59:10 -07:00
Ron Buckton 37b9b7089c PR Feedback 2017-08-08 17:23:50 -07:00
Andy d99a492ddd Simplify server logger (#17271)
* Simplify server logger

* Move function printProjects out of inner closure
2017-08-08 11:22:22 -07:00
Andy 5141ce751d Deduplicate unresolvedImports (#17248)
* Deduplicate unresolvedImports

* Add `isNonDuplicateInSortedArray` helper
2017-08-08 11:02:10 -07:00
Andy f69ce5c0c8 Convert two arrays to readonly (#17685) 2017-08-08 10:54:18 -07:00
Andy e1802f4966 MultistepOperation: Don't need 'completed', just use requestId === undefined (#17173)
* MultistepOperation: Don't need 'completed', just use `requestId === undefined`

* Check for `requestId !== undefined`
2017-08-08 10:49:49 -07:00
Andy ceae613e4c Add lint rule to check that Debug.assert calls do not eagerly interpolate strings (#17125)
* And lint rule to check that `Debug.assert` calls do not eagerly interpolate strings

* Use more specific 'assert' functions to avoid callbacks

* Respond to PR feedback
2017-08-08 07:56:14 -07:00
Andy a9a30d76fb Fix parsing of globalPlugins and pluginProbeLocations: Don't include empty string (#17143) 2017-08-08 07:55:03 -07:00
Andy 382785a528 Fix logging of module resolution errors (#17144) 2017-08-08 07:54:08 -07:00
Andy 9ea2350a6d Simplify parameters to updateProjectStructure and updateErrorCheck (#17175) 2017-08-08 07:31:21 -07:00
Ron Buckton fa7f3e85fe Adds support for inferred project isolation by projectRootPath 2017-08-03 16:03:59 -07:00
Andy bb34bce420 Set a high stack trace limit in command-line and server scenarios (#17464) 2017-08-02 12:40:39 -07:00
Sheetal Nandi c9698072d4 Merge pull request #17497 from Microsoft/disposeWatchedDirectoriesOnlyIfPresentMaster
[master] dispose the watched wild card directories only if present
2017-08-02 10:59:34 -07:00
Wesley Wigham 33cc0a1814 Move comparer types to public namespace (#17437)
* Move comparer types to public namespace

* Revert "Move comparer types to public namespace"

This reverts commit a6eab3a740.

* Add internal annotations to things using the Comparer type

* Move to an internal half
2017-08-01 21:39:15 -07:00
Sheetal Nandi 711e890e59 Added | undefined to properties for watching that can be undefined 2017-07-28 14:56:43 -07:00
Sheetal Nandi c2d0d533c4 dispose the watched wild card directories only if present 2017-07-28 14:56:33 -07:00
Andy 3330f2a33b JsTyping: Remove "safeList" global variable (#17304) 2017-07-27 10:54:47 -07:00
Andy 6f90b3112a Make safelist an instance field of ProjectService (#17307) 2017-07-26 13:47:44 -07:00
Andy eee4c618e2 Indent list of open files (#17255) 2017-07-24 13:32:43 -07:00
Andy 7702d15cf3 Add current time to tsserver logs (#17268) 2017-07-24 13:32:23 -07:00
Andy c60774b4c6 Make many 'static' variables readonly (#17306) 2017-07-20 08:54:47 -07:00
Andy d99694614a Simplify use of array helpers (#17301) 2017-07-19 11:23:41 -07:00
Andy d918b8ad4e Remove duplicate helper (#17296) 2017-07-19 11:23:14 -07:00
Andy ea0bce511b MultiStepOperation: No need to create a 'NextStep' object, just use self as the NextStep (#17174) 2017-07-19 07:52:18 -07:00
Andy 08a57d82cd Add 'clear' helper (#17209) 2017-07-18 11:08:44 -07:00
Sheetal Nandi 54dfdd77fb Merge pull request #17210 from Microsoft/readfile
`readFile` may return undefined
2017-07-17 14:39:57 -07:00
Andy 555776eb3c Minor cleanups in builder (#17208)
* Minor cleanups in builder

* Use enumerateInsertsAndDeletes
2017-07-17 12:24:56 -07:00
Andy Hanson 96d537bc54 readFile may return undefined 2017-07-14 15:57:23 -07:00
Andy 680bfbb705 Combine moduleHasNonRelativeName with isExternalModuleNameRelative (#16564) 2017-07-13 13:46:04 -07:00
Andy d2ec45f354 Remove unnecessary 'ts.' qualifications (#17163) 2017-07-13 13:08:59 -07:00
Andy 7b5e1e9c49 Use array helpers instead of 'reduce' (#17172) 2017-07-13 10:43:01 -07:00
Andy efc861c76d Add logging to discoverTypings (#16652) 2017-07-13 07:10:35 -07:00
Andy dbbf051886 Add assertion to computePositionOfLineAndCharacter (#17121) 2017-07-13 06:49:28 -07:00