Daniel Rosenwasser
e832e04fa7
Merge pull request #37727 from Kingwl/logical_assignment
...
Add logical assignment operator
2020-06-09 14:44:08 -07:00
Wesley Wigham
f41398e100
Make isEntityNameVisible duplicate the node builder logic to always consider type parameters as visible if they are the resolution result ( #38921 )
2020-06-09 13:40:17 -07:00
Nathan Shively-Sanders
d841971347
Merge pull request #38358 from a-tarasyuk/bug/38081
...
fix(38081): 'Debug Failure. Invalid cast.' for convert import quick fix
2020-06-09 08:50:56 -07:00
Eli Barzilay
3151e2a365
Make hasCorrectArity handle tuples properly
...
This completes the work that started in PR #33069 , and fixes #32835 .
There are probably two additional related changes that are needed to
make this more complete:
* Fix the code that composes the error message (see the first two
`FIXME`s in `callWithSpread3.ts`).
* Fix the code that checks the argument types (second two `FIXME`s).
* There is also an error in `genericRestParameters1.ts` which changed
but should not be an error in the first place. Added a `FIXME` there
too. (Probably will work if the previous iterm is done.)
In addition, `getEffectiveCallArguments` munges the arguments in case of
a spread in the last argument which might be better to avoid. (I think
that there are cases where it wouldn't work anyway, such as a spread of
an array followed by a spread of an empty array.)
2020-06-04 23:46:56 -04:00
rchaser53
261386d48b
fix error when use spread arguments twice
2020-06-04 23:46:56 -04:00
Eli Barzilay
4ee013d1a7
Fix merging of JS value & TS type decl
...
Fixes #38383
2020-06-04 19:28:33 -04:00
Eli Barzilay
a4c14a2cdc
getSymbolDisplayPartsDocumentationAndSymbolKind: use actual symbol.flags for getAliasedSymbol
...
Fixes #35347 .
2020-06-04 13:50:33 -04:00
Jesse Trinity
3b15b35b37
Merge pull request #38378 from jessetrinity/refactorTriggerReason
...
Add RefactorTriggerReason
2020-06-03 11:18:08 -07:00
Eli Barzilay
073fb308bf
Fix two tests
...
* `docCommentTemplateInSingleLineComment`: Accidentally dropped space, fixes #38651
* `codeFixCorrectReturnValue13`: Bogus test code copied
2020-06-03 12:59:16 -04:00
Jesse Trinity
d88ea4e1f8
address PR comments
2020-06-02 19:06:12 -07:00
Jesse Trinity
463f8e10b9
Merge pull request #38734 from a-tarasyuk/bug/34934
...
fix(34934): Completions for private members appear in JavaScript files
2020-06-02 12:47:17 -07:00
Alexander T
bc502c8c3c
fix(38081): allow transforming object binding to named imports
2020-06-02 11:23:56 +03:00
Jesse Trinity
52dad733db
Merge branch 'master' into m-lambda-to-fn
2020-06-01 13:53:19 -07:00
8e290e5aae
Improve error range for ts2657 (jsx expr must have parent element), add code fix for it ( #37917 )
...
* fix: range of ts2657 (jsx expr must have parent) and remove 2695 (LHS expr of comma has no side effects)
* feat: add code fix for 2657
* fix: resolve review
* chore: hoist a var
* chore: add test for skipTrivia
* fix: rebase error
* Update src/compiler/diagnosticMessages.json
Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com >
* Update src/services/codefixes/wrapJsxInFragment.ts
Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com >
Co-authored-by: Andrew Branch <andrew@wheream.io >
Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com >
2020-06-01 12:22:44 -07:00
Alexander T
4f0b81d415
fix(32341): add prefix name for module exports properties ( #38541 )
2020-06-01 11:45:05 -07:00
Alexander T
fa49ac0b78
fix(19385): add space after brace in the multiline string template ( #38742 )
2020-06-01 10:30:52 -07:00
Alexander T
68d2ee055c
fix(38815): dive in arrow functions to check only this usage instead of checking all statements ( #38865 )
2020-06-01 10:27:11 -07:00
Jesse Trinity
a86a2fa703
polish tests
2020-05-29 13:03:14 -07:00
Jesse Trinity
2db0054444
remove outdated tests
2020-05-29 13:03:11 -07:00
Jesse Trinity
f479279217
convert import trigger reason test
2020-05-29 13:03:08 -07:00
Jesse Trinity
c20908a3e7
convert export trigger reason test
2020-05-29 13:03:01 -07:00
Jesse Trinity
4971c7d546
remove declaration
2020-05-29 13:02:55 -07:00
Jesse Trinity
3e1e61470b
Revert "update refactorConvertImport_partialSelection"
...
This reverts commit e28d8a0895f118321c37016a6dad4751a7c13673.
2020-05-29 13:02:52 -07:00
Jesse Trinity
86122c412f
convert get set test
2020-05-29 12:55:52 -07:00
Jesse Trinity
673a86833a
update test names
2020-05-29 12:55:48 -07:00
Jesse Trinity
3825d193f6
extract symbol test
2020-05-29 12:55:43 -07:00
Jesse Trinity
df8ff659c5
extract type test
2020-05-29 12:55:39 -07:00
Jesse Trinity
85e0d8b14a
add refactorNotAvailableForTriggerReason
2020-05-29 12:55:35 -07:00
Jesse Trinity
dc363f10fc
fix some indices
2020-05-29 12:55:32 -07:00
Jesse Trinity
fbf6737ae2
use verify trigger reason for import export
2020-05-29 12:55:28 -07:00
Jesse Trinity
96f210c1c8
arrow function refactor test
2020-05-29 12:55:24 -07:00
Jesse Trinity
f3751fbdf3
change type of RefactorTriggerReason
2020-05-29 12:54:59 -07:00
Jesse Trinity
665e434832
convert import tests
2020-05-29 12:50:18 -07:00
Jesse Trinity
57e856b0b4
convert export tests
2020-05-29 12:50:14 -07:00
Jesse Trinity
c5343f1d4e
update refactorConvertImport_partialSelection
2020-05-29 12:46:03 -07:00
Daniel Rosenwasser
6128f30c3b
Merge pull request #38821 from a-tarasyuk/bug/23716
...
fix(23716): signature help of tagged template doesn't show instantiated signature
2020-05-28 17:19:23 -07:00
BigAru
e6dc8f6c69
Merge remote-tracking branch 'upstream/master' into m-lambda-to-fn
2020-05-27 20:33:27 +02:00
Nathan Shively-Sanders
bfa1744586
Merge pull request #37894 from microsoft/always-error-on-property-override-accessor
...
Always error on property override accessor
2020-05-26 10:37:07 -07:00
Alexander T
6e98431cec
fix(23716): show generic type in tagged template expression
2020-05-26 19:16:44 +03:00
Nathan Shively-Sanders
324d292e3d
Merge pull request #38415 from Kingwl/navTree-fix
...
Fix trancked es5 classes after new scope
2020-05-26 09:05:17 -07:00
Anders Hejlsberg
c5b8f4fcd4
Fix relation between generic mapped types and types with index signatures ( #38761 )
...
* Fix relation between generic mapped type and type with index signature(s)
* Add tests
2020-05-25 09:55:41 -07:00
Nathan Shively-Sanders
e466bb94c1
Fix multi-file usage
...
1. Follow aliases with getSupers.
2. Make fix in file with superclass, not with the error.
2020-05-22 09:06:05 -07:00
Alexander T
4c278aa33b
fix(34934): exclude private properties from Js completion list
2020-05-22 15:11:39 +03:00
Nathan Shively-Sanders
802e87b1eb
Merge branch 'master' into always-error-on-property-override-accessor
2020-05-21 16:08:09 -07:00
Daniel Rosenwasser
62675a58d6
Merge pull request #38481 from a-tarasyuk/bug/38463
...
fix(38463): No indexed access completions after Record<...>
2020-05-21 13:44:44 -07:00
Alexander T
c00aeb5486
fix(33286): add outlining for arrow function with one parameter ( #38631 )
2020-05-21 08:07:47 -07:00
Alexander T
e40a2bca57
Merge branch 'master' of https://github.com/microsoft/TypeScript into bug/38463
2020-05-21 16:33:35 +03:00
kingwl
b73411c985
Fix type and simplify code
2020-05-21 10:19:36 +08:00
Nathan Shively-Sanders
fc83d10388
Merge branch 'master' into diagnose-accidental-accessor-call
2020-05-20 16:46:34 -07:00
Nathan Shively-Sanders
3340142dda
Merge pull request #38607 from a-tarasyuk/bug/38295
...
fix(38295): Duplicated object key in const not detected when the key is a number preceded by `-` or `+`
2020-05-20 14:52:09 -07:00