Andrew Branch
e81fa2198d
Emit error on class fields named "constructor"
2019-04-25 17:30:41 -07:00
Andrew Branch
9f601ff154
Change error code
2019-04-25 16:15:00 -07:00
Andrew Branch
c5e6913ede
Add grammar error on quoted constructors for TS 3.5
2019-04-25 15:44:23 -07:00
Andrew Branch
4b81e37941
Merge pull request #31093 from andrewbranch/bug/30997
...
Fix crash getting error for type alias index signature without a type
2019-04-24 11:36:38 -07:00
Sheetal Nandi
f27cf9b34e
Merge pull request #30971 from Microsoft/dtsSignatureChange
...
Handle when change in type of dts may result in only dts emit but not js emit
2019-04-24 11:16:22 -07:00
Andrew Branch
956436853e
Fix crash getting error for type alias index signature without a type
2019-04-24 10:35:23 -07:00
Ron Buckton
e2310f2831
Merge pull request #26151 from Kingwl/PropertyDeclarationExclamationToken
...
visit exclamation token
2019-04-23 21:21:58 -07:00
Ron Buckton and Kingwl
6e0b39e399
Update src/compiler/visitor.ts
...
Co-Authored-By: Kingwl <kingwenlu@gmail.com >
2019-04-23 21:27:06 -05:00
Wesley Wigham
d7f03fb0fa
Parse generic function types in import type argument lists ( #31079 )
...
* Parenthesize in import type node factory
* And now parse unparenthesized generic functions so we can handle parsing the older output
2019-04-23 14:48:31 -07:00
David Sherret
8fc6640f55
Rename _objectLiteralBrandBrand to _objectLiteralBrand. ( #30797 )
2019-04-23 14:33:54 -07:00
Wenlu Wang
27075555c8
fix generate typenode from negative numerical literal ( #30610 )
2019-04-23 14:20:53 -07:00
Ryan Cavanaugh
885d4d63c8
Remove "generate types" code ( #31075 )
2019-04-23 13:51:47 -07:00
Wesley Wigham
b47194bfa1
Fix contextual types for a single jsx child ( #31040 )
2019-04-23 13:51:39 -07:00
Andrii Dieiev
54fa950757
Skip primitive types comparison with array and object types ( #31077 )
2019-04-23 13:49:32 -07:00
Wesley Wigham
b02b823f03
Track parameter references errors in resolve name rather than secondary pass ( #30349 )
2019-04-23 13:46:19 -07:00
Klaus Meinhardt
760393f893
fix false positive 'variable is used before being assigned' in destructuring ( #29636 )
...
Fixes : #29458
2019-04-23 13:22:37 -07:00
Matt McCutchen
6487d1ffe0
Remove the rule that replaces a union of literal types with the base type when comparing equality to a type that isn't a union of literal types. ( #27588 )
...
type when comparing equality to a type that isn't a union of literal
types.
The rule is redundant because a primitive type is already directed-
comparable to a value of that primitive type, and it causes errors to be
missed when comparing a type parameter _constrained_ by a union of
literal types to another union of literal types.
The baseline changes look like improvements to me.
Fixes #26758 .
2019-04-23 12:59:07 -07:00
Wenlu Wang
bd178746de
improve error message when type have same name ( #27065 )
...
* improve error message when type have same name
* fix lint and function name
* update test case
* accept baseline
2019-04-23 12:56:03 -07:00
Daniel Rosenwasser
c74d25c115
30837 - Bad error message when default 'import'-ing an 'export =' without 'esModuleInterop' ( #30847 )
...
30837 - Bad error message when default 'import'-ing an 'export =' without 'esModuleInterop'
2019-04-23 11:23:06 -04:00
Daniel Rosenwasser
6427711f99
Better erreor messages for properties mis-handled as shorthand property declarations ( #31039 )
...
Better erreor messages for properties mis-handled as shorthand property declarations
2019-04-22 16:14:21 -04:00
Wesley Wigham
7a3e68fc5c
Only return the substitute in substitution instantiation when assignability fails (rather than subtype) ( #31027 )
...
* Only return the substitute in substitution instantiation when assignability fails (rather than subtype)
* Add test from issue
2019-04-19 16:02:11 -07:00
Wesley Wigham
40a2eb2b4b
Unify couldContainTypeVariables and the similar check done during instantiation ( #30969 )
...
* Stop symbol based filtering in couldContainTypeVariables
* Unify couldContainTypeVariables and the similar check done during instantiation
2019-04-19 16:01:53 -07:00
Wesley Wigham
1a4c15fb11
handle generic types in getArrayifiedType ( #30606 )
2019-04-19 14:32:33 -07:00
karthikkp
181d126b02
diagnostic messages conflicts resolved
2019-04-20 01:38:17 +05:30
Daniel Rosenwasser
2eea21636b
Merge pull request #29242 from Kingwl/attach_property_to_default_export
...
add transformer for emit add property to default export
2019-04-18 23:30:48 -04:00
Andrew Branch
b6a0988052
Merge pull request #30776 from andrewbranch/feature/10178
...
Add flag to allow access to UMD globals from modules
2019-04-18 18:05:44 -07:00
Nathan Shively-Sanders
c3a9429420
Handle JSDoc backticks in the parser, not scanner ( #30939 )
...
* Scan backticks in jsdoc as a single token less often
Previously, matching backticks in jsdoc would always be scanned as one
token to aid parsing incorrect jsdoc that uses backticks for parameter
names:
``js
/** @param {string} `nope`
* @param {number} `not needed`
*/
```
However, this is wrong for code fences, which use triple backticks. This
fix parses a single backtick as a single token if it's immediately
followed by another backtick or by a newline. It retains the
questionable tokenisation of backticks-as-pairs in other cases, however.
A better fix might be to have the parser ignore backticks in jsdoc
instead.
* Add test case
* Handle jsdoc backticks in the parser, not scanner
Previously, the jsdoc scanner had ad-hoc handling of backticks that was
similar in structure to the normal scanner's handling, but much simpler.
This was a smaller code change, but is handled backwards: the special
case of backtick-quoted parameter names was handled in the scanner
instead of in the jsdoc identifier parsing code. That made it overapply
and block correct handling of asterisks across newlines, which was most
obvious in code fences inside jsdoc, as in #23517 .
Fixes #23517
* More cleanup
2019-04-18 09:35:40 -07:00
Anders Hejlsberg
33c3ce9cd0
Merge pull request #31002 from Microsoft/fixIsStringIndexSignatureOnlyType
...
Fix isStringIndexSignatureOnlyType function
2019-04-17 17:19:34 -07:00
Sheetal Nandi
d5100bb95e
Merge branch 'master' into dtsSignatureChange
2019-04-17 16:36:09 -07:00
Sheetal Nandi
4a55025f20
Code review feedback
2019-04-17 16:32:33 -07:00
Sheetal Nandi
0c18d032e7
Merge branch 'master' into incrementalLateSymbol
2019-04-17 15:41:53 -07:00
Sheetal Nandi
b9145f98e1
Merge pull request #30980 from Microsoft/configChangeForEmit
...
Make sure to emit again if change in compiler option affects emit
2019-04-17 15:14:12 -07:00
Anders Hejlsberg
a40b08d1d7
Merge pull request #30944 from Microsoft/fixInferenceToMappedType
...
Fix inference from enum object type to generic mapped type
2019-04-17 15:10:34 -07:00
Anders Hejlsberg
9b3b8e3203
Ignore generic mapped types in isStringIndexSignatureOnlyType
2019-04-17 14:59:28 -07:00
Nathan Shively-Sanders
4420d1083b
Add diagnostics for relation cache size ( #30999 )
...
* Add diagnostics for relation cache size
* Move to extendedDiagnostics
* Single method that returns a 3-property object
* Fix double-space lint
2019-04-17 14:32:18 -07:00
Anders Hejlsberg
50fdeccd7f
One more iteration
2019-04-17 13:58:05 -07:00
Sheetal Nandi
3af78ae77a
Revert and always use merged symbol to get members of late bound symbol
...
Fixes #30891
2019-04-17 12:58:12 -07:00
Wesley Wigham
169e485d90
Perform excess property checking on intersection and union members ( #30853 )
...
* Perform excess property checking on intersection and union members
* Allow partial union props to contain the undefined type
* Add test case from #30771
* Un-terse getPossiblePropertiesOfUnionType side-effecting code
* Fix bug exposed in RWC
* Cache results of getPossiblePropertiesOfUnionType
* Fix whitespace
2019-04-16 21:58:48 -07:00
Anders Hejlsberg
3435451dcc
Even more succinct
2019-04-16 18:26:24 -07:00
Anders Hejlsberg
efa16ac11f
Address CR feedback
2019-04-16 17:41:33 -07:00
Sheetal Nandi
15ae8a7273
Make sure to emit again if change in compiler option affects emit
...
Fixes #30736
2019-04-16 16:18:37 -07:00
Sheetal Nandi
ae7e00e741
Combine semantic diagnostics of files using exported entities from modules and their dts emit
2019-04-16 14:18:03 -07:00
Sheetal Nandi
17d2c8bcfb
Handle dts change as well as signature update when exported module affects dts but not js file
2019-04-16 13:27:51 -07:00
Sheetal Nandi
db8c6ee67a
When exported types from module change, the modules exporting these types indirectly mean d.ts change too (not just semantic diagnostics)
2019-04-16 13:05:23 -07:00
Sheetal Nandi
0be9a22dbf
Remove unnecessary check since seenEmittedFiles is set when getting pending affected files
2019-04-16 12:53:45 -07:00
Sheetal Nandi
3c67608715
When interfaces are merged, always ensure that the parent symbol of the late bound member symbol is declared symbol containing the node.
...
Ensure that resolvedMembers adds the late bound symbol even when its resolved sunce lateBoundMember may or may not be added to resolved members depending on when its checked
Fixes #30891
2019-04-16 12:36:46 -07:00
Anders Hejlsberg
f617d1641b
Merge pull request #30963 from Microsoft/fixObjectFlagsPropagation
...
Fix object flags propagation
2019-04-16 07:25:41 -10:00
Anders Hejlsberg
6ac0dbcaef
Propagate ObjectFlags.NonInferrableType through widening
2019-04-16 09:46:45 -07:00
Alexander T
f5d4e66451
Bad error message when default 'import'-ing an 'export =' without 'esModuleInterop'
2019-04-16 14:39:16 +03:00
Wesley Wigham
d405662eb6
Explicitly encode keyof behaviors for never and unknown into getIndexType ( #30753 )
...
* Explicitly encode keyof behaviors for never and unknown into getIndexType
* Merge similar cases
2019-04-15 17:52:13 -07:00