Commit Graph

934 Commits

Author SHA1 Message Date
Sheetal Nandi dcbd7b10f1 Combine the logic to find config file as well as the watch.
This should speed up the file open scenarios where the file belongs to same configured project as we would use cache to answer those fileExists answers
2017-07-15 22:26:10 -07:00
Sheetal Nandi 62663a10ba Use map for configured project instead of the array 2017-07-15 20:12:50 -07:00
Sheetal Nandi 0572b15adc Instead of watching directories, watch tsconfig files of inferred project root 2017-07-15 19:11:27 -07:00
Sheetal Nandi 00011a52af Refactor root files addition/update for non inferred project 2017-07-15 15:21:14 -07:00
Sheetal Nandi f12980dd20 Remove the duplcate error about no input files found 2017-07-15 13:37:22 -07:00
Sheetal Nandi 71d79c62d0 Some refactoring to combine files removal from inferred project 2017-07-15 11:37:32 -07:00
Sheetal Nandi 404aa8f0be Logging of the watch add/remove/event 2017-07-14 17:39:42 -07:00
Sheetal Nandi 0365901381 use single instance of getCanonicalFileName 2017-07-13 15:32:11 -07:00
Sheetal Nandi 048e67c021 Merge branch 'master' into watchImprovements 2017-07-13 14:13:14 -07:00
Andy d2ec45f354 Remove unnecessary 'ts.' qualifications (#17163) 2017-07-13 13:08:59 -07:00
Sheetal Nandi e568976239 Allows the delayed update graph and project structure which helps in batching the updates when there are multiple files added/removed/changed 2017-07-13 11:32:40 -07:00
Andy 7b5e1e9c49 Use array helpers instead of 'reduce' (#17172) 2017-07-13 10:43:01 -07:00
Andy efc861c76d Add logging to discoverTypings (#16652) 2017-07-13 07:10:35 -07:00
Andy dbbf051886 Add assertion to computePositionOfLineAndCharacter (#17121) 2017-07-13 06:49:28 -07:00
Sheetal Nandi 8fedcf78c7 TODOs for the scheduling update graph and referesh projects 2017-07-12 19:34:01 -07:00
Sheetal Nandi f338a70257 Remove the done TODO 2017-07-12 13:39:11 -07:00
Sheetal Nandi 029b1f25e4 Fixes the fourslash runner tests by handling hosts that cannot support read directory or getDirectories 2017-07-12 12:50:52 -07:00
Andy 2368847f6b Indent filesToString (#17130) 2017-07-12 10:42:05 -07:00
Andy 38db79d666 buildTreeFromBottom: Really simplify loop (#17105) 2017-07-12 09:59:29 -07:00
Sheetal Nandi 68def1b1f3 Use the cached file exists/directory exists for configured project since we watch the needed files 2017-07-11 23:23:53 -07:00
Sheetal Nandi 19a6a003f5 Cache the read directory results so that it doesnt end up reading it all the time 2017-07-11 17:50:51 -07:00
Andy 08030c7d02 Convert most of core.ts to accept ReadonlyArray (#17092)
* Convert most of core.ts to accept ReadonlyArray

* Fix lint

* Fix isArray
2017-07-11 17:39:33 -07:00
Sheetal Nandi 48c651317e Update types instantly when the type root changes. 2017-07-11 14:18:56 -07:00
Sheetal Nandi 62871cc0f9 Only update file list when there are changes in the watched directories 2017-07-11 14:10:48 -07:00
Andrew Casey 6ed94b1d43 Merge pull request #17083 from amcasey/Vsts461481
Correct FileWatcherEventKind in server polling method
2017-07-11 10:16:09 -07:00
Andy 1408109487 buildTreeFromBottom: simplify loop (#17091) 2017-07-11 09:40:02 -07:00
Andrew Casey 911f1f88ee Correct FileWatcherEventKind in server polling method
Was sending Changed on Creation.

Caveat: the tests will probably still fail intermittently with a race -
this just fixes the deterministic failure.
2017-07-10 19:30:03 -07:00
Andy b8b1fb305a Minor cleanups in scriptVersionCache (#17021) 2017-07-10 15:10:45 -07:00
Andy e29b2106e9 Improvements to LineIndex.edit (#17056) 2017-07-10 15:08:57 -07:00
Sheetal Nandi 9ff9476b4a Handle the deleted file in update graph better, so that in next update it is possible to schedule the update graph of project 2017-07-10 14:59:32 -07:00
Andy 91d7b22e6a Remove ILineInfo type (#17017) 2017-07-10 11:35:54 -07:00
Sheetal Nandi df6f75bc70 Optimize wildcard watchers and config directory watching as now we have missing file watching as well
We dont need to explicitly watch config file directory as it will be watched:
- if there was no files specified, in wild card directories
- if there were files specified as missing file (if the file wasnt present)
2017-07-10 11:31:33 -07:00
Sheetal Nandi 6bd42b81ee When config file is deleted, apart from removing the projecty, reload the configured projects for open files from that project to ensure to pick them by another config file that can be present in parent directory 2017-07-10 11:31:33 -07:00
Sheetal Nandi 96ffd53c2d Reload the configured project only once even though there are multiple files open from that project 2017-07-10 11:31:33 -07:00
Sheetal Nandi 2a63827891 Update the todo list 2017-07-10 11:31:33 -07:00
Sheetal Nandi 75698a893f Add project roots in the list of root files even if they arent present on the disk
This helps in reporting errors as well as syncing of the configured/external project when the files are created
2017-07-10 11:31:33 -07:00
Sheetal Nandi ae33ae894d Restructure updating the configured project from disk and actual project update
Also reload the projects when extra extension in the host change
2017-07-10 11:31:32 -07:00
Sheetal Nandi 21ad26b6ff When opening a file, if it is using existing project, there is no need to update the project by re-reading the config file
This will improve the opening file perf for file opens from same config project
2017-07-10 11:31:32 -07:00
Andy e4a69174db LineNode.add: return value never used (#17016) 2017-07-07 14:00:09 -07:00
Andy 31ce6cfba6 Minor cleanups to ScriptVersionCache (#16983) 2017-07-07 10:49:59 -07:00
Andy dcc3e72636 Use decodeSpan more (#16990) 2017-07-07 10:37:18 -07:00
Andy ee48c1b4cc Minor cleanups to EditWalker (#16980) 2017-07-07 10:36:46 -07:00
Andy d3f4447657 Minor cleanups to LineIndexSnapshot (#16981) 2017-07-07 10:35:21 -07:00
Andy 17578e8a5d Use Map<true> for sets (#16972) 2017-07-07 10:34:36 -07:00
Andy 81f8151e3a Use 'push' and 'pop' methods instead of using array.length (#16979) 2017-07-07 10:22:59 -07:00
Andy ba53b42663 Clean up findChildIndex (#16984) 2017-07-07 10:15:04 -07:00
Andy d4c11bfa1b Clean up creation of 'args' in client.ts (#17009) 2017-07-07 08:09:59 -07:00
Andy e7dc2a67ca Enable "object-literal-shorthand" lint rule (#16987) 2017-07-07 07:26:58 -07:00
Andrew Casey ac72803bb2 Merge pull request #16684 from amcasey/Vsts434619
Watch for the creation of missing files
2017-06-29 13:41:18 -07:00
Andrew Casey 569ecabb0a Address PR feedback
Make Program.getMissingFilePaths required

Assume getMissingFilePaths always returns a defined value

Make getMissingFilePaths internal

Replace nullable-bool with enum

Update type to reflect possibility of undefined

Use deepEqual to simplify tests

Make condition const

Don't bother cleaning up map before freeing it

Switch from foreach to for-of to simplify debugging

Use a Map, rather than a FileMap, to track open FileWatchers

Fix compilation errors

Introduce and consume arrayToSet

Fix lint warnings about misplaced braces

Delete incorrect comment

Delete from map during iteration

Eliminate unnecessary type annotations
2017-06-29 11:29:19 -07:00