Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
33,727 Commits 367 Branches 233 Tags
dcade7732c142abba88eecae78c115fa37b95e01
Commit Graph
24789 Commits
Author SHA1 Message Date
Oleksandr TandGitHub a9797d218d fix(50340): typeof ... === "undefined" check on discriminated union of undefined and object type doesn't narrow correctly (#50344) 
* fix(50340): narrow type by discriminant in typeof

* add additional test cases
 2022-08-31 15:00:50 -07:00
Anders HejlsbergandGitHub 43f8ae6df4 Only normalize intersections that include {} (#50535) 
* Only normalize intersections that include {}

* Accept new baselines
 2022-08-31 14:36:03 -07:00
Sheetal NandiandGitHub d293e723a2 Rename API to importPlugin (#50554) 
* Rename API to importPlugin

* Make it internal too
 2022-08-31 14:21:56 -07:00
Wesley WighamandGitHub 488d0eebd0 Retain name and propertyName in declaration emit copies of binding patterns if property name is a keyword (#50537) 
* Retain name and propertyName in declaration emit copies of binding patterns if property name is a keyword

* Accept baselines

* Remove out of date file
 2022-08-30 09:03:02 -07:00
Anders HejlsbergandGitHub 6d170b490d Handle intersections in isGenericTypeWithoutNullableConstraint (#50497) 
* Handle intersections in isGenericTypeWithoutNullableConstraint

* Add regression test
 2022-08-29 09:24:13 -07:00
Alex HsuandGitHub ed6889cd5b LEGO: Merge pull request 50506 
LEGO: Merge pull request 50506
 2022-08-29 03:47:42 -07:00
Alex HsuandGitHub 29cbfe9a25 LEGO: Merge pull request 50493 
LEGO: Merge pull request 50493
 2022-08-28 03:32:25 -07:00
Alex HsuandGitHub 6faa291b45 LEGO: Merge pull request 50484 
LEGO: Merge pull request 50484
 2022-08-27 03:51:23 -07:00
Joost KoehoornandGitHub 71b2ba6111 Reuse computed type of condition expressions (#49881) 2022-08-27 01:40:13 -07:00
Oleksandr TandGitHub 4579245f36 fix(50427): allow convert function expressions (#50430) 2022-08-26 15:43:19 -07:00
Oleksandr TandGitHub bb3a7aec11 fix(50415): Language server debug failure - Did not expect GetAccessor to have an Identifier in its trivia (#50470) 
* fix(50415): clone props for get/set accessors

* add additional tests

* create helpers to create name, body, modifiers, typeName

* cleanup
 2022-08-26 14:33:23 -07:00
Ryan CavanaughandGitHub 3557092b14 Rephrase error message to be 100% technically correct (#50471) 2022-08-26 14:22:49 -07:00
Long HoGitHublong.ho
 		71d1911503 add unknown to DateTimeFormatTypes (#50402) 
* add unknown to DateTimeFormatTypes

* move unknown to es2019.intl instead

* Accepted baselines.

Co-authored-by: long.ho <long.ho@cloudkitchens.com>
 2022-08-26 13:02:44 -07:00
Anders HejlsbergandGitHub 6e8337ef70 Optimize substitution types (#50397) 
* Optimize substitution type infrastructure

* Accept new baselines

* Preserve instantiated substitution types for type variables

* Restrictive type parameters should have no constraint

* Fix issues from top100 test run

* Accept new baselines
 2022-08-26 12:06:06 -07:00
Jake BaileyandGitHub 226dd0b7bf Fix typechecking related lints that changed post 4.8, update LKG to 4.8.2 (#50472) 2022-08-26 11:41:45 -07:00
Oleksandr TGitHubRyan Cavanaugh
 		164dddc48e feat(7481): Operator to ensure an expression is contextually typed by, and satisfies, some type (#46827) 
* feat(7481): add explicit type compatibility check with 'satisfies' expression

* Add failing test for lack of intersectioned contextual type

* Implement the behavior

* Add test corresponding to the 'if'

* Add test based on defined scenarios

* remove isExpression in favor of using type casting

* move tests from compiler to conformance folder

* update baseline

* add missing contextFlags argument

* use asserted type

* accept baseline

Co-authored-by: Ryan Cavanaugh <ryanca@microsoft.com>
 2022-08-26 10:05:52 -07:00
Andrew BranchandGitHub 38076df346 Fix auto import crash due to difference in paths handling (#50419) 2022-08-25 13:02:48 -07:00
Oleksandr TandGitHub 12eb519b3f fix(50435): Duplicate seeming Code Actions for convert const to let (#50442) 
* fix(50435): omit fix all in constToLet QF

* add FixAll action
 2022-08-25 13:01:46 -07:00
DanayGitHubDanay Fernandez AlfonsoAndrew Branch
 		a08b045d2b Jsdoc property description (#50269) 
* jsdocPropertyDescription

* jsdocPropertyDescription

* jsdocPropertyDescription

* Fixes #47933

* added additional test

* added additional example

* fixed bug

* changed function to only grab the literal type

* added additional condition for literals and symbols

* added additional test cases

* Update src/services/symbolDisplay.ts

Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>

* addressed PR review

* addressed new PR review

Co-authored-by: Danay Fernandez Alfonso <t-danayf@microsoft.com>
Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
 2022-08-25 11:57:32 -07:00
Oleksandr TandGitHub 8d7ad8c3ae fix(50375): Errors for missing enum-named properties should attempt to preserve names (#50382) 
* fix(50375): preserve enum-named properties

* add AllowComputedPropertyEnums option

* use bit shifting

* rename AllowComputedPropertyEnum -> WriteComputedProps

* mark WriteComputedProps as internal

* mark symbolToNode as internal
 2022-08-24 11:54:44 -07:00
Daniel RosenwasserandGitHub fb717df6bf Discard union types before considering weak type checks on unit-like types (#50423) 
* Only check isUnitType when dealing with non-unions.

* Add test case.

* Accepted baselines.
 2022-08-24 11:39:00 -07:00
Sheetal NandiandGitHub b9a5bbc9af Syntax operations also need to ensure project is present for the open script infos since update could be pending to make sure open script info has project (#50418) 
Also convert one relevant test case to baseline
Fixes #50131
 2022-08-24 10:28:23 -07:00
Oleksandr TandGitHub 44ce3cff70 fix(50224): Intellisense for strings within a type's Union doesn't work properly for JSX (#50231) 
* fix(50224): show string literal completions in JsxAttributeInitializer

* add feedback changes
 2022-08-23 14:59:10 -07:00
Daniel RosenwasserandGitHub 4605d89064 Use a mapped type to enforce type-safety on forEachChild. (#50409) 2022-08-22 17:30:44 -07:00
Jake BaileyandGitHub 6362fb2dce Replace eslint rulesdir with eslint-plugin-local, convert eslint rules to JS (#50380) 2022-08-22 13:46:03 -07:00
Ron BucktonandGitHub aaa4f9d9ff Make canHaveModifiers/Decorators public (#50399) 2022-08-22 15:01:17 -04:00
Daniel RosenwasserandGitHub 76357ba802 Swap forEachChild to use a table of functions instead of a switch statement. (#50225) 
* Swap `forEachChild` to use an array of functions instead of a `switch` statement.

* Let's see if 'new' changes anything.

* Co-locate each assignment into `forEachChildTable`.

* Try `push`ing undefined to create a packed Array.

* Try using an unconditional no-op function.

* `forEach` -> `forEachChildIn`

* Remove the optional chain if we are pre-filling with no-ops.

* Grab function directly to avoid possible `.call` overhead from downlevel emit.

* Swap to object literal.

* Lints and formatting.
 2022-08-21 17:48:45 -07:00
Alex HsuandGitHub 38e91fb120 LEGO: Merge pull request 50389 
LEGO: Merge pull request 50389
 2022-08-21 03:07:27 -07:00
Ron BucktonandGitHub 284837d66b Fixes for decorators property deprecations (#50343) 
* Change type of deprecated 'decorators' property

* fix 'Invalid Arguments' error for create/update constructor in factory

* Update deprecation comments

* Make 'decorators' optional and 'undefined'

* Rename '_decorators' to 'illegalDecorators'

* Update baselines
 2022-08-19 14:27:26 -04:00
Oleksandr TandGitHub 5969ae9ef7 fix(50075): do not strip undefined from the function class properties (#50169) 2022-08-19 09:34:42 -07:00
Wesley WighamandGitHub 05d7d6bb12 Unify default import resolution across specifier target codepaths (#49814) 
* Unify default import resolution across specifier target codepaths

* Use differing type aliases, per request
 2022-08-19 02:25:41 -07:00
Sheetal NandiandGitHub 1f0f7c8246 If resolvedFileName differs with realPath only in casing use the resolvedFileName before realpath so that errors can be reported with forceConsistentCasingInFileNames (#50364) 
* Add tests when realpath supresses the casing error

* Fix when real path results in value that differs only in case
Fixes #49470

* Comment
 2022-08-18 14:51:46 -07:00
Kyℓe HenselandGitHub ea36fb3d5f mark Intl.LocalesArgument as readonly (#50135) 2022-08-18 14:38:41 -07:00
Ron BucktonandGitHub 1592210673 Add a jump-table for visitEachChild (#50266) 
* Add a jump-table for visitEachChild

* Name each visitor function for better stack traces

* Fix node tests and some minor cleanup
 2022-08-18 15:03:17 -04:00
Daniel RosenwasserandGitHub 7bafbeae90 Add fourslash function for validating syntactic classification (#50362) 2022-08-18 11:28:08 -07:00
Alex HsuandGitHub 42165a183a LEGO: Merge pull request 50353 
LEGO: Merge pull request 50353
 2022-08-18 03:12:12 -07:00
Alex HsuandGitHub 15f7b6f687 LEGO: Merge pull request 50337 
LEGO: Merge pull request 50337
 2022-08-17 03:02:07 -07:00
DetachHeadGitHubDetachHeadNathan Shively-Sanders
 		3b80ddca21 fix first match in RegExpMatchArray being possibly undefined when noUncheckedIndexedAccess is enabled (#49682) 
* fix first match in `RegExpMatchArray` being possibly undefined when `noUncheckedIndexedAccess` is enabled

* fix tests

* add test

Co-authored-by: DetachHead <detachhead@users.noreply.github.com>
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
 2022-08-16 10:12:12 -07:00
Andrew BranchandGitHub 330e33cdda Ignore related info in diagnostic deduplication (#50309) 
* Ignore related info in diagnostic deduplication

* Add another test
 2022-08-16 09:28:59 -07:00
Babak K. ShandizGitHubAndrew Branch
 		f24f74eb89 🔨 Fix missing "Implement interface" code fix for mapped types with implicit keyof T in their definition (#49999) 
* ⚗️ Add test to verify code fix works when implementing a mapped type with indirect keyof

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🔨 Add property as implementation for symbols that has no declaration

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

diff --git a/src/services/codefixes/helpers.ts b/src/services/codefixes/helpers.ts
index 94b64e57..a4c11fd5 100644
--- a/src/services/codefixes/helpers.ts
+++ b/src/services/codefixes/helpers.ts
@@ -60,21 +60,19 @@ namespace ts.codefix {
         isAmbient = false,
     ): void {
         const declarations = symbol.getDeclarations();
-        if (!(declarations && declarations.length)) {
-            return undefined;
-        }
+        const declaration = declarations ? declarations[0] : undefined;
         const checker = context.program.getTypeChecker();
         const scriptTarget = getEmitScriptTarget(context.program.getCompilerOptions());
-        const declaration = declarations[0];
+        const kind = declaration?.kind ?? SyntaxKind.PropertySignature;
         const name = getSynthesizedDeepClone(getNameOfDeclaration(declaration), /*includeTrivia*/ false) as PropertyName;
-        const visibilityModifier = createVisibilityModifier(getEffectiveModifierFlags(declaration));
+        const visibilityModifier = createVisibilityModifier(declaration ? getEffectiveModifierFlags(declaration) : ModifierFlags.None);
         const modifiers = visibilityModifier ? factory.createNodeArray([visibilityModifier]) : undefined;
         const type = checker.getWidenedType(checker.getTypeOfSymbolAtLocation(symbol, enclosingDeclaration));
         const optional = !!(symbol.flags & SymbolFlags.Optional);
         const ambient = !!(enclosingDeclaration.flags & NodeFlags.Ambient) || isAmbient;
         const quotePreference = getQuotePreference(sourceFile, preferences);

-        switch (declaration.kind) {
+        switch (kind) {
             case SyntaxKind.PropertySignature:
             case SyntaxKind.PropertyDeclaration:
                 const flags = quotePreference === QuotePreference.Single ? NodeBuilderFlags.UseSingleQuotesForStringLiteralType : undefined;
@@ -88,13 +86,16 @@ namespace ts.codefix {
                 }
                 addClassElement(factory.createPropertyDeclaration(
                     modifiers,
-                    name,
+                    declaration ? name : symbol.getName(),
                     optional && (preserveOptional & PreserveOptionalFlags.Property) ? factory.createToken(SyntaxKind.QuestionToken) : undefined,
                     typeNode,
                     /*initializer*/ undefined));
                 break;
             case SyntaxKind.GetAccessor:
             case SyntaxKind.SetAccessor: {
+                if (!declarations) {
+                    break;
+                }
                 let typeNode = checker.typeToTypeNode(type, enclosingDeclaration, /*flags*/ undefined, getNoopSymbolTrackerWithResolver(context));
                 const allAccessors = getAllAccessorDeclarations(declarations, declaration as AccessorDeclaration);
                 const orderedAccessors = allAccessors.secondAccessor
@@ -138,6 +139,10 @@ namespace ts.codefix {
                 // If there is more than one overload but no implementation signature
                 // (eg: an abstract method or interface declaration), there is a 1-1
                 // correspondence of declarations and signatures.
+                if (!declarations) {
+                    break;
+                }
+
                 const signatures = checker.getSignaturesOfType(type, SignatureKind.Call);
                 if (!some(signatures)) {
                     break;

* 🔨 Improve code readability

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

diff --git a/src/services/codefixes/helpers.ts b/src/services/codefixes/helpers.ts
index 2f5c8703ab..aea0206a8a 100644
--- a/src/services/codefixes/helpers.ts
+++ b/src/services/codefixes/helpers.ts
@@ -60,7 +60,7 @@ namespace ts.codefix {
         isAmbient = false,
     ): void {
         const declarations = symbol.getDeclarations();
-        const declaration = declarations ? declarations[0] : undefined;
+        const declaration = declarations?.[0];
         const checker = context.program.getTypeChecker();
         const scriptTarget = getEmitScriptTarget(context.program.getCompilerOptions());
         const kind = declaration?.kind ?? SyntaxKind.PropertySignature;
@@ -93,9 +93,7 @@ namespace ts.codefix {
                 break;
             case SyntaxKind.GetAccessor:
             case SyntaxKind.SetAccessor: {
-                if (!declarations) {
-                    break;
-                }
+                Debug.assertIsDefined(declarations);
                 let typeNode = checker.typeToTypeNode(type, enclosingDeclaration, /*flags*/ undefined, getNoopSymbolTrackerWithResolver(context));
                 const allAccessors = getAllAccessorDeclarations(declarations, declaration as AccessorDeclaration);
                 const orderedAccessors = allAccessors.secondAccessor
@@ -139,10 +137,7 @@ namespace ts.codefix {
                 // If there is more than one overload but no implementation signature
                 // (eg: an abstract method or interface declaration), there is a 1-1
                 // correspondence of declarations and signatures.
-                if (!declarations) {
-                    break;
-                }
-
+                Debug.assertIsDefined(declarations);
                 const signatures = type.isUnion() ? flatMap(type.types, t => t.getCallSignatures()) : type.getCallSignatures();
                 if (!some(signatures)) {
                     break;

* 📜 Add comment regarding mapped type children's  missing declaration

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Co-authored-by: Andrew Branch <andrew@wheream.io>
 2022-08-16 09:27:29 -07:00
Andrew BranchandGitHub 4e33e0eb6c Make literal types not comparable to weak object types without property overlap (#49865) 2022-08-15 17:10:11 -07:00
Andrew BranchandGitHub 64ee1e88e0 Strip literal freshness of contextually typed literals (#49884) 
* Strip literal freshness of contextually typed literals

* Add more tests
 2022-08-15 17:04:09 -07:00
Sheetal NandiandGitHub 9c1baeede6 On windows handle the long paths in realpathSync.native (#50306) 
Fixes #49470
 2022-08-15 16:57:47 -07:00
Wesley WighamandGitHub e989d840f1 Forward intersectionState flag when comparing indexed access constraints (#50261) 2022-08-15 16:10:32 -07:00
Nicolas RodriguezGitHubNathan Shively-SandersAndrew Branch
 		8a873de5cf fix(49149): remove unneeded array overload to Object.freeze (#50029) 
* fix(49149): remove unneeded array overload to Object.freeze

* chore: commit baseline changes

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Co-authored-by: Andrew Branch <andrew@wheream.io>
 2022-08-15 16:10:02 -07:00
Oleksandr TandGitHub 61d8a8d7f3 fix(49629): fix crash in find-all-refs when using module.exports/export= with arrays/primitives (#50291) 2022-08-15 15:14:26 -07:00
Andrew BranchandGitHub bc52ff6f4b Make React import fix not block component import fix (#50307) 
* Stop React import fix from blocking component import fixes

* Add additional promote-type-only test
 2022-08-15 13:13:41 -07:00
Jake BaileyandGitHub fd3c46b2f0 Fix export = error message to not have redundant language (#50308) 2022-08-15 13:13:33 -07:00
Alex HsuandGitHub 03b12a6a45 LEGO: Merge pull request 50298 
LEGO: Merge pull request 50298
 2022-08-14 03:10:53 -07:00
Alex HsuandGitHub 7f5600eec5 LEGO: Merge pull request 50295 
LEGO: Merge pull request 50295
 2022-08-13 05:07:02 -07:00