Commit Graph

19288 Commits

Author SHA1 Message Date
Wesley Wigham dc0f4afe5e Save & recalculate declare flag modifier on late printed statements (#29412)
* Save & recalculate declre flag modifier on late printed statements

* Accept related baseline updates
2019-01-14 13:53:04 -08:00
Sheetal Nandi d4055a3234 Merge pull request #26017 from ajafff/rest-param-destructuring
allow BindingPattern in FunctionRestParameter
2019-01-14 10:58:19 -08:00
Gabriela Britto e5708e1903 Merge pull request #29352 from Microsoft/qualified-name-param-tag-error
Qualified name param tag error
2019-01-14 10:28:08 -08:00
Wesley Wigham fadd95f72b Fix unneeded cast lints (#29383) 2019-01-11 14:24:49 -08:00
Sheetal Nandi 9f19c06dbf Merge pull request #29372 from JoshuaKGoldberg/codefix-enable-decorators
Added codefix to enable experimentalDecorators in the user's config file
2019-01-11 12:45:28 -08:00
Josh Goldberg 7b6adae6dd Extracted compilerOptions setting to helper function 2019-01-11 15:05:24 -05:00
Sheetal Nandi fb99d552ea Merge pull request #29022 from mprobst/no-resolve-libref
Do not process library reference directives with noLib set.
2019-01-11 09:03:46 -08:00
Josh Goldberg 8d28f9230c Added codefix to enable experimentalDecorators in the user's config file
Starts on #29035 by creating a codefix to enable the `experimentalDecorators` setting in a user's config file, if one exists. The issue's discussion also mentions giving a more precise error message if the user has a jsconfig or tsconfig or creating one if not; I'd rather tackle those in separate PRs to keep this one small.

Doesn't create the code action if no config file is present. Otherwise keeps to the precedent of returning without action when the config file contents aren't the expected JSON structure (looking at `fixCannotFindModule.ts`).  Moves a couple JSON helpers from that file into the sibling `helpers.ts` so both codefixes can use them.
2019-01-11 09:20:12 -05:00
Martin Probst 11b150129a Do not process library reference directives with noLib set.
When a user sets `noLib`, this indicates that they will supply their own
list of `lib*.d.ts` files as part of input sources. In this situation,
TypeScript should not try to resolve library reference directives.

This avoids a problem where TypeScript loads a file that e.g. contains
`/// <reference lib="es2015.symbol"/>`. Previously, TypeScript would use
its builtin ts.libMap and attempt to load builtin libraries from the
TypeScript installation, instead of respecting the user-supplied set of
libraries.
2019-01-11 09:02:49 +01:00
王文璐 9d16225bc2 emit jsx type arguments 2019-01-11 13:34:18 +08:00
Wesley Wigham aba0b700b6 Allow circular umd-merged-with-augmentation refs to resolve to the module as intended (#29335) 2019-01-10 14:48:15 -08:00
Wesley Wigham 76f444e338 Allow nonnull assertions in references (#29351) 2019-01-10 14:45:19 -08:00
Gabriela Britto a9ed42f541 Merge branch 'master' into qualified-name-param-tag-error 2019-01-10 09:49:26 -08:00
Anders Hejlsberg 52b82560e8 Merge pull request #29338 from Microsoft/fixConditionalTypeResolution
Fix conditional type resolution
2019-01-09 17:18:12 -08:00
Anders Hejlsberg 70148a4b55 Improve logic that determines when to resolve conditional types 2019-01-09 16:10:28 -08:00
Gabriela Britto dd0a612cc9 Use specific error message for qualified param name without leading top level param name 2019-01-09 16:08:14 -08:00
Gabriela Britto e16be71c08 Add diagnostic message for JSDoc qualified param name without top level param 2019-01-09 15:52:05 -08:00
Wesley Wigham d0aff9bdcd Fix crash (#29333) 2019-01-09 14:23:57 -08:00
Sheetal Nandi 387be1fffa Merge pull request #29316 from Microsoft/randomIdentifier
Verify that completion with new identifier location returns isNewIdentifierLocation: true
2019-01-09 13:01:22 -08:00
Daniel Rosenwasser 6bfb935929 Merge pull request #25445 from a-tarasyuk/bug/24542-bad-error-message-for-import-ing-an-export
24542 - bad error message for `import *`-ing an `export=`
2019-01-09 11:02:14 -08:00
Klaus Meinhardt b52a7fc3ea Exclude JSDoc @extends from 'super()' checks (#29308)
* Exclude JSDoc @extends from 'super()' checks

This fixes a similar problem as #29244 where JSDoc `@extends`

* fix check 'super can only be referenced in a derived class'
2019-01-09 10:35:22 -08:00
Sheetal Nandi 85e6c2f8ab Merge pull request #26280 from Microsoft/tsconfig_canonicalpath
getScriptInfoOrConfig: Canonicalize tsconfig path before lookup
2019-01-08 16:33:34 -08:00
Sheetal Nandi 4c70bf0292 Merge pull request #29313 from Microsoft/getEditsForRename
There is no need to check for file presence when trying to rename imports based on file rename
2019-01-08 16:24:51 -08:00
Sheetal Nandi 46482e14a4 Verify that completion with new identifier location returns isNewIdentifierLocation: true
Fixes #24009

Signed-off-by: Sheetal Nandi <shkamat@microsoft.com>
2019-01-08 16:21:46 -08:00
Sheetal Nandi 76c9d9f717 Fix the failing test case 2019-01-08 16:08:43 -08:00
Sheetal Nandi 1870ee4099 Merge branch 'master' into tsconfig_canonicalpath 2019-01-08 16:04:22 -08:00
Sheetal Nandi 08f738fc42 There is no need to check for file presence when trying to rename imports based on file rename
Fixes #29031
2019-01-08 15:18:52 -08:00
Wesley Wigham 19c72c758a Allow untyped calls on unions of untyped things (#29265) 2019-01-08 11:05:55 -08:00
Alexander T 52057ac4f6 Merge branch 'master' of https://github.com/Microsoft/TypeScript into bug/24542-bad-error-message-for-import-ing-an-export 2019-01-08 10:55:11 +02:00
Alexander T 945eed8d9b PR feedback: change error #2497 message 2019-01-08 10:54:08 +02:00
csigs ec5224f114 LEGO: check in for master to temporary branch. 2019-01-07 16:10:20 +00:00
Sheetal Nandi 93249db692 Use the sourceFile to determine the jsxNamespace at the location for organizingImports
Fixes #28827
2019-01-04 14:12:04 -08:00
Martin Probst 7a2b2cebbf Do not emit code for @extends tags in JS. (#29244)
When transpiling JavaScript, TS3.1+ emits `@extends` tags as code. E.g.

    /** @extends {SuperClass} */
    class SubClass {}

Causes an ES5 emit that references SuperClass:

    /**
    * @extends {SomeBase}
    */
    var SubClass = /** @class */ (function (_super) {
        __extends(SubClass, _super);
        function SubClass() {
            return _super !== null && _super.apply(this, arguments) || this;
        }
        return SubClass;
    }(SomeBase));

Note the literal references to `SomeBase`.

This appears to be an accidental effect of 0f55566cf4. It refactored
`getEffectiveBaseTypeNode` for type checking, but missed an instance
where it is also used for emit logic. This change fixes the problem by
specifically getting the heritage clauses directly off the AST.

Change-Id: I3128a757e5924e2528c61230a90ac13650852542
2019-01-04 08:13:14 -08:00
Sheetal Nandi b7d7d5f7b3 Merge pull request #29252 from Microsoft/tscWatchIsolatedModules
Do not cache semantic diagnostics with --isolated modules
2019-01-03 14:35:19 -08:00
Sheetal Nandi a633f95da7 Do not cache semantic diagnostics with --isolated modules
Fixes #28332
2019-01-03 14:07:25 -08:00
Sheetal Nandi bce9e2c11c Merge pull request #29250 from Microsoft/hasContextSensitiveReturnExpression
Fix function declaration without body to be checked as context sensitive
2019-01-03 14:06:13 -08:00
Sheetal Nandi f4a6fb79da Replace ternary expression 2019-01-03 13:29:43 -08:00
Sheetal Nandi d8ee4116ef Fix function declaration without body to be checked as context sensitive
Fixes #29032
2019-01-03 12:46:39 -08:00
Sheetal Nandi c426fc6868 Merge branch 'master' into tscWatchExportUpdate 2019-01-03 11:35:54 -08:00
Sheetal Nandi d35ea02cc6 Merge pull request #29247 from ajafff/organizeimports-crash
Fix crash in organizeImports
2019-01-03 08:54:34 -08:00
Klaus Meinhardt 66314e1f85 Merge branch 'master' of github.com:Microsoft/TypeScript into rest-param-destructuring 2019-01-03 17:45:17 +01:00
Klaus Meinhardt 6a9ad0e2eb Fix crash in organizeImports
Fixes: #29236
2019-01-03 16:20:46 +01:00
Sheetal Nandi 24cc284d19 The assert that cached value of config file existance is always correct, might not be true if file watcher is not invoked before creating configured project
Fixes #29191
2019-01-02 15:42:12 -08:00
Benjamin Lichtman 799656a037 Merge pull request #29214 from uniqueiniquity/nestedAsyncCodeFix
Only provide suggestion for outermost async fix
2018-12-31 17:18:39 -08:00
Benjamin Lichtman 11585d29bc Merge pull request #29218 from uniqueiniquity/jsdocSpanForVarStatement
Jsdoc span for var statement
2018-12-31 16:27:34 -08:00
Benjamin Lichtman cb57f17aba Simplify approach 2018-12-31 16:25:26 -08:00
Benjamin Lichtman 28e68a6891 Fix spelling of convertible 2018-12-31 16:00:24 -08:00
Benjamin Lichtman 048d04684b use existing util functions 2018-12-31 15:56:54 -08:00
Benjamin Lichtman aebcb6df36 Merge pull request #29216 from uniqueiniquity/multilineArgumentSpans
Give appropriate outlining span for array and object literals as args in call expression
2018-12-31 15:18:07 -08:00
Benjamin Lichtman 34970d8a69 give jsdoc outline span before func exp assigned to var 2018-12-31 15:10:22 -08:00