Jesse Trinity
d88ea4e1f8
address PR comments
2020-06-02 19:06:12 -07:00
Jesse Trinity
ca58c0e03c
fix merge conflicts
2020-05-29 14:04:07 -07:00
Jesse Trinity
06d2461cd0
convert import trigger reason only
2020-05-29 13:03:05 -07:00
Jesse Trinity
a7c07d67d8
convert export cursor only changes
2020-05-29 13:02:57 -07:00
Jesse Trinity
e565931392
fix up some bools
2020-05-29 13:01:33 -07:00
Jesse Trinity
f3751fbdf3
change type of RefactorTriggerReason
2020-05-29 12:54:59 -07:00
Jesse Trinity
23f4dc9bd9
use enum for RefactorTriggerReason
2020-05-29 12:49:41 -07:00
Jesse Trinity
f1127e6e94
extract symbol
2020-05-29 12:45:57 -07:00
Jesse Trinity
602ee995d0
fix lint errors
2020-05-29 12:45:54 -07:00
Jesse Trinity
55880ee5e0
extractType explicitCursorRequest
2020-05-29 12:41:28 -07:00
Jesse Trinity
0296254a60
extractType
2020-05-29 12:41:22 -07:00
Jesse Trinity
1efcffc915
convertImport
2020-05-29 12:41:18 -07:00
Jesse Trinity
c3828ed086
loosen convertExport conditions
2020-05-29 12:41:14 -07:00
Jesse Trinity
02fa39a6a9
enable explicit requests for addOrRemoveBracesToArrowFunction
2020-05-29 12:41:10 -07:00
Jesse Trinity
bac046573f
add trigger reason to protocol
2020-05-29 12:41:06 -07:00
Daniel Rosenwasser
6128f30c3b
Merge pull request #38821 from a-tarasyuk/bug/23716
...
fix(23716): signature help of tagged template doesn't show instantiated signature
2020-05-28 17:19:23 -07:00
Nathan Shively-Sanders
bfa1744586
Merge pull request #37894 from microsoft/always-error-on-property-override-accessor
...
Always error on property override accessor
2020-05-26 10:37:07 -07:00
Alexander T
6e98431cec
fix(23716): show generic type in tagged template expression
2020-05-26 19:16:44 +03:00
Nathan Shively-Sanders
324d292e3d
Merge pull request #38415 from Kingwl/navTree-fix
...
Fix trancked es5 classes after new scope
2020-05-26 09:05:17 -07:00
Nathan Shively-Sanders
e466bb94c1
Fix multi-file usage
...
1. Follow aliases with getSupers.
2. Make fix in file with superclass, not with the error.
2020-05-22 09:06:05 -07:00
Nathan Shively-Sanders
802e87b1eb
Merge branch 'master' into always-error-on-property-override-accessor
2020-05-21 16:08:09 -07:00
Daniel Rosenwasser
62675a58d6
Merge pull request #38481 from a-tarasyuk/bug/38463
...
fix(38463): No indexed access completions after Record<...>
2020-05-21 13:44:44 -07:00
Alexander T
c00aeb5486
fix(33286): add outlining for arrow function with one parameter ( #38631 )
2020-05-21 08:07:47 -07:00
Alexander T
528d82afd1
Merge branch 'master' of https://github.com/microsoft/TypeScript into bug/38463
2020-05-20 11:04:55 +03:00
Alexander T
1c72da6e49
fix(38463): show completions for index access properties
2020-05-20 10:17:20 +03:00
Wesley Wigham
5f597e69b2
Support naming tuple members ( #38234 )
...
* Initial draft of named tuple members
* Show tuple labels and documentation in completions
* Swap allowed syntax to parameter-like
* Add quickfix for labeled tuple syntax mistakes
* Add refactoring to convert list of signatures to single overload
* Fix small bug in visitor verification
* Signature help for rest parameters which are unions of tuples are displayed as seperate entries now
* Expand sanity check test cases in conformance suite
* Add tests and code for preserving tuple names through spreads where possible
* More refactoring tests, some comment preservation and some fixed formatting of multiline tuples
* Handle missing parameter named in isValidDeclarationForTupleLabel
* Minor text fixes
2020-05-19 15:54:02 -07:00
Jack Works and Andrew Branch
7ec467e270
fix: extract const in jsx ( #37912 )
...
* fix: extract const in jsx
* Update src/services/refactors/extractSymbol.ts
Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com >
* Update src/services/refactors/extractSymbol.ts
Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com >
Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com >
2020-05-19 14:29:49 -07:00
Nathan Shively-Sanders
415b2e7969
Merge pull request #38656 from a-tarasyuk/bug/33233
...
fix(33233): Code Folding on es5 object functions does not work (getOutliningSpans)
2020-05-19 14:18:42 -07:00
Andrew Branch
707e977056
Ensure formatter can always get a newline character ( #38579 )
...
* Ensure formatter can always get a newline character
* Make FormatContext.host optional since it’s not necessary if format options are all applied
* Make FormattingHost required again
2020-05-19 13:14:32 -07:00
Alexander T
2b703d254a
fix(33233): add outlining for comments before property access expression
2020-05-18 15:26:46 +03:00
Eli Barzilay
d7dd06e36d
goToDefinition: find only the value if it's the RHS of an assignment
2020-05-15 18:55:57 -04:00
Jesse Trinity
1a15717bc4
Fix regression organize imports duplicates comments ( #38599 )
...
* delete import comments on organize imports
* add unit test
* accept new baseline
* respond to review comment
2020-05-15 14:25:11 -07:00
Alexander T
71711257ea
fix(33836): allow readonly modifier for a field with only get accessor ( #36543 )
2020-05-13 13:28:32 -07:00
Daniel Rosenwasser
b682ee1a8a
Merge pull request #38489 from microsoft/removeDuplicateInfo
...
Remove duplicate JSDoc comments
2020-05-12 12:52:15 -07:00
Nathan Shively-Sanders
3f06adf662
Merge pull request #38240 from a-tarasyuk/feat/add-outlining-spans-for-object-destructuring-elements
...
feat: Add outlining spans for object destructuring elements
2020-05-12 07:35:03 -07:00
Nathan Shively-Sanders
cbf15bb6ed
feat(38225): change diagnostic message for remove braces from arrow function body ( #38226 )
2020-05-12 07:27:09 -07:00
Alexander T
5895493815
fix(37877): include in NavigationBar default exported child items ( #38255 )
2020-05-12 07:26:31 -07:00
Daniel
e9867a7353
Add and use the 'intersperse' helper function.
2020-05-11 22:17:01 +00:00
Ron Buckton
d07e866a28
Fix for jsdoc modifiers on constructor params ( #38403 )
...
* Fix for jsdoc modifiers on constructor params
* Update Public API baseline and fix unique symbol grammar check for js
2020-05-11 15:07:43 -07:00
Daniel
74d6d04d70
Don't add duplicates of JSDoc comments.
2020-05-11 21:39:47 +00:00
jeffy-g
fd71eb2c85
fix broken regex on "src/services/completions.ts#getCompletionData" ( #37546 )
...
* fix broken regex on src/services/completions.ts#840
* update forslash test
breaking changes fourslash test
Temporarily retain the before fix code for easy comparison
* regex
* fourslash test (Temporary code
* regex: more restrictive in terms of jsdoc format
fourslash test
* regex: max indent restriction
* achieved goal by partial match strategy (probably
* cleanup
* apply requested changes
* Change to a version with minimal modifications
2020-05-11 13:02:20 -07:00
Alexander T
738b6b5b68
fix(38073): hide 'Extract to function in global scope' action for arrow functions which use 'this' ( #38107 )
2020-05-11 12:25:25 -07:00
kingwl
6f4deaea78
Fix tranced es5 classes after new scope
2020-05-08 17:34:41 +08:00
Eli Barzilay
29cf049e61
moveToNewFile: handle namespace imports too
...
Fixes #35591
2020-05-07 11:46:36 -04:00
Alexander T and Nathan Shively-Sanders
683b3ec058
feat(37782): 'declare method' quick fix for adding a private method ( #37806 )
...
* feat(37782): add quick-fix action to declare a private method for names that start from underscore
* better merge order in messages json
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com >
2020-05-06 15:10:02 -07:00
Wenlu Wang and Nathan Shively-Sanders
e66ce879a9
expose jsdoc factory ( #29539 )
...
* expose jsdoc factory
* refactor jsdoc factory
* correctly jsdoc factory types
* update jsdoc factory
* Add check for delete expression must be optional
* accept new basseline
* Revert "Add check for delete expression must be optional"
This reverts commit 76937c3b1a .
* remove newline
* make linter happy
* Add deprecated comment
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com >
2020-05-06 15:06:12 -07:00
Wenlu Wang and Nathan Shively-Sanders
8d78984558
Add support of contextual quick info ( #37451 )
...
* Add support of contextual quick info
* Avoid document comment map
* Make lint happy
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com >
2020-05-06 15:05:31 -07:00
Alexander T
d86bdf4e5c
add outlining spans for the tuple type ( #38179 )
2020-05-05 09:48:33 -07:00
Alexander T
2bdc8fdc94
add outlining spans for array destructuring elements ( #38191 )
2020-05-05 09:29:24 -07:00
Daniel Rosenwasser
94c5c3ff47
Add missing arguments to typeToTypeNode. ( #38336 )
...
* Add missing arguments to typeToTypeNode.
* Use returnTypeNode as the enclosingDeclaration.
* Add a test.
2020-05-04 19:32:27 -07:00