If these are regular comments, then they won't appear in our d.ts files.
But, now we are relying on an external d.ts bundler to produce our final
merged, so they need to be present in the "input" d.ts files, meaning
they have to be JSDoc comments.
These comments only work today because all of our builds load their TS
files from scratch, so they see the actual source files and their
non-JSDoc comments.
The comments also need to be attached to a declaration, not floating,
otherwise they won't be used by api-extractor, so move them if needed.
This step converts as many explicit accesses as possible in favor of direct imports from the modules in which things were declared. This restores the code (as much as possible) back to how it looked originally before the explicitify step, e.g. instead of "ts.Node" and "ts.Symbol", we have just "Node" and "Symbol".
This step converts each file into an exported module by hoisting the namespace bodies into the global scope and transferring internal markers down onto declarations as needed.
The namespaces are reconstructed as "barrel"-style modules, which are identical to the old namespace objects in structure. These reconstructed namespaces are then imported in the newly module-ified files, making existing expressions like "ts." valid.
* Remove language version check for extended escapes.
* Accepted baselines.
* Record whether nodes have extended Unicode escapes. Replace them in the es2015 transform.
* Accepted baselines.
* Move file to better-reflect generality of tests.
* Added tests for variables at the top level.
* Accepted baselines.
* Added test for extended astral character.
* Accepted baseline.
* Enable sourcemaps in tests.
* Accepted baselines.
* Call `setOriginalNode` on identifiers with extended escapes.
* Add tests for identifiers and private identifiers with escape sequences.
* Accepted baselines.
* Store the tokenValue instead of tokenText on PrivateIdentifiers, since the latter can contain escapes and lead to semantic discrepancies.
* Accepted baselines.
* Check for leading escape sequences in PrivateIdentifiers.
* Accepted baselines.
* Fix lints.
* feat(7481): add explicit type compatibility check with 'satisfies' expression
* Add failing test for lack of intersectioned contextual type
* Implement the behavior
* Add test corresponding to the 'if'
* Add test based on defined scenarios
* remove isExpression in favor of using type casting
* move tests from compiler to conformance folder
* update baseline
* add missing contextFlags argument
* use asserted type
* accept baseline
Co-authored-by: Ryan Cavanaugh <ryanca@microsoft.com>
* Simplify getVariancesWorker and associated logic
* Accept new API baselines
* Add 'in' and 'out' modififers / add modifiers to type parameters
* Check variance annotations
* Update test runner
* Accept new API baselines
* Allow variance annotations only on certain type parameters
* Add deprecated implementation of createTypeParameterDeclaration
* Accept new API baselines
* Report variance markers as 'sub-XXX' and 'super-XXX'
* Add tests
* Accept new baselines
Error message improvement for unexpected tokens in the following situations:
* A word was parsed that seems to have a low edit distance from a known common keyword
* A word was parsed that seems to be a known common keyword and a name _without_ a space in-between
* Parsing in a particular type of node (mostly a class property declaration) got a different word or token than expected
___
* Specific diagnostic suggestions for unexpected keywords or identifier
* Don't reach into there, that's not allowed
* Improved error when there is already an initializer
* Specific module error message for invalid template literal strings
* Skip 'unexpected keyword or identifier' diagnostics for declare nodes
* Improve error for function calls in type positions
* Switch class properties to old diagnostic
* Corrected errors in class members and reused existing textToKeywordObj map
* Corrected more baselines from the merge
* Update src/compiler/parser.ts
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
* Mostly addressed feedback
* Clarified function call type message
* Split up and clarified parsing vs error functions
* Swap interface name complaints back, and skip new errors on unknown (invalid) tokens
* Used tokenToString, not a raw semicolon
* Inline getExpressionText helper
* Remove remarks in src/compiler/parser.ts
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
* Simplify or optimize regexes with polynomial time worst cases
* PR feedback & cleanup
Co-authored-by: David Michon <dmichon-msft@users.noreply.github.com>
* Use builtin scanner function for checking whitespace in fallback method (its faster)
Co-authored-by: David Michon <dmichon-msft@users.noreply.github.com>
* Everything mostly works
A couple of mixed, nested references don't work yet.
The scanner+parser interaction is wrong, the parser consumes one too
many spaces, and the checker+services code needs a little cleanup.
* Cleanup
1. I decided that correctly parsing a#b.c, an entity name containing an
instance reference, is not worth the work.
2. I made the scanner, at least the jsdoc part, emit a # token, and
provided a reScanPrivateIdentifier in order to convert #a to # a.
3. I cleaned up the code in the checker.
2. Unrelated: I added a missing space in linkPart display.
* Cleanup lint + var naming
* investigate+clean up a couple of TODOs
* Fix lint in utilities.ts
* change name to JSDocMemberName
* address PR comments
* Private identifiers use standard identifer scanning
Previously they used an old copy of the identifier scanning code that
didn't handle extended unicode yet.
* gotta fix that const lint
Jake Bailey
Ron Buckton
Oleksandr T
Ryan Cavanaugh
David Sherret
形素叢集・ぐらふぃーむ
Daniel Rosenwasser
Anders Hejlsberg
Wenlu WangandRon Buckton
Josh GoldbergandDaniel Rosenwasser
Wesley WighamandDavid Michon
Andrew Branch
Armando Aguirre